@apla/clickhouse - npm Package Compare versions

Comparing version 1.5.2 to 1.5.3

package.json

 {
   "name": "@apla/clickhouse",
-  "version": "1.5.2",
+  "version": "1.5.3",
   "description": "Yandex ClickHouse database interface",
@@ -5,0 +5,0 @@ "main": "src/clickhouse.js",

README.md

@@ -102,2 +102,4 @@ Database interface for http://clickhouse.yandex
  * **pathname**: pathname of ClickHouse server or `/` if omited,
+ * **port**:     port number,
+ * **protocol**: "https:" or "http:", default "http:".
 
@@ -104,0 +106,0 @@ `queryOptions` object can contain any option from Settings (docs:

src/clickhouse.js

 var http = require ('http');
+var https = require('https');
 var url  = require ('url');
@@ -174,4 +175,4 @@ var qs   = require ('querystring');
 	});
-
-	var req = http.request (reqParams, httpResponseHandler.bind (
+	var requestInstance = reqParams.protocol === 'https:' ? https : http;
+	var req = requestInstance.request (reqParams, httpResponseHandler.bind (
 		this, stream, reqParams, reqData, cb
@@ -178,0 +179,0 @@ ));

test/05-insert.js

@@ -33,2 +33,5 @@ var ClickHouse = require ("../src/clickhouse");
 
+var testDate = new Date ();
+var testDateISO = testDate.toISOString ().replace (/\..*/, '').replace ('T', ' ');
+
 describe ("insert data", function () {
@@ -110,4 +113,2 @@
 
-		var now = new Date ();
-
 		var stream = ch.query ("INSERT INTO t2", {queryOptions: {database: dbName}}, function (err, result) {
@@ -121,3 +122,3 @@ assert (!err, err);
 				assert.equal (result.data[0][2], null);
-				assert.equal (result.data[0][3], now.toISOString().replace (/\..*/, '').replace ('T', ' '));
+				assert.equal (result.data[0][3], testDateISO);
 
@@ -134,3 +135,3 @@ assert.equal (result.data[1][0], 20);
 
-		stream.write ([1, 2.22, null, now]);
+		stream.write ([1, 2.22, null, testDate]);
 		stream.write ("20\t1.11\twrqwefqwef\t2017-07-07 12:12:12");
@@ -156,4 +157,2 @@
 
-		var now = new Date ();
-
 		var stream = ch.query ("INSERT INTO t3", {format: "JSONEachRow", queryOptions: {database: dbName}}, function (err, result) {
@@ -167,3 +166,3 @@ assert (!err, err);
 				assert.equal (result.data[0][2], null);
-				assert.equal (result.data[0][3], now.toISOString().replace (/\..*/, '').replace ('T', ' '));
+				assert.equal (result.data[0][3], testDateISO);
 
@@ -182,3 +181,3 @@ assert.equal (result.data[1][0], 20);
 
-		stream.write ({a: 1, b: 2.22, x: null, z: now});
+		stream.write ({a: 1, b: 2.22, x: null, z: testDate});
 		stream.write ({a: 20, b: 1.11, x: "wrqwefqwef", z: "2017-07-07 12:12:12"});
@@ -195,4 +194,2 @@
 
-		var now = new Date ();
-
 		var stream = ch.query ("INSERT INTO t3 SELECT * FROM t2", {}, function (err, result) {
@@ -206,3 +203,3 @@ assert (!err, err);
 				assert.equal (result.data[2][2], null);
-				assert.equal (result.data[2][3], now.toISOString().replace (/\..*/, '').replace ('T', ' '));
+				assert.equal (result.data[2][3], testDateISO);
 
@@ -230,3 +227,2 @@ assert.equal (result.data[3][0], 20);
 
-		var now = new Date ();
 		var csvFileName = __filename.replace ('.js', '.csv');
@@ -243,6 +239,6 @@
 
-					done ();
-
+					fs.unlink (csvFileName, function () {
+						done ();
+					});
 				});
-
 			});
@@ -275,3 +271,2 @@
 
-		var now = new Date ();
 		var tsvFileName = __filename.replace ('.js', '.tsv');
@@ -288,4 +283,5 @@
 
-					done ();
-
+					fs.unlink (tsvFileName, function () {
+						done ();
+					});
 				});
@@ -292,0 +288,0 @@ });

New alerts

Network access

Supply chain risk

This module accesses the network.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

64352

increased by0.28%

Lines of code

1452

increased by0.21%

Number of lines in readme file

226

increased by0.89%

Worsened metrics

Number of medium supply chain risk alerts

6

increased by20%

No dependency changes