@applitools/visual-grid-client - npm Package Compare versions

Comparing version 7.2.5 to 7.2.6

History.md

 
+v7.2.5 / 2018-11-28
+===================
+
+* 7.2.5 - Amit Zur [[fbe8df2](https://github.com/applitools/visual-grid-client/commit/fbe8df2a430592365de791ac62c4b6f4a31465cf)]
+* update eyes-sdk-core to 4.3.0 - Amit Zur [[e7257f9](https://github.com/applitools/visual-grid-client/commit/e7257f9dab24afd3b9f4b6feb46b5d34fc70d9e2)]
+
+v7.2.4 / 2018-11-28
+===================
+
+* 7.2.4 - Amit Zur [[c04fef4](https://github.com/applitools/visual-grid-client/commit/c04fef44d209e6466f2bb55850fba64787f658b8)]
+* add error message for 400 bad request - Amit Zur [[fae453b](https://github.com/applitools/visual-grid-client/commit/fae453b37e8afe9cc4d6db43a9a439c8cfcf56c0)]
+
+v7.2.3 / 2018-11-27
+===================
+
+* 7.2.3 - Amit Zur [[54f38c1](https://github.com/applitools/visual-grid-client/commit/54f38c11cdb6b8e6fb2870dca44653982083edbb)]
+* handle max concurrency for renders with failures - Amit Zur [[550b89c](https://github.com/applitools/visual-grid-client/commit/550b89c1af60749ec36d4dae420dae6d7c7c0086)]
+
+v7.2.2 / 2018-11-26
+===================
+
+* 7.2.2 - Amit Zur [[3e0bf86](https://github.com/applitools/visual-grid-client/commit/3e0bf869e0ffb037b20934a802fe52e0c4248bd4)]
+* resolve test also when failures happen in checkWindow - Amit Zur [[96c9a46](https://github.com/applitools/visual-grid-client/commit/96c9a46a9ada8ead6ff47898b34adad20277de01)]
+
+v7.2.1 / 2018-11-26
+===================
+
+* 7.2.1 - Amit Zur [[14b2d64](https://github.com/applitools/visual-grid-client/commit/14b2d641e5ee8fbac0102e725a2c8f73a50dcdc4)]
+
+v7.2.0 / 2018-11-26
+===================
+
+* 7.2.0 - Amit Zur [[404d5f6](https://github.com/applitools/visual-grid-client/commit/404d5f6b8cc770029f4294d793112de43067403a)]
+* concurrency optimization - don't stop on open - Amit Zur [[5f298d7](https://github.com/applitools/visual-grid-client/commit/5f298d7bbb6159a463f5f8dc6e7a1c0e87a09dd6)]
+* support username/password in proxy - Amit Zur [[3ef6d19](https://github.com/applitools/visual-grid-client/commit/3ef6d1905cd0a6b9054eb3899ac8ea456a3d193c)]
+* changelog - Amit Zur [[4cd92cb](https://github.com/applitools/visual-grid-client/commit/4cd92cb8a17e8be89dff401f5e53ceea760fad90)]
+
 v7.1.2 / 2018-11-25
@@ -3,0 +40,0 @@ ===================

package.json

 {
   "name": "@applitools/visual-grid-client",
-  "version": "7.2.5",
+  "version": "7.2.6",
   "description": "",
@@ -5,0 +5,0 @@ "main": "src/visual-grid-client.js",

src/sdk/checkWindow.js

@@ -63,8 +63,3 @@ 'use strict';
     setCheckWindowPromises(
-      browsers.map(
-        (_browser, i) =>
-          checkWindowJob(getCheckWindowPromises()[i], i)
-            .catch(setError)
-            .then(() => openEyesPromises[i]), // the checkWindow job must end after openEyes has finished, otherwise resolving the whole test in close will fail, because the test was never started. This situation could happen when a render fails and the checkWindow promise is rejected before waiting on openEyesPromise.
-      ),
+      browsers.map((_browser, i) => checkWindowJob(getCheckWindowPromises()[i], i).catch(setError)),
     );
@@ -71,0 +66,0 @@

src/sdk/closeEyes.js

 'use strict';
 const {presult} = require('@applitools/functional-commons');
 
-function makeCloseEyes({getError, logger, getCheckWindowPromises, wrappers, resolveTests}) {
+function makeCloseEyes({
+  getError,
+  logger,
+  getCheckWindowPromises,
+  wrappers,
+  resolveTests,
+  openEyesPromises,
+}) {
   return async function closeEyes(throwEx = true) {
@@ -13,17 +20,19 @@ let error;
       getCheckWindowPromises().map((checkWindowPromise, i) =>
-        checkWindowPromise.then(async () => {
-          if ((error = getError())) {
-            logger.log('closeEyes() aborting after checkWindow');
+        checkWindowPromise
+          .then(() => openEyesPromises[i]) // the close job must start after openEyes has finished, otherwise resolving the whole test in will fail, because the test was never started. This situation could happen when a render fails and the checkWindow promise is rejected before waiting on openEyesPromise.;
+          .then(async () => {
+            if ((error = getError())) {
+              logger.log('closeEyes() aborting after checkWindow');
+              resolveTests[i]();
+              throw error;
+            }
+
+            const [closeErr, closeResult] = await presult(wrappers[i].close(throwEx));
             resolveTests[i]();
-            throw error;
-          }
+            if (closeErr) {
+              throw closeErr;
+            }
 
-          const [closeErr, closeResult] = await presult(wrappers[i].close(throwEx));
-          resolveTests[i]();
-          if (closeErr) {
-            throw closeErr;
-          }
-
-          return closeResult;
-        }),
+            return closeResult;
+          }),
       ),
@@ -30,0 +39,0 @@ );

src/sdk/openEyes.js

@@ -192,2 +192,3 @@ 'use strict';
       resolveTests,
+      openEyesPromises,
     });
@@ -194,0 +195,0 @@

No alert changes

Improved metrics

Total package byte prevSize

103288

increased by2.17%

Lines of code

1868

increased by0.21%

No dependency changes