@atlaskit/inline-dialog - npm Package Compare versions

Comparing version 12.0.15 to 12.1.0

CHANGELOG.md

 # @atlaskit/inline-dialog
 
+## 12.1.0
+
+### Minor Changes
+
+- [minor][91b7a1415b](https://bitbucket.org/atlassian/atlaskit-mk-2/commits/91b7a1415b):
+
+  Adding an optional prop `testId` that will set the attribute value `data-testid`. It will help products to write better integration and end to end tests.
+
 ## 12.0.15
@@ -4,0 +12,0 @@

dist/cjs/InlineDialog/index.d.ts

@@ -21,3 +21,3 @@ import React, { Component } from 'react';
 export { InlineDialog as InlineDialogWithoutAnalytics };
-declare const _default: React.ForwardRefExoticComponent<Pick<Pick<Pick<Props, "children" | "content" | "isOpen" | "onContentBlur" | "onContentClick" | "onContentFocus" | "onClose" | "placement">, "children" | "content"> & Partial<Pick<Pick<Props, "children" | "content" | "isOpen" | "onContentBlur" | "onContentClick" | "onContentFocus" | "onClose" | "placement">, "isOpen" | "onContentBlur" | "onContentClick" | "onContentFocus" | "onClose" | "placement">> & Partial<Pick<{
+declare const _default: React.ForwardRefExoticComponent<Pick<Pick<Pick<Props, "children" | "content" | "isOpen" | "onContentBlur" | "onContentClick" | "onContentFocus" | "onClose" | "placement" | "testId">, "children" | "content" | "testId"> & Partial<Pick<Pick<Props, "children" | "content" | "isOpen" | "onContentBlur" | "onContentClick" | "onContentFocus" | "onClose" | "placement" | "testId">, "isOpen" | "onContentBlur" | "onContentClick" | "onContentFocus" | "onClose" | "placement">> & Partial<Pick<{
     isOpen: boolean;
@@ -29,3 +29,3 @@ onContentBlur: () => void;
     placement: Placement;
-}, never>> & React.RefAttributes<any> & import("@atlaskit/analytics-next/dist/cjs/withAnalyticsContext").WithContextProps, "children" | "content" | "isOpen" | "onContentBlur" | "onContentClick" | "onContentFocus" | "onClose" | "placement" | "key" | "analyticsContext"> & React.RefAttributes<any>>;
+}, never>> & React.RefAttributes<any> & import("@atlaskit/analytics-next/dist/cjs/withAnalyticsContext").WithContextProps, "children" | "content" | "isOpen" | "onContentBlur" | "onContentClick" | "onContentFocus" | "onClose" | "placement" | "testId" | "key" | "analyticsContext"> & React.RefAttributes<any>>;
 export default _default;

dist/cjs/InlineDialog/index.js

@@ -55,3 +55,3 @@ "use strict";
         var _this = this;
-        var _a = this.props, children = _a.children, placement = _a.placement, isOpen = _a.isOpen, content = _a.content, onContentBlur = _a.onContentBlur, onContentFocus = _a.onContentFocus, onContentClick = _a.onContentClick;
+        var _a = this.props, children = _a.children, placement = _a.placement, isOpen = _a.isOpen, content = _a.content, onContentBlur = _a.onContentBlur, onContentFocus = _a.onContentFocus, onContentClick = _a.onContentClick, testId = _a.testId;
         var popper = isOpen ? (react_1.default.createElement(popper_1.Popper, { placement: placement }, function (_a) {
@@ -62,3 +62,3 @@ var ref = _a.ref, style = _a.style;
                     ref(node);
-                }, style: style }, content));
+                }, style: style, "data-testid": testId }, content));
         })) : null;
@@ -65,0 +65,0 @@ return (react_1.default.createElement(popper_1.Manager, null,

dist/cjs/types.d.ts

@@ -25,2 +25,4 @@ import { ReactNode } from 'react';
     placement?: Placement;
+    /** A `testId` prop is provided for specified elements, which is a unique string that appears as a data attribute `data-testid` in the rendered code, serving as a hook for automated tests */
+    testId?: string;
 }

dist/cjs/version.json

 {
 	"name": "@atlaskit/inline-dialog",
-	"version": "12.0.15",
+	"version": "12.1.0",
 	"sideEffects": false
 }

dist/esm/InlineDialog/index.d.ts

@@ -21,3 +21,3 @@ import React, { Component } from 'react';
 export { InlineDialog as InlineDialogWithoutAnalytics };
-declare const _default: React.ForwardRefExoticComponent<Pick<Pick<Pick<Props, "children" | "content" | "isOpen" | "onContentBlur" | "onContentClick" | "onContentFocus" | "onClose" | "placement">, "children" | "content"> & Partial<Pick<Pick<Props, "children" | "content" | "isOpen" | "onContentBlur" | "onContentClick" | "onContentFocus" | "onClose" | "placement">, "isOpen" | "onContentBlur" | "onContentClick" | "onContentFocus" | "onClose" | "placement">> & Partial<Pick<{
+declare const _default: React.ForwardRefExoticComponent<Pick<Pick<Pick<Props, "children" | "content" | "isOpen" | "onContentBlur" | "onContentClick" | "onContentFocus" | "onClose" | "placement" | "testId">, "children" | "content" | "testId"> & Partial<Pick<Pick<Props, "children" | "content" | "isOpen" | "onContentBlur" | "onContentClick" | "onContentFocus" | "onClose" | "placement" | "testId">, "isOpen" | "onContentBlur" | "onContentClick" | "onContentFocus" | "onClose" | "placement">> & Partial<Pick<{
     isOpen: boolean;
@@ -29,3 +29,3 @@ onContentBlur: () => void;
     placement: Placement;
-}, never>> & React.RefAttributes<any> & import("@atlaskit/analytics-next/dist/cjs/withAnalyticsContext").WithContextProps, "children" | "content" | "isOpen" | "onContentBlur" | "onContentClick" | "onContentFocus" | "onClose" | "placement" | "key" | "analyticsContext"> & React.RefAttributes<any>>;
+}, never>> & React.RefAttributes<any> & import("@atlaskit/analytics-next/dist/cjs/withAnalyticsContext").WithContextProps, "children" | "content" | "isOpen" | "onContentBlur" | "onContentClick" | "onContentFocus" | "onClose" | "placement" | "testId" | "key" | "analyticsContext"> & React.RefAttributes<any>>;
 export default _default;

dist/esm/InlineDialog/index.js

@@ -53,3 +53,3 @@ import { __extends } from "tslib";
         var _this = this;
-        var _a = this.props, children = _a.children, placement = _a.placement, isOpen = _a.isOpen, content = _a.content, onContentBlur = _a.onContentBlur, onContentFocus = _a.onContentFocus, onContentClick = _a.onContentClick;
+        var _a = this.props, children = _a.children, placement = _a.placement, isOpen = _a.isOpen, content = _a.content, onContentBlur = _a.onContentBlur, onContentFocus = _a.onContentFocus, onContentClick = _a.onContentClick, testId = _a.testId;
         var popper = isOpen ? (React.createElement(Popper, { placement: placement }, function (_a) {
@@ -60,3 +60,3 @@ var ref = _a.ref, style = _a.style;
                     ref(node);
-                }, style: style }, content));
+                }, style: style, "data-testid": testId }, content));
         })) : null;
@@ -63,0 +63,0 @@ return (React.createElement(Manager, null,

dist/esm/types.d.ts

@@ -25,2 +25,4 @@ import { ReactNode } from 'react';
     placement?: Placement;
+    /** A `testId` prop is provided for specified elements, which is a unique string that appears as a data attribute `data-testid` in the rendered code, serving as a hook for automated tests */
+    testId?: string;
 }

dist/esm/version.json

 {
 	"name": "@atlaskit/inline-dialog",
-	"version": "12.0.15",
+	"version": "12.1.0",
 	"sideEffects": false
 }

package.json

 {
   "name": "@atlaskit/inline-dialog",
-  "version": "12.0.15",
+  "version": "12.1.0",
   "description": "An inline dialog React component for secondary content and controls that are displayed on user request",
@@ -46,5 +46,9 @@ "license": "Apache-2.0",
     "@atlaskit/visual-regression": "^0.1.3",
+    "@atlaskit/webdriver-runner": "^0.1.0",
+    "@testing-library/react": "^8.0.1",
+    "jest-in-case": "^1.0.2",
     "enzyme": "^3.7.0",
     "react-dom": "^16.8.0",
-    "react-lorem-component": "^0.12.2"
+    "react-lorem-component": "^0.12.2",
+    "wait-for-expect": "^1.2.0"
   },
@@ -51,0 +55,0 @@ "keywords": [

No alert changes

Improved metrics

Total package byte prevSize

58813

increased by1.71%

Lines of code

425

increased by0.95%

Worsened metrics

Dev dependency count

16

increased by33.33%

Number of package files

34

decreased by-2.86%

No dependency changes