@azure/core-rest-pipeline - npm Package Compare versions

Comparing version 1.18.2-alpha.20241202.2 to 1.18.2-alpha.20241203.2

dist/browser/policies/tracingPolicy.js

@@ -118,5 +118,10 @@ // Copyright (c) Microsoft Corporation.
         }
-        span.setStatus({
-            status: "success",
-        });
+        // Per semantic conventions, only set the status to error if the status code is 4xx or 5xx.
+        // Otherwise, the status MUST remain unset.
+        // https://opentelemetry.io/docs/specs/semconv/http/http-spans/#status
+        if (response.status >= 400) {
+            span.setStatus({
+                status: "error",
+            });
+        }
         span.end();
@@ -123,0 +128,0 @@ }

dist/browser/util/file.js

@@ -9,2 +9,5 @@ // Copyright (c) Microsoft Corporation.
     },
+    bytes: () => {
+        throw new Error("Not implemented");
+    },
     slice: () => {
@@ -11,0 +14,0 @@ throw new Error("Not implemented");

dist/commonjs/policies/tracingPolicy.js

@@ -122,5 +122,10 @@ "use strict";
         }
-        span.setStatus({
-            status: "success",
-        });
+        // Per semantic conventions, only set the status to error if the status code is 4xx or 5xx.
+        // Otherwise, the status MUST remain unset.
+        // https://opentelemetry.io/docs/specs/semconv/http/http-spans/#status
+        if (response.status >= 400) {
+            span.setStatus({
+                status: "error",
+            });
+        }
         span.end();
@@ -127,0 +132,0 @@ }

dist/commonjs/util/file.js

@@ -14,2 +14,5 @@ "use strict";
     },
+    bytes: () => {
+        throw new Error("Not implemented");
+    },
     slice: () => {
@@ -16,0 +19,0 @@ throw new Error("Not implemented");

dist/esm/policies/tracingPolicy.js

@@ -118,5 +118,10 @@ // Copyright (c) Microsoft Corporation.
         }
-        span.setStatus({
-            status: "success",
-        });
+        // Per semantic conventions, only set the status to error if the status code is 4xx or 5xx.
+        // Otherwise, the status MUST remain unset.
+        // https://opentelemetry.io/docs/specs/semconv/http/http-spans/#status
+        if (response.status >= 400) {
+            span.setStatus({
+                status: "error",
+            });
+        }
         span.end();
@@ -123,0 +128,0 @@ }

dist/esm/util/file.js

@@ -9,2 +9,5 @@ // Copyright (c) Microsoft Corporation.
     },
+    bytes: () => {
+        throw new Error("Not implemented");
+    },
     slice: () => {
@@ -11,0 +14,0 @@ throw new Error("Not implemented");

dist/react-native/policies/tracingPolicy.js

@@ -118,5 +118,10 @@ // Copyright (c) Microsoft Corporation.
         }
-        span.setStatus({
-            status: "success",
-        });
+        // Per semantic conventions, only set the status to error if the status code is 4xx or 5xx.
+        // Otherwise, the status MUST remain unset.
+        // https://opentelemetry.io/docs/specs/semconv/http/http-spans/#status
+        if (response.status >= 400) {
+            span.setStatus({
+                status: "error",
+            });
+        }
         span.end();
@@ -123,0 +128,0 @@ }

dist/react-native/util/file.js

@@ -9,2 +9,5 @@ // Copyright (c) Microsoft Corporation.
     },
+    bytes: () => {
+        throw new Error("Not implemented");
+    },
     slice: () => {
@@ -11,0 +14,0 @@ throw new Error("Not implemented");

package.json

 {
   "name": "@azure/core-rest-pipeline",
-  "version": "1.18.2-alpha.20241202.2",
+  "version": "1.18.2-alpha.20241203.2",
   "description": "Isomorphic client library for making HTTP requests in node.js and browser.",
@@ -5,0 +5,0 @@ "sdk-type": "client",

No alert changes

Improved metrics

Total package byte prevSize

2020856

increased by0.17%

Lines of code

19820

increased by0.16%

No dependency changes