@bbc/psammead-navigation - npm Package Compare versions

Comparing version 9.2.13 to 9.2.14

CHANGELOG.md

@@ -6,2 +6,3 @@ # Psammead Navigation Changelog
 |---------|-------------|
+| 9.2.14 | [PR#4587](https://github.com/bbc/psammead/pull/4587) Fix TalkBack reading nested spans incorrectly |
 | 9.2.13 | [PR#4590](https://github.com/bbc/psammead/pull/4590) Fix talkback comma bug |
@@ -8,0 +9,0 @@ | 9.2.12 | [PR#4574](https://github.com/bbc/psammead/pull/4574) Bumps psammead-styles |

package.json

 {
   "name": "@bbc/psammead-navigation",
-  "version": "9.2.13",
+  "version": "9.2.14",
   "description": "A navigation bar to use on index pages",
@@ -5,0 +5,0 @@ "main": "dist/index.js",

src/index.jsx

@@ -119,2 +119,3 @@ import React from 'react';
 const CurrentLink = ({
+  linkId,
   children: link,
@@ -131,2 +132,4 @@ script,
       brandHighlightColour={brandHighlightColour}
+      // This is a temporary fix for the a11y nested span's bug experienced in TalkBack, refer to the following issue: https://github.com/bbc/simorgh/issues/9652
+      id={`NavigationLinks-${linkId}`}
     >
@@ -140,2 +143,3 @@ <VisuallyHiddenText>{`${currentPageText}, `}</VisuallyHiddenText>
 CurrentLink.propTypes = {
+  linkId: string.isRequired,
   children: string.isRequired,
@@ -190,5 +194,8 @@ script: shape(scriptPropType).isRequired,
           brandHighlightColour={brandHighlightColour}
+          // This is a temporary fix for the a11y nested span's bug experienced in TalkBack, refer to the following issue: https://github.com/bbc/simorgh/issues/9652
+          aria-labelledby={`NavigationLinks-${link}`}
           {...props}
         >
           <CurrentLink
+            linkId={link}
             script={script}
@@ -195,0 +202,0 @@ currentPageText={currentPageText}

New alerts

Long strings

Supply chain risk

Contains long string literals, which may be a sign of obfuscated or packed code.

Found 1 instance in 1 package

Fixed alerts

Long strings

Supply chain risk

Contains long string literals, which may be a sign of obfuscated or packed code.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

453990

increased by2.24%

Lines of code

3639

increased by1.48%

No dependency changes