@blockprotocol/hook - npm Package Compare versions

Comparing version 0.0.7 to 0.0.8-canary.0

dist/react.js

@@ -123,3 +123,2 @@ import { useEffect, useLayoutEffect, useRef, useState } from "react";
         const existingHookId = existingHookRef.current?.id;
-        const teardownPromise = existingHookRef.current?.teardown?.().catch() ?? Promise.resolve();
         if (node && service) {
@@ -169,44 +168,44 @@ const controller = new AbortController();
             existingHookRef.current = hook;
-            teardownPromise
-                .then(() => {
-                if (service.destroyed || controller.signal.aborted) {
-                    return;
-                }
-                return service
-                    .hook({
-                    data: {
-                        hookId: hook.id,
-                        entityId,
-                        node,
-                        type,
-                        path,
-                    },
-                })
-                    .then((response) => {
-                    if (!controller.signal.aborted) {
-                        if (response.errors) {
-                            if (response.errors.length === 1 &&
-                                response.errors[0]?.code === "NOT_IMPLEMENTED") {
-                                const teardown = fallbackRef.current(node);
-                                hook.teardown = async () => {
-                                    controller.abort();
-                                    teardown?.();
-                                };
+            void service
+                .hook({
+                data: {
+                    hookId: hook.id,
+                    entityId,
+                    node,
+                    type,
+                    path,
+                },
+            })
+                .then((response) => {
+                if (!controller.signal.aborted) {
+                    if (response.errors) {
+                        const firstError = response.errors[0];
+                        if (firstError?.code === "NOT_IMPLEMENTED") {
+                            const teardown = fallbackRef.current(node);
+                            hook.teardown = async () => {
+                                controller.abort();
+                                teardown?.();
+                            };
+                        }
+                        else if (firstError?.code === "NOT_FOUND") {
+                            const errMsg = `Hook with id ${hook.id} was not found by embedding application`;
+                            if (node === null) {
+                                // don't throw if the request was for hook deletion – the embedding app can't find the hook, things can continue
+                                // eslint-disable-next-line no-console -- useful for debugging
+                                console.warn(`${errMsg} – no hook to remove`);
                             }
                             else {
-                                // eslint-disable-next-line no-console
-                                console.error(response.errors);
-                                throw new Error("Unknown error in hook");
+                                throw new Error(errMsg);
                             }
                         }
-                        else if (response.data) {
-                            hook.id = response.data.hookId;
+                        else {
+                            // eslint-disable-next-line no-console
+                            console.error(response.errors);
+                            throw new Error("Unknown error in hook");
                         }
                     }
-                });
-            })
-                .catch((err) => {
-                catchError(() => {
-                    throw err;
-                });
+                    else if (response.data) {
+                        hook.id = response.data.hookId;
+                    }
+                }
             });
@@ -213,0 +212,0 @@ }

package.json

 {
   "name": "@blockprotocol/hook",
-  "version": "0.0.7",
+  "version": "0.0.8-canary.0",
   "description": "Implementation of the Block Protocol Hook service specification for blocks and embedding applications",
@@ -60,3 +60,3 @@ "keywords": [
     "@local/tsconfig": "0.0.0-private",
-    "eslint": "8.25.0",
+    "eslint": "8.26.0",
     "rimraf": "^3.0.2",
@@ -63,0 +63,0 @@ "typescript": "4.8.4"

No alert changes

Worsened metrics

Total package byte prevSize

34361

decreased by-59.25%

Number of package files

22

decreased by-4.35%

Lines of code

492

decreased by-0.2%

No dependency changes