@browserless/devices - npm Package Compare versions

Comparing version 5.18.3 to 5.18.5

CHANGELOG.md

@@ -6,2 +6,10 @@ # Change Log
 
+## [5.18.5](https://github.com/kikobeats/browserless/tree/master/packages/devices/compare/v5.18.4...v5.18.5) (2019-11-27)
+
+**Note:** Version bump only for package @browserless/devices
+
+
+
+
+
 ## [5.18.3](https://github.com/kikobeats/browserless/tree/master/packages/devices/compare/v5.18.2...v5.18.3) (2019-11-26)
@@ -8,0 +16,0 @@

package.json

@@ -5,3 +5,3 @@ {
   "homepage": "https://browserless.js.org/#/?id=devices",
-  "version": "5.18.3",
+  "version": "5.18.5",
   "main": "src/index.js",
@@ -33,2 +33,6 @@ "author": {
   },
+  "devDependencies": {
+    "ava": "latest",
+    "puppeteer-core": "latest"
+  },
   "engines": {
@@ -42,6 +46,6 @@ "node": ">= 8"
     "coverage": "exit 0",
-    "test": "exit 0"
+    "test": "ava"
   },
   "license": "MIT",
-  "gitHead": "d977beefabfad05058edb2c0d367ed6a488f095f"
+  "gitHead": "f6ac4d3f3bd9b9fe7b6c0e10bf6bb451f121076d"
 }

src/index.js

@@ -5,4 +5,4 @@ 'use strict'
 
-const getDevice = (devices, deviceName) =>
-  deviceName && devices.find(device => device.name.toLowerCase() === deviceName.toLowerCase())
+const findDevice = (devices, deviceName) =>
+  devices.find(device => device.name.toLowerCase() === deviceName.toLowerCase())
 
@@ -17,6 +17,15 @@ module.exports = ({
   const devices = puppeteerDevices.concat(customDevices)
-  return {
-    devices,
-    getDevice: getDevice.bind(null, devices)
+
+  return ({ headers = {}, device: deviceId = '', viewport } = {}) => {
+    const device = findDevice(devices, deviceId)
+    return device
+      ? {
+        userAgent: device.userAgent || headers['user-agent'],
+        viewport: { ...device.viewport, ...viewport }
+      }
+      : {
+        userAgent: headers['user-agent'],
+        viewport
+      }
   }
 }

No alert changes

Improved metrics

Total package byte prevSize

8433

increased by6.76%

Lines of code

111

increased by7.77%

Worsened metrics

Dev dependency count

2

increased byInfinity%

No dependency changes