@code-pushup/models - npm Package Compare versions

Comparing version 0.8.20 to 0.8.21

index.js

@@ -15,10 +15,10 @@ // packages/models/src/lib/audit.ts
 // packages/models/src/lib/implementation/utils.ts
-var slugRegex = /^[a-z0-9]+(?:-[a-z0-9]+)*$/;
+var slugRegex = /^[a-z\d]+(?:-[a-z\d]+)*$/;
 var filenameRegex = /^(?!.*[ \\/:*?"<>|]).+$/;
 function hasDuplicateStrings(strings) {
-  const uniqueStrings = Array.from(new Set(strings));
-  const duplicatedStrings = strings.filter(
-    /* @__PURE__ */ ((i) => (v) => uniqueStrings[i] !== v || !++i)(0)
+  const sortedStrings = [...strings].sort();
+  const duplStrings = sortedStrings.filter(
+    (item, index) => index !== 0 && item === sortedStrings[index - 1]
   );
-  return duplicatedStrings.length === 0 ? false : duplicatedStrings;
+  return duplStrings.length === 0 ? false : [...new Set(duplStrings)];
 }
@@ -29,5 +29,4 @@ function hasMissingStrings(toCheck, existing) {
 }
-function errorItems(items, transform = (items2) => items2.join(", ")) {
-  const paredItems = items ? items : [];
-  return transform(paredItems);
+function errorItems(items, transform = (itemArr) => itemArr.join(", ")) {
+  return transform(items || []);
 }
@@ -38,3 +37,2 @@ function exists(value) {
 function getMissingRefsForCategories(categories, plugins) {
-  const missingRefs = [];
   const auditRefsFromCategory = categories.flatMap(
@@ -44,5 +42,3 @@ ({ refs }) => refs.filter(({ type }) => type === "audit").map(({ plugin, slug }) => `${plugin}/${slug}`)
   const auditRefsFromPlugins = plugins.flatMap(
-    ({ audits, slug: pluginSlug }) => {
-      return audits.map(({ slug }) => `${pluginSlug}/${slug}`);
-    }
+    ({ audits, slug: pluginSlug }) => audits.map(({ slug }) => `${pluginSlug}/${slug}`)
   );
@@ -53,5 +49,2 @@ const missingAuditRefs = hasMissingStrings(
   );
-  if (Array.isArray(missingAuditRefs) && missingAuditRefs.length > 0) {
-    missingRefs.push(...missingAuditRefs);
-  }
   const groupRefsFromCategory = categories.flatMap(
@@ -61,5 +54,3 @@ ({ refs }) => refs.filter(({ type }) => type === "group").map(({ plugin, slug }) => `${plugin}#${slug} (group)`)
   const groupRefsFromPlugins = plugins.flatMap(
-    ({ groups, slug: pluginSlug }) => {
-      return Array.isArray(groups) ? groups.map(({ slug }) => `${pluginSlug}#${slug} (group)`) : [];
-    }
+    ({ groups, slug: pluginSlug }) => Array.isArray(groups) ? groups.map(({ slug }) => `${pluginSlug}#${slug} (group)`) : []
   );
@@ -70,6 +61,4 @@ const missingGroupRefs = hasMissingStrings(
   );
-  if (Array.isArray(missingGroupRefs) && missingGroupRefs.length > 0) {
-    missingRefs.push(...missingGroupRefs);
-  }
-  return missingRefs.length ? missingRefs : false;
+  const missingRefs = [missingAuditRefs, missingGroupRefs].filter((refs) => Array.isArray(refs) && refs.length > 0).flat();
+  return missingRefs.length > 0 ? missingRefs : false;
 }
@@ -118,3 +107,3 @@ function missingRefsForCategoriesErrorMsg(categories, plugins) {
     description
-  } = options || {};
+  } = options ?? {};
   return z.object(
@@ -121,0 +110,0 @@ {

package.json

 {
   "name": "@code-pushup/models",
-  "version": "0.8.20",
+  "version": "0.8.21",
   "dependencies": {
@@ -5,0 +5,0 @@ "zod": "^3.22.1",

src/lib/implementation/utils.d.ts

@@ -31,3 +31,3 @@ import type { CategoryConfig } from '../category-config';
  */
-export declare function errorItems(items: string[] | false, transform?: (items: string[]) => string): string;
+export declare function errorItems(items: string[] | false, transform?: (itemArr: string[]) => string): string;
 export declare function exists<T>(value: T): value is NonNullable<T>;
@@ -34,0 +34,0 @@ /**

No alert changes

Worsened metrics

Total package byte prevSize

1303246

decreased by-0.02%

Lines of code

16346

decreased by-0.07%

No dependency changes