@coozzy/cal-dav - npm Package Compare versions

Comparing version 2.3.5 to 2.3.6

dist/index.js

@@ -129,17 +129,13 @@ "use strict";
           for (const alarm of alarms) {
-            const calDavAlarm = new ICAL.Component('valarm');
-            const action = new ICAL.Property('action');
-            action.setValue('DISPLAY');
-            calDavAlarm.addProperty(action);
-            if (description) {
-              const description = new ICAL.Property('description');
-              description.setValue(description);
-              calDavAlarm.addProperty(description);
+            if (!alarm.alarmIntervalValue || !alarm.alarmIntervalUnit) {
+              continue;
             }
-            if (alarm.alarmIntervalValue && alarm.alarmIntervalUnit) {
-              const trigger = new ICAL.Property('trigger');
-              trigger.setValue(`-P${this.requiresTimeDesignatorForDuration(alarm.alarmIntervalUnit) ? 'T' : ''}${alarm.alarmIntervalValue}${this.mapAlarmUnit(alarm.alarmIntervalUnit)}`);
-              calDavAlarm.addProperty(trigger);
+            if (alarm.alarmIntervalUnit === 'ALARM_UNIT_UNDEFINED' || alarm.alarmIntervalValue === 0) {
+              continue;
             }
-            event.component.addSubcomponent(calDavAlarm);
+            event.component.addPropertyWithValue('BEGIN', 'VALARM');
+            event.component.addPropertyWithValue('action', 'DISPLAY');
+            event.component.addPropertyWithValue('description', description);
+            event.component.addPropertyWithValue('trigger', `-P${this.requiresTimeDesignatorForDuration(alarm.alarmIntervalUnit) ? 'T' : ''}${alarm.alarmIntervalValue}${this.mapAlarmUnit(alarm.alarmIntervalUnit)}`);
+            event.component.addPropertyWithValue('END', 'VALARM');
           }
@@ -146,0 +142,0 @@ }

package.json

 {
   "name": "@coozzy/cal-dav",
-  "version": "2.3.5",
+  "version": "2.3.6",
   "description": "Simple cal dav client.",
@@ -5,0 +5,0 @@ "main": "dist/index.js",

src/index.ts

@@ -200,17 +200,15 @@ import * as ICAL from 'ical.js';
                 for (const alarm of alarms) {
-                    const calDavAlarm = new ICAL.Component('valarm');
-                    const action = new ICAL.Property('action');
-                    action.setValue('DISPLAY');
-                    calDavAlarm.addProperty(action);
-                    if (description) {
-                        const description = new ICAL.Property('description');
-                        description.setValue(description);
-                        calDavAlarm.addProperty(description);
+                    if (!alarm.alarmIntervalValue || !alarm.alarmIntervalUnit) {
+                        continue;
                     }
-                    if (alarm.alarmIntervalValue && alarm.alarmIntervalUnit) {
-                        const trigger = new ICAL.Property('trigger');
-                        trigger.setValue(`-P${this.requiresTimeDesignatorForDuration(alarm.alarmIntervalUnit) ? 'T' : ''}${alarm.alarmIntervalValue}${this.mapAlarmUnit(alarm.alarmIntervalUnit)}`);
-                        calDavAlarm.addProperty(trigger);
+                    if (alarm.alarmIntervalUnit === 'ALARM_UNIT_UNDEFINED' || alarm.alarmIntervalValue === 0){
+                        continue;
                     }
-                    event.component.addSubcomponent(calDavAlarm);
+                    event.component.addPropertyWithValue('BEGIN', 'VALARM');
+
+                    event.component.addPropertyWithValue('action', 'DISPLAY');
+                    event.component.addPropertyWithValue('description', description);
+                    event.component.addPropertyWithValue('trigger', `-P${this.requiresTimeDesignatorForDuration(alarm.alarmIntervalUnit) ? 'T' : ''}${alarm.alarmIntervalValue}${this.mapAlarmUnit(alarm.alarmIntervalUnit)}`);
+
+                    event.component.addPropertyWithValue('END', 'VALARM');
                 }
@@ -217,0 +215,0 @@ }

No alert changes

Worsened metrics

Total package byte prevSize

86963

decreased by-0.28%

Lines of code

1844

decreased by-0.43%

No dependency changes