@cycle/dom - npm Package Compare versions

Comparing version 10.0.0-rc20 to 10.0.0-rc21

lib/isolateModule.js

@@ -27,2 +27,6 @@ "use strict";
         var delegators = this.eventDelegators.get(scope);
+        if (!delegators) {
+            delegators = [];
+            this.eventDelegators.set(scope, delegators);
+        }
         delegators[delegators.length] = eventDelegator;
@@ -39,10 +43,10 @@ };
                 var elm = vNode.elm, _b = vNode.data, data = _b === void 0 ? {} : _b;
-                var oldIsolate = oldData.isolate || "";
-                var isolate = data.isolate || "";
-                if (isolate) {
-                    if (oldIsolate) {
-                        self.removeScope(oldIsolate);
+                var oldScope = oldData.isolate || "";
+                var scope = data.isolate || "";
+                if (scope) {
+                    if (oldScope) {
+                        self.removeScope(oldScope);
                     }
-                    self.setScope(elm, isolate);
-                    var delegators = self.eventDelegators.get(isolate);
+                    self.setScope(elm, scope);
+                    var delegators = self.eventDelegators.get(scope);
                     if (delegators) {
@@ -54,7 +58,7 @@ for (var i = 0, len = delegators.length; i < len; ++i) {
                     else if (delegators === void 0) {
-                        self.eventDelegators.set(isolate, []);
+                        self.eventDelegators.set(scope, []);
                     }
                 }
-                if (oldIsolate && !isolate) {
-                    self.removeScope(isolate);
+                if (oldScope && !scope) {
+                    self.removeScope(scope);
                 }
@@ -65,12 +69,12 @@ },
                 var elm = vNode.elm, _b = vNode.data, data = _b === void 0 ? {} : _b;
-                var oldIsolate = oldData.isolate || "";
-                var isolate = data.isolate || "";
-                if (isolate) {
-                    if (oldIsolate) {
-                        self.removeScope(oldIsolate);
+                var oldScope = oldData.isolate || "";
+                var scope = data.isolate || "";
+                if (scope) {
+                    if (oldScope) {
+                        self.removeScope(oldScope);
                     }
-                    self.setScope(elm, isolate);
+                    self.setScope(elm, scope);
                 }
-                if (oldIsolate && !isolate) {
-                    self.removeScope(isolate);
+                if (oldScope && !scope) {
+                    self.removeScope(scope);
                 }
@@ -77,0 +81,0 @@ },

package.json

 {
   "name": "@cycle/dom",
-  "version": "10.0.0-rc20",
+  "version": "10.0.0-rc21",
   "description": "The standard DOM Driver for Cycle.js, based on Snabbdom",
@@ -5,0 +5,0 @@ "license": "MIT",

src/isolateModule.ts

@@ -33,2 +33,6 @@ import {VNode} from 'snabbdom';
     let delegators = this.eventDelegators.get(scope);
+    if (!delegators) {
+      delegators = [];
+      this.eventDelegators.set(scope, delegators);
+    }
     delegators[delegators.length] = eventDelegator;
@@ -47,8 +51,8 @@ }
         const {elm, data = {}} = vNode;
-        const oldIsolate = oldData.isolate || ``;
-        const isolate = data.isolate || ``;
-        if (isolate) {
-          if (oldIsolate) { self.removeScope(oldIsolate); }
-          self.setScope(elm, isolate);
-          const delegators = self.eventDelegators.get(isolate);
+        const oldScope = oldData.isolate || ``;
+        const scope = data.isolate || ``;
+        if (scope) {
+          if (oldScope) { self.removeScope(oldScope); }
+          self.setScope(elm, scope);
+          const delegators = self.eventDelegators.get(scope);
           if (delegators) {
@@ -59,7 +63,7 @@ for (let i = 0, len = delegators.length; i < len; ++i) {
           } else if (delegators === void 0) {
-            self.eventDelegators.set(isolate, []);
+            self.eventDelegators.set(scope, []);
           }
         }
-        if (oldIsolate && !isolate) {
-          self.removeScope(isolate);
+        if (oldScope && !scope) {
+          self.removeScope(scope);
         }
@@ -71,10 +75,10 @@ },
         const {elm, data = {}} = vNode;
-        const oldIsolate = oldData.isolate || ``;
-        const isolate = data.isolate || ``;
-        if (isolate) {
-          if (oldIsolate) { self.removeScope(oldIsolate); }
-          self.setScope(elm, isolate);
+        const oldScope = oldData.isolate || ``;
+        const scope = data.isolate || ``;
+        if (scope) {
+          if (oldScope) { self.removeScope(oldScope); }
+          self.setScope(elm, scope);
         }
-        if (oldIsolate && !isolate) {
-          self.removeScope(isolate);
+        if (oldScope && !scope) {
+          self.removeScope(scope);
         }
@@ -81,0 +85,0 @@ },

No alert changes

Improved metrics

Total package byte prevSize

1276694

increased by0.03%

Lines of code

22324

increased by0.05%

No dependency changes