@cycle/xstream-adapter - npm Package Compare versions

Comparing version 1.0.5 to 2.0.0

lib/index.js

@@ -45,4 +45,4 @@ "use strict";
     },
-    makeHoldSubject: function () {
-        var stream = xstream_1.default.createWithMemory();
+    makeSubject: function () {
+        var stream = xstream_1.default.create();
         var observer = {
@@ -49,0 +49,0 @@ next: function (x) { stream.shamefullySendNext(x); },

package.json

 {
   "name": "@cycle/xstream-adapter",
-  "version": "1.0.5",
+  "version": "2.0.0",
   "description": "Cycle.js xstream Stream Adapter",
@@ -34,3 +34,3 @@ "main": "lib/index.js",
   "devDependencies": {
-    "@cycle/base": "^2.1.1",
+    "@cycle/base": "^3.0.0",
     "assert": "^1.3.0",
@@ -37,0 +37,0 @@ "babel-preset-es2015": "^6.6.0",

src/index.ts

@@ -7,3 +7,3 @@ import {
   DisposeFunction,
-  HoldSubject,
+  Subject,
 } from '@cycle/base';
@@ -54,4 +54,4 @@ import xs, {Stream, Producer} from 'xstream';
 
-  makeHoldSubject(): HoldSubject {
-    const stream = xs.createWithMemory();
+  makeSubject(): Subject {
+    const stream = xs.create();
 
@@ -58,0 +58,0 @@ const observer = {

test/index.js

@@ -5,3 +5,3 @@ import {describe, it} from 'mocha';
 import xs from 'xstream';
-import {MemoryStream} from 'xstream/core';
+import {MemoryStream, Stream} from 'xstream';
 
@@ -13,3 +13,3 @@ describe('XStreamAdapter', () => {
     assert.strictEqual(typeof XStreamAdapter.dispose, 'function');
-    assert.strictEqual(typeof XStreamAdapter.makeHoldSubject, 'function');
+    assert.strictEqual(typeof XStreamAdapter.makeSubject, 'function');
     assert.strictEqual(typeof XStreamAdapter.isValidStream, 'function');
@@ -42,11 +42,11 @@ assert.strictEqual(typeof XStreamAdapter.streamSubscribe, 'function');
 
-  it('should create a hold subject which can be fed and subscribed to', (done) => {
-    const holdSubject = XStreamAdapter.makeHoldSubject();
-    assert.strictEqual(holdSubject.stream instanceof MemoryStream, true);
-    assert.strictEqual(XStreamAdapter.isValidStream(holdSubject.stream), true);
+  it('should create a subject which can be fed and subscribed to', (done) => {
+    const subject = XStreamAdapter.makeSubject();
+    assert.strictEqual(subject.stream instanceof Stream, true);
+    assert.strictEqual(XStreamAdapter.isValidStream(subject.stream), true);
 
     const observer1Expected = [1, 2, 3, 4];
-    const observer2Expected = [2, 3, 4];
+    const observer2Expected = [3, 4];
 
-    XStreamAdapter.streamSubscribe(holdSubject.stream, {
+    XStreamAdapter.streamSubscribe(subject.stream, {
       next: (x) => assert.strictEqual(x, observer1Expected.shift()),
@@ -57,6 +57,6 @@ error: done,
 
-    holdSubject.observer.next(1);
-    holdSubject.observer.next(2);
+    subject.observer.next(1);
+    subject.observer.next(2);
 
-    XStreamAdapter.streamSubscribe(holdSubject.stream, {
+    XStreamAdapter.streamSubscribe(subject.stream, {
       next: (x) => assert.strictEqual(x, observer2Expected.shift()),
@@ -67,5 +67,5 @@ error: done,
 
-    holdSubject.observer.next(3);
-    holdSubject.observer.next(4);
-    holdSubject.observer.complete();
+    subject.observer.next(3);
+    subject.observer.next(4);
+    subject.observer.complete();
 
@@ -76,3 +76,3 @@ setTimeout(done, 20);
   it('should not complete a sink stream when dispose() is called', (done) => {
-    const sinkProxy = XStreamAdapter.makeHoldSubject();
+    const sinkProxy = XStreamAdapter.makeSubject();
     const sink = xs.periodic(50);
@@ -79,0 +79,0 @@

typings.json

 {
   "name": "xstream",
   "main": "lib/index.d.ts",
-  "dependencies": {
-    "@cycle/base": "npm:@cycle/base",
-    "xstream": "npm:xstream"
-  },
+  "dependencies": {},
   "devDependencies": {},
@@ -9,0 +6,0 @@ "ambientDependencies": {

typings/browser.d.ts

 /// <reference path="browser/ambient/es6-shim/index.d.ts" />
 /// <reference path="browser/ambient/mocha/index.d.ts" />
 /// <reference path="browser/ambient/node/index.d.ts" />
-/// <reference path="browser/definitions/@cycle/base/index.d.ts" />
-/// <reference path="browser/definitions/xstream/index.d.ts" />

typings/main.d.ts

 /// <reference path="main/ambient/es6-shim/index.d.ts" />
 /// <reference path="main/ambient/mocha/index.d.ts" />
 /// <reference path="main/ambient/node/index.d.ts" />
-/// <reference path="main/definitions/@cycle/base/index.d.ts" />
-/// <reference path="main/definitions/xstream/index.d.ts" />

No alert changes

Worsened metrics

Total package byte prevSize

340169

decreased by-14.7%

Number of package files

23

decreased by-14.81%

Lines of code

7636

decreased by-18.96%

No dependency changes