@elastic.io/component-commons-library - npm Package Compare versions

Comparing version 3.0.3-dev.14 to 3.0.3-dev.15

package.json

 {
   "name": "@elastic.io/component-commons-library",
-  "version": "3.0.3-dev.14",
+  "version": "3.0.3-dev.15",
   "description": "Library for most common component development cases",
@@ -67,2 +67,2 @@ "author": {
   "license": "Apache-2.0"
-}
+}

src/authentication/FacelessRestClient.ts

@@ -53,10 +53,2 @@ import http from 'http';
 
-  protected handleRestResponse(response) {
-    if (response.status >= 400) {
-      throw new Error(getErrMsg(response));
-    }
-    this.logger.debug(`Response status: ${response.status}`);
-    return response;
-  }
-
   // options expects the following sub-variables:
@@ -93,10 +85,10 @@ //    url: Url to call
         const response = await axiosReqWithRetryOnServerError.call(this, requestOptions, this.axiosInst);
-        return this.handleRestResponse(response);
+        return response;
       } catch (err) {
+        this.logger.error(getErrMsg(err.response));
         error = err;
-        if (err.response?.status !== 401) {
-          return this.handleRestResponse(err.response);
+        if (err.response?.status < 500 && err.response?.status !== 401) {
+          throw err;
         }
-        this.logger.error(`URL: "${requestOptions.url}", method: ${requestOptions.method}, Error message: "${err.message}"`);
-        this.logger.info(`Request failed, retrying(${1 + currentRetry})`);
+        this.logger.info(`Request failed, faceless retrying(${1 + currentRetry})`);
         this.accessToken = null;
@@ -103,0 +95,0 @@ currentRetry++;

src/externalApi/index.ts

@@ -71,2 +71,3 @@ import axios, { AxiosResponse, AxiosInstance, AxiosRequestConfig } from 'axios';
     } catch (err) {
+      this.logger.error(getErrMsg(err.response));
       error = err;
@@ -77,3 +78,2 @@ if (err.response?.status < 500) {
       this.logger.info(`URL: "${options.url}", method: ${options.method}, Error message: "${err.message}"`);
-      this.logger.error(getErrMsg(err.response));
       this.logger.info(`Request failed, retrying(${1 + currentRetry})`);
@@ -80,0 +80,0 @@ await exponentialSleep(currentRetry);

No alert changes

Worsened metrics

Total package byte prevSize

261010

decreased by-0.12%

Lines of code

5733

decreased by-0.12%

No dependency changes