@fimbul/mimir - npm Package Compare versions

Comparing version 0.9.0 to 0.10.0-dev.20180509

package.json

 {
   "name": "@fimbul/mimir",
-  "version": "0.9.0",
+  "version": "0.10.0-dev.20180509",
   "description": "Core rules of the Fimbullinter project",
@@ -28,3 +28,3 @@ "main": "recommended.yaml",
   "dependencies": {
-    "@fimbul/ymir": "^0.9.0",
+    "@fimbul/ymir": "0.9.0",
     "chalk": "^2.3.2",
@@ -31,0 +31,0 @@ "debug": "^3.1.0",

src/rules/no-nan-compare.js

@@ -15,3 +15,8 @@ "use strict";
                 continue;
-            const parent = node.parent;
+            let parent = node.parent;
+            if (tsutils_1.isPropertyAccessExpression(parent)) {
+                if (!tsutils_1.isIdentifier(parent.expression) || parent.expression.text !== 'Number')
+                    continue;
+                parent = parent.parent;
+            }
             if (parent.kind === ts.SyntaxKind.CaseClause || tsutils_1.isBinaryExpression(parent) && isEqualityCheck(parent.operatorToken.kind))
@@ -18,0 +23,0 @@ this.addFailureAtNode(parent, "Comparing with 'NaN' always yields 'false'. Consider using 'isNaN' instead.");

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

316615

increased by0.14%

Lines of code

3504

increased by0.14%

Dependency changes

• Updated@fimbul/ymir@0.9.0