@fimbul/mimir - npm Package Compare versions

Comparing version 0.11.0 to 0.12.0-dev.20180624

package.json

 {
   "name": "@fimbul/mimir",
-  "version": "0.11.0",
+  "version": "0.12.0-dev.20180624",
   "description": "Core rules of the Fimbullinter project",
@@ -28,3 +28,3 @@ "main": "recommended.yaml",
   "dependencies": {
-    "@fimbul/ymir": "^0.11.0",
+    "@fimbul/ymir": "0.11.0",
     "chalk": "^2.3.2",
@@ -31,0 +31,0 @@ "debug": "^3.1.0",

src/rules/type-assertion.js

@@ -33,5 +33,8 @@ "use strict";
             continue;
+        const parent = node.parent;
+        const expressionNeedsParens = node.expression.kind === ts.SyntaxKind.BinaryExpression;
+        const needsParens = tsutils_1.isBinaryExpression(parent) && parent.operatorToken.kind === ts.SyntaxKind.AsteriskAsteriskToken;
         context.addFailure(match.index, node.end, "Use the classic type assertion style '<T>obj' instead.", [
-            ymir_1.Replacement.append(node.getStart(context.sourceFile), `<${node.type.getText(context.sourceFile)}>`),
-            ymir_1.Replacement.delete(node.expression.end, node.end),
+            ymir_1.Replacement.append(node.getStart(context.sourceFile), `${charIf(needsParens, '(')}<${node.type.getText(context.sourceFile)}>${charIf(expressionNeedsParens, '(')}`),
+            ymir_1.Replacement.replace(node.expression.end, node.end, charIf(expressionNeedsParens, ')') + charIf(needsParens, ')')),
         ]);
@@ -38,0 +41,0 @@ }

No alert changes

Improved metrics

Total package byte prevSize

354399

increased by0.22%

Lines of code

3791

increased by0.08%

Dependency changes

• Updated@fimbul/ymir@0.11.0