@firebase/installations - npm Package Compare versions

Comparing version 0.2.0-canary.634f84d to 0.2.0-canary.6a15cd7

dist/index.cjs.js

@@ -12,3 +12,3 @@ 'use strict';
 
-var version = "0.2.0-canary.634f84d";
+var version = "0.2.0-canary.6a15cd7";
 
@@ -236,3 +236,3 @@ /**
                     registeredInstallationEntry = {
-                        fid: responseValue.fid,
+                        fid: responseValue.fid || fid,
                         registrationStatus: 2 /* COMPLETED */,
@@ -239,0 +239,0 @@ refreshToken: responseValue.refreshToken,

dist/index.esm.js

@@ -7,3 +7,3 @@ import firebase from '@firebase/app';
 
-var version = "0.2.0-canary.634f84d";
+var version = "0.2.0-canary.6a15cd7";
 
@@ -231,3 +231,3 @@ /**
                     registeredInstallationEntry = {
-                        fid: responseValue.fid,
+                        fid: responseValue.fid || fid,
                         registrationStatus: 2 /* COMPLETED */,
@@ -234,0 +234,0 @@ refreshToken: responseValue.refreshToken,

dist/index.esm2017.js

@@ -5,3 +5,3 @@ import firebase from '@firebase/app';
 
-const version = "0.2.0-canary.634f84d";
+const version = "0.2.0-canary.6a15cd7";
 
@@ -197,3 +197,3 @@ /**
         const registeredInstallationEntry = {
-            fid: responseValue.fid,
+            fid: responseValue.fid || fid,
             registrationStatus: 2 /* COMPLETED */,
@@ -200,0 +200,0 @@ refreshToken: responseValue.refreshToken,

dist/src/interfaces/api-response.d.ts

@@ -20,3 +20,3 @@ /**
     readonly authToken: GenerateAuthTokenResponse;
-    readonly fid: string;
+    readonly fid?: string;
 }
@@ -23,0 +23,0 @@ export interface GenerateAuthTokenResponse {

package.json

 {
   "name": "@firebase/installations",
-  "version": "0.2.0-canary.634f84d",
+  "version": "0.2.0-canary.6a15cd7",
   "main": "dist/index.cjs.js",
@@ -50,8 +50,8 @@ "module": "dist/index.esm.js",
   "peerDependencies": {
-    "@firebase/app": "0.4.9-canary.634f84d",
-    "@firebase/app-types": "0.4.0-canary.634f84d"
+    "@firebase/app": "0.4.9-canary.6a15cd7",
+    "@firebase/app-types": "0.4.0-canary.6a15cd7"
   },
   "dependencies": {
-    "@firebase/installations-types": "0.1.1-canary.634f84d",
-    "@firebase/util": "0.2.20-canary.634f84d",
+    "@firebase/installations-types": "0.1.1-canary.6a15cd7",
+    "@firebase/util": "0.2.20-canary.6a15cd7",
     "idb": "3.0.2",
@@ -58,0 +58,0 @@ "tslib": "1.9.3"

src/api/create-installation.test.ts

@@ -108,2 +108,20 @@ /**
 
+  it('returns the FID from the request if the response does not contain one', async () => {
+    response = {
+      refreshToken: 'refreshToken',
+      authToken: {
+        token:
+          'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCeKKF2QT4fwpMeJf36POk6yJV_adQssw5c',
+        expiresIn: '604800s'
+      }
+    };
+    fetchSpy.resolves(new Response(JSON.stringify(response)));
+
+    const registeredInstallationEntry = await createInstallation(
+      appConfig,
+      inProgressInstallationEntry
+    );
+    expect(registeredInstallationEntry.fid).to.equal(FID);
+  });
+
   describe('failed request', () => {
@@ -110,0 +128,0 @@ it('throws a FirebaseError with the error information from the server', async () => {

src/api/create-installation.ts

@@ -58,3 +58,3 @@ /**
     const registeredInstallationEntry: RegisteredInstallationEntry = {
-      fid: responseValue.fid,
+      fid: responseValue.fid || fid,
       registrationStatus: RequestStatus.COMPLETED,
@@ -61,0 +61,0 @@ refreshToken: responseValue.refreshToken,

src/interfaces/api-response.ts

@@ -21,3 +21,3 @@ /**
   readonly authToken: GenerateAuthTokenResponse;
-  readonly fid: string;
+  readonly fid?: string;
 }
@@ -24,0 +24,0 @@

New alerts

Unidentified License

License

(Experimental) Something that seems like a license was found, but its contents could not be matched with a known license.

Found 2 instances in 1 package

Fixed alerts

Unidentified License

License

(Experimental) Something that seems like a license was found, but its contents could not be matched with a known license.

Found 2 instances in 1 package

Improved metrics

Total package byte prevSize

681530

increased by0.1%

Lines of code

7600

increased by0.21%

Dependency changes

• + Added@firebase/app@0.4.9-canary.6a15cd7(transitive)

• + Added@firebase/app-types@0.4.0-canary.6a15cd7(transitive)

• + Added@firebase/installations-types@0.1.1-canary.6a15cd7(transitive)

• + Added@firebase/logger@0.1.17-canary.6a15cd7(transitive)

• + Added@firebase/util@0.2.20-canary.6a15cd7(transitive)

• - Removed@firebase/app@0.4.9-canary.634f84d(transitive)

• - Removed@firebase/app-types@0.4.0-canary.634f84d(transitive)

• - Removed@firebase/installations-types@0.1.1-canary.634f84d(transitive)

• - Removed@firebase/logger@0.1.17-canary.634f84d(transitive)

• - Removed@firebase/util@0.2.20-canary.634f84d(transitive)

• Updated@firebase/installations-types@0.1.1-canary.6a15cd7

• Updated@firebase/util@0.2.20-canary.6a15cd7