@gooddata/js-utils - npm Package Compare versions

Comparing version 3.1.0 to 3.1.1

es/utils/walkme.d.ts

 export declare const GDC_WALKME_HASH = "325ea4b9b547463c991a62bf54090302";
 export declare function generateFinalUrl(walkmeHashFromWhiteLabel: string): string;
-export declare function load(walkmeHash: string, isEmbedded: boolean): void;
+export declare function load(walkmeHash: string): void;

es/utils/walkme.js

@@ -17,4 +17,4 @@ import { isProductionHostname } from './env';
 }
-export function load(walkmeHash, isEmbedded) {
-    if (!walkmeHash || !isEmbedded) {
+export function load(walkmeHash) {
+    if (!walkmeHash) {
         return;
@@ -21,0 +21,0 @@ }

lib/utils/walkme.js

@@ -23,4 +23,4 @@ 'use strict';
 }
-function load(walkmeHash, isEmbedded) {
-    if (!walkmeHash || !isEmbedded) {
+function load(walkmeHash) {
+    if (!walkmeHash) {
         return;
@@ -27,0 +27,0 @@ }

package.json

 {
   "name": "@gooddata/js-utils",
-  "version": "3.1.0",
+  "version": "3.1.1",
   "description": "Various utils shared on GoodData frontend",
@@ -5,0 +5,0 @@ "repository": {

src/utils/test/walkme.test.ts

@@ -30,3 +30,3 @@ import { generateFinalUrl, load, GDC_WALKME_HASH } from '../walkme';
         it('should not load script', () => {
-            load('', false);
+            load('');
             expect(loadJs.mock.calls.length).toBe(0);
@@ -37,3 +37,3 @@ });
             const fakeHash = 'fakeHash';
-            load(fakeHash, true);
+            load(fakeHash);
             expect(loadJs.mock.calls.length).toBe(1);
@@ -46,3 +46,3 @@ expect(loadJs).toBeCalledWith(`https://cdn.walkme.com/users/${fakeHash}/walkme_${fakeHash}_https.js`);
 
-            load(GDC_WALKME_HASH, true);
+            load(GDC_WALKME_HASH);
             expect(loadJs.mock.calls.length).toBe(1);
@@ -57,3 +57,3 @@ expect(loadJs).toBeCalledWith(
 
-            load(GDC_WALKME_HASH, true);
+            load(GDC_WALKME_HASH);
             expect(loadJs.mock.calls.length).toBe(1);
@@ -60,0 +60,0 @@ expect(loadJs).toBeCalledWith(

src/utils/walkme.ts

@@ -21,4 +21,4 @@ import { isProductionHostname } from './env';
 
-export function load(walkmeHash: string, isEmbedded: boolean): void {
-    if (!walkmeHash || !isEmbedded) { return; }
+export function load(walkmeHash: string): void {
+    if (!walkmeHash) { return; }
 
@@ -25,0 +25,0 @@ const url = generateFinalUrl(walkmeHash);

Fixed alerts

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Number of medium supply chain risk alerts

0

decreased by-100%

Worsened metrics

Total package byte prevSize

50409

decreased by-0.32%

No dependency changes