@gooddata/js-utils - npm Package Compare versions

Comparing version 3.1.0 to 3.1.1-naibinh-SD-47-walkme-2018-06-20T10-01-16-557Z

es/utils/walkme.d.ts

 export declare const GDC_WALKME_HASH = "325ea4b9b547463c991a62bf54090302";
 export declare function generateFinalUrl(walkmeHashFromWhiteLabel: string): string;
-export declare function load(walkmeHash: string, isEmbedded: boolean): void;
+export declare function load(walkmeHash: string): void;

es/utils/walkme.js

 import { isProductionHostname } from './env';
-var loadJs = require('load-js');
+import { loadScript } from './load-script';
 export var GDC_WALKME_HASH = '325ea4b9b547463c991a62bf54090302';
@@ -17,8 +17,8 @@ export function generateFinalUrl(walkmeHashFromWhiteLabel) {
 }
-export function load(walkmeHash, isEmbedded) {
-    if (!walkmeHash || !isEmbedded) {
+export function load(walkmeHash) {
+    if (!walkmeHash) {
         return;
     }
     var url = generateFinalUrl(walkmeHash);
-    loadJs(url) // load walkme script
+    loadScript(url) // load walkme script
         .catch(function () {
@@ -25,0 +25,0 @@ // tslint:disable-next-line:no-console

lib/utils/walkme.js

@@ -12,3 +12,4 @@ 'use strict';
 
-var loadJs = require('load-js');
+var _loadScript = require('./load-script');
+
 var GDC_WALKME_HASH = exports.GDC_WALKME_HASH = '325ea4b9b547463c991a62bf54090302';
@@ -24,8 +25,8 @@ function generateFinalUrl(walkmeHashFromWhiteLabel) {
 }
-function load(walkmeHash, isEmbedded) {
-    if (!walkmeHash || !isEmbedded) {
+function load(walkmeHash) {
+    if (!walkmeHash) {
         return;
     }
     var url = generateFinalUrl(walkmeHash);
-    loadJs(url) // load walkme script
+    (0, _loadScript.loadScript)(url) // load walkme script
     .catch(function () {
@@ -32,0 +33,0 @@ // tslint:disable-next-line:no-console

package.json

 {
   "name": "@gooddata/js-utils",
-  "version": "3.1.0",
+  "version": "3.1.1-naibinh-SD-47-walkme-2018-06-20T10-01-16-557Z",
   "description": "Various utils shared on GoodData frontend",
@@ -56,3 +56,2 @@ "repository": {
     "js-cookie": "^2.1.4",
-    "load-js": "^3.0.2",
     "lodash": "^4.17.4",
@@ -59,0 +58,0 @@ "lodash-es": "^4.17.4"

src/utils/test/walkme.test.ts

 import { generateFinalUrl, load, GDC_WALKME_HASH } from '../walkme';
 import { isProductionHostname } from '../env';
+import { loadScript } from '../load-script';
 
 jest.mock('../env');
-jest.mock('load-js');
+jest.mock('../load-script');
 
-const loadJs = require('load-js');
-
 describe('walkme', () => {
@@ -21,7 +20,7 @@
         beforeEach(() => {
-            loadJs.mockImplementation(() => Promise.resolve());
+            (loadScript as any).mockImplementation(() => Promise.resolve());
         });
 
         afterEach(() => {
-            loadJs.mockClear();
+            (loadScript as any).mockClear();
             (isProductionHostname as any).mockClear();
@@ -31,4 +30,4 @@ });
         it('should not load script', () => {
-            load('', false);
-            expect(loadJs.mock.calls.length).toBe(0);
+            load('');
+            expect((loadScript as any).mock.calls.length).toBe(0);
         });
@@ -38,5 +37,7 @@
             const fakeHash = 'fakeHash';
-            load(fakeHash, true);
-            expect(loadJs.mock.calls.length).toBe(1);
-            expect(loadJs).toBeCalledWith(`https://cdn.walkme.com/users/${fakeHash}/walkme_${fakeHash}_https.js`);
+            load(fakeHash);
+            expect((loadScript as any).mock.calls.length).toBe(1);
+            expect((loadScript as any)).toBeCalledWith(
+                `https://cdn.walkme.com/users/${fakeHash}/walkme_${fakeHash}_https.js`
+            );
         });
@@ -47,5 +48,5 @@
 
-            load(GDC_WALKME_HASH, true);
-            expect(loadJs.mock.calls.length).toBe(1);
-            expect(loadJs).toBeCalledWith(
+            load(GDC_WALKME_HASH);
+            expect((loadScript as any).mock.calls.length).toBe(1);
+            expect((loadScript as any)).toBeCalledWith(
                 `https://cdn.walkme.com/users/${GDC_WALKME_HASH}/test/walkme_${GDC_WALKME_HASH}_https.js`
@@ -58,5 +59,5 @@ );
 
-            load(GDC_WALKME_HASH, true);
-            expect(loadJs.mock.calls.length).toBe(1);
-            expect(loadJs).toBeCalledWith(
+            load(GDC_WALKME_HASH);
+            expect((loadScript as any).mock.calls.length).toBe(1);
+            expect((loadScript as any)).toBeCalledWith(
                 `https://cdn.walkme.com/users/${GDC_WALKME_HASH}/walkme_${GDC_WALKME_HASH}_https.js`
@@ -63,0 +64,0 @@ );

src/utils/walkme.ts

 import { isProductionHostname } from './env';
+import { loadScript } from './load-script';
 
-const loadJs = require('load-js');
-
 export const GDC_WALKME_HASH = '325ea4b9b547463c991a62bf54090302';
@@ -21,7 +20,8 @@
 
-export function load(walkmeHash: string, isEmbedded: boolean): void {
-    if (!walkmeHash || !isEmbedded) { return; }
+export function load(walkmeHash: string): void {
+    if (!walkmeHash) { return; }
 
     const url = generateFinalUrl(walkmeHash);
-    loadJs(url) // load walkme script
+
+    loadScript(url) // load walkme script
     .catch(() => {
@@ -28,0 +28,0 @@ // tslint:disable-next-line:no-console

New alerts

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Fixed alerts

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

54244

increased by7.26%

Dependency count

4

decreased by-20%

Number of package files

49

increased by11.36%

Lines of code

1118

increased by7.6%

Number of medium supply chain risk alerts

0

decreased by-100%

Worsened metrics

Number of low quality alerts

2

increased by100%

Dependency changes

• - Removedload-js@^3.0.2

• - Removedload-js@3.1.1(transitive)