@guardian/bridget - npm Package Compare versions

Comparing version 1.13.0 to 2.0.0

index.d.ts

@@ -12,3 +12,2 @@ export * from "./PurchaseScreenReason";
 export * from "./CommentResponse";
-export * from "./NewsletterSignUpResponse";
 export * from "./Metric";
@@ -15,0 +14,0 @@ import * as Environment from "./Environment";

index.js

@@ -30,3 +30,2 @@ "use strict";
 __export(require("./CommentResponse"));
-__export(require("./NewsletterSignUpResponse"));
 __export(require("./Metric"));
@@ -33,0 +32,0 @@ const Environment = __importStar(require("./Environment"));

Newsletters.d.ts

 /// <reference types="node" />
 import * as thrift from "@creditkarma/thrift-server-core";
-import * as NewsletterSignUpResponse from "./NewsletterSignUpResponse";
 export declare const serviceName: string;
@@ -31,10 +30,10 @@ export declare const annotations: thrift.IThriftAnnotations;
 export interface IRequestSignUp__Result {
-    success?: NewsletterSignUpResponse.INewsletterSignUpResponse;
+    success?: boolean;
 }
 export interface IRequestSignUp__ResultArgs {
-    success?: NewsletterSignUpResponse.INewsletterSignUpResponseArgs;
+    success?: boolean;
 }
 export declare const RequestSignUp__ResultCodec: thrift.IStructCodec<IRequestSignUp__ResultArgs, IRequestSignUp__Result>;
 export declare class RequestSignUp__Result extends thrift.StructLike implements IRequestSignUp__Result {
-    success?: NewsletterSignUpResponse.INewsletterSignUpResponse;
+    success?: boolean;
     readonly _annotations: thrift.IThriftAnnotations;
@@ -59,6 +58,6 @@ readonly _fieldAnnotations: thrift.IFieldAnnotations;
     };
-    requestSignUp(emailAddress: string, newsletterIdentityName: string, context?: Context): Promise<NewsletterSignUpResponse.INewsletterSignUpResponse>;
+    requestSignUp(emailAddress: string, newsletterIdentityName: string, context?: Context): Promise<boolean>;
 }
 export interface IHandler<Context = any> {
-    requestSignUp(emailAddress: string, newsletterIdentityName: string, context?: Context): NewsletterSignUpResponse.INewsletterSignUpResponseArgs | Promise<NewsletterSignUpResponse.INewsletterSignUpResponseArgs>;
+    requestSignUp(emailAddress: string, newsletterIdentityName: string, context?: Context): boolean | Promise<boolean>;
 }
@@ -65,0 +64,0 @@ export declare class Processor<Context = any> extends thrift.ThriftProcessor<Context, IHandler<Context>> {

Newsletters.js

@@ -17,3 +17,2 @@ "use strict";
 const thrift = __importStar(require("@creditkarma/thrift-server-core"));
-const NewsletterSignUpResponse = __importStar(require("./NewsletterSignUpResponse"));
 exports.serviceName = "Newsletters";
@@ -143,4 +142,4 @@ exports.annotations = {};
         if (obj.success != null) {
-            output.writeFieldBegin("success", thrift.TType.STRUCT, 0);
-            NewsletterSignUpResponse.NewsletterSignUpResponseCodec.encode(obj.success, output);
+            output.writeFieldBegin("success", thrift.TType.BOOL, 0);
+            output.writeBool(obj.success);
             output.writeFieldEnd();
@@ -164,4 +163,4 @@ }
                 case 0:
-                    if (fieldType === thrift.TType.STRUCT) {
-                        const value_5 = NewsletterSignUpResponse.NewsletterSignUpResponseCodec.decode(input);
+                    if (fieldType === thrift.TType.BOOL) {
+                        const value_5 = input.readBool();
                         _args.success = value_5;
@@ -191,3 +190,3 @@ }
         if (args.success != null) {
-            const value_6 = new NewsletterSignUpResponse.NewsletterSignUpResponse(args.success);
+            const value_6 = args.success;
             this.success = value_6;
@@ -194,0 +193,0 @@ }

package.json

 {
   "name": "@guardian/bridget",
-  "version": "1.13.0",
+  "version": "2.0.0",
   "description": "",
@@ -5,0 +5,0 @@ "main": "index.js",

No alert changes

Worsened metrics

Total package byte prevSize

386253

decreased by-1.22%

Number of package files

52

decreased by-3.7%

Lines of code

9859

decreased by-1.16%

No dependency changes