@lion/overlays - npm Package Compare versions

Comparing version 0.1.2 to 0.1.3

CHANGELOG.md

@@ -6,2 +6,13 @@ # Change Log
 
+## [0.1.3](https://github.com/ing-bank/lion/compare/@lion/overlays@0.1.2...@lion/overlays@0.1.3) (2019-04-28)
+
+
+### Bug Fixes
+
+* update storybook/linting; adjust story labels, eslint ignores ([8d96f84](https://github.com/ing-bank/lion/commit/8d96f84))
+
+
+
+
+
 ## [0.1.2](https://github.com/ing-bank/lion/compare/@lion/overlays@0.1.1...@lion/overlays@0.1.2) (2019-04-27)
@@ -8,0 +19,0 @@

package.json

 {
   "name": "@lion/overlays",
-  "version": "0.1.2",
+  "version": "0.1.3",
   "description": "Overlays System using lit-html for rendering",
@@ -33,6 +33,6 @@ "author": "ing-bank",
   "dependencies": {
-    "@lion/core": "^0.1.2"
+    "@lion/core": "^0.1.3"
   },
   "devDependencies": {
-    "@open-wc/storybook": "^0.1.5",
+    "@open-wc/demoing-storybook": "^0.2.0",
     "@open-wc/testing": "^0.11.1",
@@ -42,3 +42,3 @@ "@polymer/iron-test-helpers": "^3.0.1",
   },
-  "gitHead": "6497db62d375612d691f00120daa0cdb2d899dc5"
+  "gitHead": "bb1d1448b59f5b6579880a521f0695578d09eb73"
 }

src/GlobalOverlayController.js

@@ -1,3 +0,1 @@
-/* eslint-disable no-underscore-dangle, class-methods-use-this */
-
 import { render } from '@lion/core';
@@ -287,2 +285,3 @@ import { containFocus } from './utils/contain-focus';
    */
+  // eslint-disable-next-line class-methods-use-this
   _findOverlays(containers) {
@@ -316,2 +315,3 @@ return containers.map(container => container._overlayController);
    */
+  // eslint-disable-next-line class-methods-use-this
   _fadeOutBackdrop() {
@@ -318,0 +318,0 @@ GlobalOverlayController._rootNode.classList.add('global-overlays--backdrop-fade-out');

src/LocalOverlayController.js

@@ -1,3 +0,1 @@
-/* eslint-disable no-underscore-dangle, class-methods-use-this, no-unused-expressions */
-
 import { render, html } from '@lion/core';
@@ -90,2 +88,3 @@ import { managePosition } from './utils/manage-position.js';
   toggle() {
+    // eslint-disable-next-line no-unused-expressions
     this.isShown ? this.hide() : this.show();
@@ -92,0 +91,0 @@ }

src/OverlaysManager.js

@@ -1,2 +0,2 @@
-/* eslint-disable no-underscore-dangle, class-methods-use-this */
+/* eslint-disable class-methods-use-this */
 
@@ -3,0 +3,0 @@ /**

stories/global-overlay.stories.js

@@ -1,3 +0,2 @@
-/* eslint-disable no-underscore-dangle, class-methods-use-this */
-import { storiesOf, html } from '@open-wc/storybook';
+import { storiesOf, html } from '@open-wc/demoing-storybook';
 
@@ -29,3 +28,3 @@ import { css } from '@lion/core';
 
-storiesOf('Overlay System|Global/Global Overlay', module)
+storiesOf('Global Overlay System|Global Overlay', module)
   .add('Default', () => {
@@ -32,0 +31,0 @@ const overlayCtrl = overlays.add(

stories/local-overlay-placement.stories.js

@@ -1,2 +0,2 @@
-import { storiesOf, html, action } from '@open-wc/storybook';
+import { storiesOf, html } from '@open-wc/demoing-storybook';
 import { css } from '@lion/core';
@@ -33,3 +33,3 @@ import { managePosition } from '../src/utils/manage-position.js';
 
-storiesOf('Overlay System|Local/Local Overlay Placement', module)
+storiesOf('Local Overlay System|Local Overlay Placement', module)
   .addParameters({ options: { selectedPanel: 'storybook/actions/actions-panel' } })
@@ -72,3 +72,2 @@ .add('Preferred placement overlay absolute', () => {
       }
-      action('position: ')(placement);
       managePosition(element, target, { placement, position: 'absolute' });
@@ -128,3 +127,2 @@ };
       }
-      action('position: ')(placement);
       managePosition(element, target, { placement, position: 'absolute' });
@@ -131,0 +129,0 @@ };

stories/local-overlay.stories.js

@@ -1,2 +0,2 @@
-import { storiesOf, html } from '@open-wc/storybook';
+import { storiesOf, html } from '@open-wc/demoing-storybook';
 import { css } from '@lion/core';
@@ -29,3 +29,3 @@ import { overlays } from '../src/overlays.js';
 
-storiesOf('Overlay System|Local/Local Overlay', module)
+storiesOf('Local Overlay System|Local Overlay', module)
   .add('Basic', () => {
@@ -32,0 +32,0 @@ const popup = overlays.add(

stories/modal-dialog.stories.js

@@ -1,3 +0,2 @@
-/* eslint-disable no-underscore-dangle, class-methods-use-this */
-import { storiesOf, html } from '@open-wc/storybook';
+import { storiesOf, html } from '@open-wc/demoing-storybook';
 
@@ -23,3 +22,3 @@ import { css } from '@lion/core';
 
-storiesOf('Overlay System|Global/Modal Dialog', module)
+storiesOf('Global Overlay System|Modal Dialog', module)
   .add('Default', () => {
@@ -26,0 +25,0 @@ const dialogCtrl = overlays.add(

test/GlobalOverlayController.test.js

@@ -1,4 +0,1 @@
-/* eslint-env mocha */
-/* eslint-disable no-underscore-dangle, no-unused-expressions */
-
 import { expect, fixture, html } from '@open-wc/testing';
@@ -5,0 +2,0 @@ import { keyUpOn } from '@polymer/iron-test-helpers/mock-interactions.js';

test/LocalOverlayController.test.js

@@ -1,4 +0,1 @@
-/* eslint-env mocha */
-/* eslint-disable no-underscore-dangle, no-unused-expressions */
-
 import { expect, fixture, html, aTimeout, defineCE, unsafeStatic } from '@open-wc/testing';
@@ -84,3 +81,2 @@
         class extends LionLitElement {
-          // eslint-disable-next-line class-methods-use-this
           render() {
@@ -87,0 +83,0 @@ return html`

test/ModalDialogController.test.js

@@ -1,3 +0,1 @@
-/* eslint-env mocha */
-
 import { expect } from '@open-wc/testing';
@@ -4,0 +2,0 @@

test/OverlaysManager.test.js

@@ -1,2 +0,1 @@
-/* eslint-disable no-unused-expressions, no-underscore-dangle */
 import { expect } from '@open-wc/testing';
@@ -3,0 +2,0 @@ import sinon from 'sinon';

test/utils-tests/active-element.test.js

@@ -1,3 +0,1 @@
-/* eslint-env mocha */
-/* eslint-disable no-underscore-dangle, no-unused-expressions, class-methods-use-this */
 import { expect, fixture, defineCE } from '@open-wc/testing';
@@ -4,0 +2,0 @@ import { LitElement, html } from '@lion/core';

test/utils-tests/contain-focus.test.js

@@ -1,3 +0,1 @@
-/* eslint-env mocha */
-/* eslint-disable no-underscore-dangle, no-unused-expressions */
 import { expect, fixture } from '@open-wc/testing';
@@ -4,0 +2,0 @@

test/utils-tests/get-focusable-elements.test.js

@@ -1,3 +0,1 @@
-/* eslint-env mocha */
-/* eslint-disable no-underscore-dangle, no-unused-expressions, class-methods-use-this */
 import { expect, fixture, defineCE } from '@open-wc/testing';
@@ -4,0 +2,0 @@ import { LitElement, html } from '@lion/core';

test/utils-tests/get-position.test.js

@@ -1,3 +0,1 @@
-/* eslint-env mocha */
-/* eslint-disable no-unused-expressions, no-underscore-dangle */
 import { expect } from '@open-wc/testing';
@@ -4,0 +2,0 @@

test/utils-tests/manage-position.test.js

@@ -1,3 +0,1 @@
-/* eslint-env mocha */
-/* eslint-disable no-unused-expressions, no-underscore-dangle */
 import { expect } from '@open-wc/testing';
@@ -4,0 +2,0 @@ import sinon from 'sinon';

test/utils-tests/visibility.test.js

@@ -1,3 +0,1 @@
-/* eslint-env mocha */
-/* eslint-disable no-underscore-dangle, no-unused-expressions */
 import { expect, fixture } from '@open-wc/testing';
@@ -4,0 +2,0 @@

No alert changes

Worsened metrics

Total package byte prevSize

158187

decreased by-0.53%

Lines of code

4600

decreased by-0.48%

Dependency changes

• Updated@lion/core@^0.1.3