@lion/overlays - npm Package Compare versions

Comparing version 0.16.8 to 0.16.9

CHANGELOG.md

@@ -6,2 +6,13 @@ # Change Log
 
+## [0.16.9](https://github.com/ing-bank/lion/compare/@lion/overlays@0.16.8...@lion/overlays@0.16.9) (2020-07-09)
+
+
+### Bug Fixes
+
+* **overlays:** add protected show and hide complete hooks,fix flaky test ([53a5426](https://github.com/ing-bank/lion/commit/53a54261e97a529867a6f56971471d6f6de5347c))
+
+
+
+
+
 ## [0.16.8](https://github.com/ing-bank/lion/compare/@lion/overlays@0.16.7...@lion/overlays@0.16.8) (2020-07-07)
@@ -8,0 +19,0 @@

package.json

 {
   "name": "@lion/overlays",
-  "version": "0.16.8",
+  "version": "0.16.9",
   "description": "Overlays System using lit-html for rendering",
@@ -46,3 +46,3 @@ "license": "MIT",
   },
-  "gitHead": "c2b77664921d08b9e1e83e97967296c125dd5f0e"
+  "gitHead": "3ef736bacfe2086517eeb441682f735ba1769b2a"
 }

src/OverlayController.js

@@ -422,2 +422,6 @@ import '@lion/core/src/differentKeyEventNamesShimIE.js';
   async show(elementToFocusAfterHide = this.elementToFocusAfterHide) {
+    this._showComplete = new Promise(resolve => {
+      this._showResolve = resolve;
+    });
+
     if (this.manager) {
@@ -428,2 +432,3 @@ this.manager.show(this);
     if (this.isShown) {
+      this._showResolve();
       return;
@@ -443,2 +448,3 @@ }
     }
+    this._showResolve();
   }
@@ -516,2 +522,6 @@
   async hide() {
+    this._hideComplete = new Promise(resolve => {
+      this._hideResolve = resolve;
+    });
+
     if (this.manager) {
@@ -522,2 +532,3 @@ this.manager.hide(this);
     if (!this.isShown) {
+      this._hideResolve();
       return;
@@ -536,2 +547,3 @@ }
     }
+    this._hideResolve();
   }
@@ -538,0 +550,0 @@

test-suites/OverlayMixin.suite.js

@@ -32,14 +32,11 @@ import { expect, fixture, html, nextFrame, aTimeout } from '@open-wc/testing';
       el.opened = true;
+      await el.updateComplete;
+      await el._overlayCtrl._showComplete;
       expect(el.opened).to.be.true;
-      await el.updateComplete;
-      if (el.repositionComplete) {
-        await el.repositionComplete;
-      }
-      await nextFrame(); // overlayCtrl show/hide is async
       expect(el._overlayCtrl.isShown).to.be.true;
 
       el.opened = false;
+      await el.updateComplete;
+      await el._overlayCtrl._hideComplete;
       expect(el.opened).to.be.false;
-      await el.updateComplete;
-      await nextFrame(); // overlayCtrl show/hide is async
       expect(el._overlayCtrl.isShown).to.be.false;
@@ -46,0 +43,0 @@ });

No alert changes

Improved metrics

Total package byte prevSize

242132

increased by0.2%

Lines of code

4453

increased by0.16%

No dependency changes