@lion/popup - npm Package Compare versions

Comparing version 0.3.12 to 0.3.13

CHANGELOG.md

@@ -6,2 +6,13 @@ # Change Log
 
+## [0.3.13](https://github.com/ing-bank/lion/compare/@lion/popup@0.3.12...@lion/popup@0.3.13) (2019-11-15)
+
+
+### Bug Fixes
+
+* refactor slot selection ([5999ea9](https://github.com/ing-bank/lion/commit/5999ea956967b449f3f04935c7facb19e2889dc9))
+
+
+
+
+
 ## [0.3.12](https://github.com/ing-bank/lion/compare/@lion/popup@0.3.11...@lion/popup@0.3.12) (2019-11-13)
@@ -8,0 +19,0 @@

package.json

 {
   "name": "@lion/popup",
-  "version": "0.3.12",
+  "version": "0.3.13",
   "description": "Show relative overlay content on click",
@@ -36,6 +36,6 @@ "author": "ing-bank",
     "@lion/core": "^0.3.0",
-    "@lion/overlays": "^0.6.3"
+    "@lion/overlays": "^0.6.4"
   },
   "devDependencies": {
-    "@lion/button": "^0.3.35",
+    "@lion/button": "^0.3.36",
     "@lion/icon": "^0.2.9",
@@ -45,3 +45,3 @@ "@open-wc/demoing-storybook": "^0.2.0",
   },
-  "gitHead": "90e6b4ef36bb5c49cfe7e4b2b8a00128334c84ab"
+  "gitHead": "e1485188a03c063819623288f3231cfecca023ec"
 }

src/LionPopup.js

@@ -12,8 +12,10 @@ import { LitElement, html } from '@lion/core';
 
+  // FIXME: This should be refactored to Array.from(this.children).find(child => child.slot === 'content')
+  // When this issue is fixed https://github.com/ing-bank/lion/issues/382
   get _overlayContentNode() {
-    return this.querySelector('[slot=content]');
+    return this.querySelector('[slot="content"]');
   }
 
   get _overlayInvokerNode() {
-    return this.querySelector('[slot=invoker]');
+    return Array.from(this.children).find(child => child.slot === 'invoker');
   }
@@ -20,0 +22,0 @@

test/lion-popup.test.js

@@ -24,3 +24,3 @@ import { expect, fixture, html } from '@open-wc/testing';
       `);
-      const invoker = el.querySelector('[slot="invoker"]');
+      const invoker = Array.from(el.children).find(child => child.slot === 'invoker');
       invoker.click();
@@ -42,3 +42,3 @@ await el.updateComplete;
       `);
-      const invoker = el.querySelector('[slot="invoker"]');
+      const invoker = Array.from(el.children).find(child => child.slot === 'invoker');
       const event = new Event('click');
@@ -45,0 +45,0 @@ invoker.dispatchEvent(event);

No alert changes

Improved metrics

Total package byte prevSize

27272

increased by1.92%

Lines of code

218

increased by0.93%

Dependency changes

• Updated@lion/overlays@^0.6.4