@lion/tooltip - npm Package Compare versions

Comparing version 0.8.8 to 0.8.9

CHANGELOG.md

@@ -6,2 +6,13 @@ # Change Log
 
+## [0.8.9](https://github.com/ing-bank/lion/compare/@lion/tooltip@0.8.8...@lion/tooltip@0.8.9) (2020-04-02)
+
+
+### Bug Fixes
+
+* **tooltip:** support reconnecting tooltip arrow inside other overlays ([78a8554](https://github.com/ing-bank/lion/commit/78a8554019de6c91cae7c0d8e3fd2caa3c2209d1))
+
+
+
+
+
 ## [0.8.8](https://github.com/ing-bank/lion/compare/@lion/tooltip@0.8.7...@lion/tooltip@0.8.8) (2020-03-26)
@@ -8,0 +19,0 @@

package.json

 {
   "name": "@lion/tooltip",
-  "version": "0.8.8",
+  "version": "0.8.9",
   "description": "Show relative overlay content on hover",
@@ -37,10 +37,6 @@ "author": "ing-bank",
   "dependencies": {
-    "@lion/core": "0.5.0",
-    "@lion/overlays": "0.12.8"
+    "@lion/core": "0.5.1",
+    "@lion/overlays": "0.12.9"
   },
-  "devDependencies": {
-    "@open-wc/demoing-storybook": "^1.10.4",
-    "@open-wc/testing": "^2.5.0"
-  },
-  "gitHead": "04df0d70541c23efd38da3dba5b9f98b714da0f2"
+  "gitHead": "b58aa65377d5e7a0cd4d87917980291c832e7120"
 }

src/LionTooltip.js

@@ -15,10 +15,7 @@ import { html, LitElement } from '@lion/core';
     this._overlayContentNode.setAttribute('role', 'tooltip');
+    // Schedule setting up the arrow element so that it works both on firstUpdated
+    // and when the tooltip is moved in the DOM (disconnected + reconnected)
+    this.updateComplete.then(() => this.__setupArrowElement());
   }
 
-  firstUpdated(...args) {
-    super.firstUpdated(...args);
-
-    this.__setupArrowElement();
-  }
-
   render() {
@@ -34,3 +31,3 @@ return html`
   __setupArrowElement() {
-    this.__arrowElement = this.querySelector('[slot=arrow]');
+    this.__arrowElement = Array.from(this.children).find(child => child.slot === 'arrow');
     if (!this.__arrowElement) {
@@ -37,0 +34,0 @@ return;

No alert changes

Improved metrics

Total package byte prevSize

52661

increased by0.68%

Dev dependency count

0

decreased by-100%

Worsened metrics

Lines of code

434

decreased by-0.23%

Dependency changes

• + Added@lion/core@0.5.1(transitive)

• + Added@lion/overlays@0.12.9(transitive)

• - Removed@lion/core@0.5.0(transitive)

• - Removed@lion/overlays@0.12.8(transitive)

• Updated@lion/core@0.5.1

• Updated@lion/overlays@0.12.9