@naturalcycles/js-lib - npm Package Compare versions

Comparing version 2.2.1 to 2.2.2

CHANGELOG.md

@@ -0,1 +1,8 @@
+## [2.2.2](https://github.com/NaturalCycles/js-lib/compare/v2.2.1...v2.2.2) (2019-02-22)
+
+
+### Bug Fixes
+
+* err instanceof AppError, err instanceof Error ([19022ef](https://github.com/NaturalCycles/js-lib/commit/19022ef))
+
 ## [2.2.1](https://github.com/NaturalCycles/js-lib/compare/v2.2.0...v2.2.1) (2019-02-22)
@@ -2,0 +9,0 @@

dist-esm/error/app.error.js

@@ -7,2 +7,4 @@ /**
  * data.userMessage - if present, will be displayed to the User as is.
+ *
+ * Based on: https://medium.com/@xpl/javascript-deriving-from-error-properly-8d2f8f315801
  */
@@ -13,5 +15,6 @@ export class AppError extends Error {
         this.data = data;
+        this.constructor = AppError;
+        this.__proto__ = AppError.prototype;
         Object.defineProperty(this, 'name', {
-            // value: this.constructor.name,
-            value: 'AppError',
+            value: this.constructor.name,
             configurable: true,
@@ -18,0 +21,0 @@ });

dist-esm/error/http.error.js

@@ -8,5 +8,6 @@ import { AppError } from './app.error';
         super(message, Object.assign({ httpStatusCode: 500 }, data));
+        this.constructor = HttpError;
+        this.__proto__ = HttpError.prototype;
         Object.defineProperty(this, 'name', {
-            // value: this.constructor.name,
-            value: 'HttpError',
+            value: this.constructor.name,
             configurable: true,
@@ -13,0 +14,0 @@ });

dist/error/app.error.d.ts

@@ -8,2 +8,4 @@ import { ErrorData } from './error.model';
  * data.userMessage - if present, will be displayed to the User as is.
+ *
+ * Based on: https://medium.com/@xpl/javascript-deriving-from-error-properly-8d2f8f315801
  */
@@ -10,0 +12,0 @@ export declare class AppError<DATA_TYPE extends ErrorData = ErrorData> extends Error {

dist/error/app.error.js

@@ -9,2 +9,4 @@ "use strict";
  * data.userMessage - if present, will be displayed to the User as is.
+ *
+ * Based on: https://medium.com/@xpl/javascript-deriving-from-error-properly-8d2f8f315801
  */
@@ -15,5 +17,6 @@ class AppError extends Error {
         this.data = data;
+        this.constructor = AppError;
+        this.__proto__ = AppError.prototype;
         Object.defineProperty(this, 'name', {
-            // value: this.constructor.name,
-            value: 'AppError',
+            value: this.constructor.name,
             configurable: true,
@@ -20,0 +23,0 @@ });

dist/error/http.error.js

@@ -10,5 +10,6 @@ "use strict";
         super(message, Object.assign({ httpStatusCode: 500 }, data));
+        this.constructor = HttpError;
+        this.__proto__ = HttpError.prototype;
         Object.defineProperty(this, 'name', {
-            // value: this.constructor.name,
-            value: 'HttpError',
+            value: this.constructor.name,
             configurable: true,
@@ -15,0 +16,0 @@ });

package.json

 {
   "name": "@naturalcycles/js-lib",
-  "version": "2.2.1",
+  "version": "2.2.2",
   "scripts": {
@@ -5,0 +5,0 @@ "build": "del ./dist && tsc",

src/error/app.error.ts

@@ -9,2 +9,4 @@ import { ErrorData } from './error.model'
  * data.userMessage - if present, will be displayed to the User as is.
+ *
+ * Based on: https://medium.com/@xpl/javascript-deriving-from-error-properly-8d2f8f315801
  */
@@ -15,5 +17,6 @@ export class AppError<DATA_TYPE extends ErrorData = ErrorData> extends Error {
 
+    this.constructor = AppError
+    ;(this as any).__proto__ = AppError.prototype
     Object.defineProperty(this, 'name', {
-      // value: this.constructor.name,
-      value: 'AppError',
+      value: this.constructor.name,
       configurable: true,
@@ -20,0 +23,0 @@ })

src/error/http.error.ts

@@ -14,5 +14,6 @@ import { AppError } from './app.error'
 
+    this.constructor = HttpError
+    ;(this as any).__proto__ = HttpError.prototype
     Object.defineProperty(this, 'name', {
-      // value: this.constructor.name,
-      value: 'HttpError',
+      value: this.constructor.name,
       configurable: true, // otherwise throws with "TypeError: Cannot redefine property: name"
@@ -19,0 +20,0 @@ })

No alert changes

Improved metrics

Total package byte prevSize

104105

increased by1.22%

Lines of code

1850

increased by0.76%

No dependency changes