@naturalcycles/nodejs-lib - npm Package Compare versions

Comparing version 13.23.1 to 13.24.0

dist/validation/joi/string.extensions.js

@@ -44,10 +44,10 @@ "use strict";
                     if (max === 'today') {
-                        max = (0, js_lib_1.localTimeNow)().plus(14, 'hour').toISODate();
+                        max = getTodayStrPlus15();
                     }
                     if (min === 'today') {
-                        min = (0, js_lib_1.localTimeNow)().minus(14, 'hour').toISODate();
+                        min = getTodayStrMinus15();
                     }
                     // console.log('min/max', min, max)
-                    const m = /^(\d{4})-(\d{2})-(\d{2})$/.exec(v);
-                    if (!m || m.length <= 1) {
+                    const parts = /^(\d{4})-(\d{2})-(\d{2})$/.exec(v);
+                    if (!parts || parts.length < 4) {
                         err = 'string.dateString';
@@ -61,4 +61,3 @@ }
                     }
-                    else if (!js_lib_1.LocalDate.isValid(v)) {
-                        // todo: replace with another regex (from ajv-validators) for speed
+                    else if (!isValidDate(parts)) {
                         err = 'string.dateStringCalendarAccuracy';
@@ -76,1 +75,37 @@ }
 exports.stringExtensions = stringExtensions;
+const DAYS = [0, 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31];
+// Based on: https://github.com/ajv-validator
+function isValidDate(parts) {
+    const year = Number(parts[1]);
+    const month = Number(parts[2]);
+    const day = Number(parts[3]);
+    return (month >= 1 &&
+        month <= 12 &&
+        day >= 1 &&
+        day <= (month === 2 && isLeapYear(year) ? 29 : DAYS[month]));
+}
+function isLeapYear(year) {
+    return year % 4 === 0 && (year % 100 !== 0 || year % 400 === 0);
+}
+let lastCheckedPlus = 0;
+let todayStrPlusCached;
+let lastCheckedMinus = 0;
+let todayStrMinusCached;
+function getTodayStrPlus15() {
+    const now = Date.now();
+    if (now - lastCheckedPlus < 3_600_000) {
+        // cached for 1 hour
+        return todayStrPlusCached;
+    }
+    lastCheckedPlus = now;
+    return (todayStrPlusCached = (0, js_lib_1.localTimeNow)().plus(15, 'hour').toISODate());
+}
+function getTodayStrMinus15() {
+    const now = Date.now();
+    if (now - lastCheckedMinus < 3_600_000) {
+        // cached for 1 hour
+        return todayStrMinusCached;
+    }
+    lastCheckedMinus = now;
+    return (todayStrMinusCached = (0, js_lib_1.localTimeNow)().plus(-15, 'hour').toISODate());
+}

package.json

 {
   "name": "@naturalcycles/nodejs-lib",
-  "version": "13.23.1",
+  "version": "13.24.0",
   "scripts": {
@@ -5,0 +5,0 @@ "prepare": "husky",

src/validation/joi/string.extensions.ts

@@ -1,2 +0,2 @@
-import { LocalDate, localTimeNow } from '@naturalcycles/js-lib'
+import { localTimeNow } from '@naturalcycles/js-lib'
 import Joi, { Extension, StringSchema as JoiStringSchema } from 'joi'
@@ -54,11 +54,11 @@
           if (max === 'today') {
-            max = localTimeNow().plus(14, 'hour').toISODate()
+            max = getTodayStrPlus15()
           }
           if (min === 'today') {
-            min = localTimeNow().minus(14, 'hour').toISODate()
+            min = getTodayStrMinus15()
           }
           // console.log('min/max', min, max)
 
-          const m = /^(\d{4})-(\d{2})-(\d{2})$/.exec(v)
-          if (!m || m.length <= 1) {
+          const parts = /^(\d{4})-(\d{2})-(\d{2})$/.exec(v)
+          if (!parts || parts.length < 4) {
             err = 'string.dateString'
@@ -69,4 +69,3 @@ } else if (min && v < min) {
             err = 'string.dateStringMax'
-          } else if (!LocalDate.isValid(v)) {
-            // todo: replace with another regex (from ajv-validators) for speed
+          } else if (!isValidDate(parts)) {
             err = 'string.dateStringCalendarAccuracy'
@@ -85,1 +84,46 @@ }
 }
+
+const DAYS = [0, 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31]
+// Based on: https://github.com/ajv-validator
+function isValidDate(parts: string[]): boolean {
+  const year = Number(parts[1])
+  const month = Number(parts[2])
+  const day = Number(parts[3])
+  return (
+    month >= 1 &&
+    month <= 12 &&
+    day >= 1 &&
+    day <= (month === 2 && isLeapYear(year) ? 29 : DAYS[month]!)
+  )
+}
+
+function isLeapYear(year: number): boolean {
+  return year % 4 === 0 && (year % 100 !== 0 || year % 400 === 0)
+}
+
+let lastCheckedPlus = 0
+let todayStrPlusCached: string
+let lastCheckedMinus = 0
+let todayStrMinusCached: string
+
+function getTodayStrPlus15(): string {
+  const now = Date.now()
+  if (now - lastCheckedPlus < 3_600_000) {
+    // cached for 1 hour
+    return todayStrPlusCached
+  }
+
+  lastCheckedPlus = now
+  return (todayStrPlusCached = localTimeNow().plus(15, 'hour').toISODate())
+}
+
+function getTodayStrMinus15(): string {
+  const now = Date.now()
+  if (now - lastCheckedMinus < 3_600_000) {
+    // cached for 1 hour
+    return todayStrMinusCached
+  }
+
+  lastCheckedMinus = now
+  return (todayStrMinusCached = localTimeNow().plus(-15, 'hour').toISODate())
+}

No alert changes

Improved metrics

Total package byte prevSize

466916

increased by0.44%

Lines of code

13312

increased by0.54%

No dependency changes