@nteract/commutable - npm Package Compare versions

Comparing version 7.4.5 to 7.4.6

__tests__/v4.spec.ts

@@ -7,3 +7,4 @@ import Immutable, { Record } from "immutable";
   makeExecuteResult,
-  makeStreamOutput
+  makeStreamOutput,
+  OnDiskStreamOutput
 } from "../src/outputs";
@@ -60,2 +61,9 @@ import {
   });
+
+  it("stream output does not reformat multiline string", () => {
+    const text = "line1\r\nline2\rline3\nline4\n\n\r\n\r\r\n";
+    const streamOutput = makeStreamOutput().set("text", text)
+    const outputJS = outputToJS(streamOutput) as OnDiskStreamOutput;
+    expect(outputJS.text).toEqual(text);
+  });
 });
@@ -62,0 +70,0 @@

lib/v4.js

@@ -140,3 +140,6 @@ "use strict";
                 name: output.name,
-                text: primitives_1.remultiline(output.text)
+                // Note: similar to createOnDiskMediaBundle, steam output could be very big e.g. stdout dumps a large chunk of text
+                //       calling remultiline on that will cause performance issue.
+                // TODO: figure out a configurable way to reformat the string when needed.
+                text: output.text
             };
@@ -143,0 +146,0 @@ case "error":

package.json

 {
   "name": "@nteract/commutable",
-  "version": "7.4.5",
+  "version": "7.4.6",
   "description": "library for immutable notebook operations",
@@ -103,4 +103,3 @@ "main": "lib/index.js",
     ]
-  },
-  "gitHead": "53c6d0ec6038dfc1124345c0385e10cff43a18c5"
+  }
 }

src/v4.ts

@@ -235,3 +235,6 @@ // Due to the on-disk format needing to be written out in an explicit order,
         name: output.name,
-        text: remultiline(output.text)
+        // Note: similar to createOnDiskMediaBundle, steam output could be very big e.g. stdout dumps a large chunk of text
+        //       calling remultiline on that will cause performance issue.
+        // TODO: figure out a configurable way to reformat the string when needed.
+        text: output.text
       };
@@ -238,0 +241,0 @@ case "error":

No alert changes

Improved metrics

Lines of code

3285

increased by0.4%

Worsened metrics

Total package byte prevSize

705966

decreased by-0.09%

Number of package files

45

decreased by-2.17%

No dependency changes