@observertc/observer-js - npm Package Compare versions

Comparing version 0.42.3 to 0.42.4

lib/monitors/CallSummaryMonitor.js

@@ -92,3 +92,4 @@ "use strict";
             clientSummary.left = now;
-            clientSummary.issues.push(...client.issues);
+            // client does not store issues after update emitted
+            // clientSummary.issues.push(...client.issues);
             client.off('update', updateClient);
@@ -95,0 +96,0 @@ client.off('usingturn', onUsingTurn);

lib/ObservedClient.d.ts

@@ -134,3 +134,3 @@ /// <reference types="node" />
     readonly userMediaErrors: string[];
-    readonly issues: ClientIssue[];
+    issues: ClientIssue[];
     ωpendingPeerConnectionTimestamps: PendingPeerConnectionTimestamp[];
@@ -137,0 +137,0 @@ ωpendingMediaTrackTimestamps: PendingMediaTrackTimestamp[];

lib/ObservedClient.js

@@ -199,2 +199,6 @@ "use strict";
         ++this._acceptedSamples;
+        if (0 < this.issues.length) {
+            // we reset the issues every time we accept a new sample
+            this.issues = [];
+        }
         for (const peerConnection of this._peerConnections.values()) {
@@ -201,0 +205,0 @@ if (peerConnection.closed)

package.json

 {
   "name": "@observertc/observer-js",
-  "version": "0.42.3",
+  "version": "0.42.4",
   "description": "Server Side NodeJS Library for processing ObserveRTC Samples",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

src/monitors/CallSummaryMonitor.ts

@@ -124,3 +124,4 @@ import { EventEmitter } from 'events';
 			clientSummary.left = now;
-			clientSummary.issues.push(...client.issues);
+			// client does not store issues after update emitted
+			// clientSummary.issues.push(...client.issues);
 
@@ -127,0 +128,0 @@ client.off('update', updateClient);

src/ObservedClient.ts

@@ -140,3 +140,3 @@ import { Browser, ClientSample, Engine, IceLocalCandidate, IceRemoteCandidate, MediaCodecStats, MediaDevice, OperationSystem, Platform } from '@observertc/sample-schemas-js';
 	public readonly userMediaErrors: string[] = [];
-	public readonly issues: ClientIssue[] = [];
+	public issues: ClientIssue[] = [];
 
@@ -328,3 +328,6 @@ public ωpendingPeerConnectionTimestamps: PendingPeerConnectionTimestamp[] = [];
 		++this._acceptedSamples;
-		
+		if (0 < this.issues.length) {
+			// we reset the issues every time we accept a new sample
+			this.issues = [];
+		}
 		for (const peerConnection of this._peerConnections.values()) {
@@ -331,0 +334,0 @@ if (peerConnection.closed) continue;

No alert changes

Improved metrics

Total package byte prevSize

577121

increased by0.06%

Lines of code

12161

increased by0.08%

No dependency changes