@observertc/observer-js - npm Package Compare versions

Comparing version 0.42.7 to 0.42.8

lib/common/CalculatedScore.js

@@ -63,3 +63,3 @@ "use strict";
     if (bpp / 2 < bppRange.low) {
-        score.score = 1.0;
+        score.score = 0.5;
         score.remarks.push({
@@ -71,3 +71,3 @@ severity: 'major',
     else if (bppRange.low < bpp) {
-        score.score = 1.0;
+        score.score = 0.8;
         score.remarks.push({
@@ -79,3 +79,3 @@ severity: 'minor',
     else {
-        score.score = Math.min(3.0, 2.0 + ((bpp - bppRange.low) / (bppRange.high - bppRange.low)));
+        score.score = Math.min(1.0, ((bpp - bppRange.low) / (bppRange.high - bppRange.low)));
         score.remarks.push({
@@ -112,3 +112,3 @@ severity: 'none',
     if (track.bitrate < 8000) {
-        score.score = 1.0;
+        score.score = 0.2;
         score.remarks.push({
@@ -120,3 +120,3 @@ severity: 'none',
     else if (track.bitrate < 16000) {
-        score.score = 2.8;
+        score.score = 0.5;
         score.remarks.push({
@@ -128,3 +128,3 @@ severity: 'none',
     else {
-        score.score = 3.0;
+        score.score = 1.0;
         score.remarks.push({
@@ -131,0 +131,0 @@ severity: 'none',

lib/ObservedClient.js

@@ -696,2 +696,3 @@ "use strict";
         let maxPcScore;
+        let numberOfScoredPeerConnections = 0;
         for (const peerConnection of this._peerConnections.values()) {
@@ -719,2 +720,3 @@ if (peerConnection.closed)
                     maxPcScore = peerConnection.score.score;
+                ++numberOfScoredPeerConnections;
             }
@@ -726,3 +728,3 @@ }
                     severity: 'none',
-                    text: `Min and max score of all peer connections: ${minPcScore}, ${maxPcScore}`,
+                    text: `Min and max score of all peer connections: ${minPcScore}, ${maxPcScore}, number of PeerConnections with scores: ${numberOfScoredPeerConnections}`,
                 }],
@@ -729,0 +731,0 @@ timestamp: sample.timestamp,

package.json

 {
   "name": "@observertc/observer-js",
-  "version": "0.42.7",
+  "version": "0.42.8",
   "description": "Server Side NodeJS Library for processing ObserveRTC Samples",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

src/common/CalculatedScore.ts

@@ -88,3 +88,3 @@ import { ClientIssue } from '../monitors/CallSummary';
 	if (bpp / 2 < bppRange.low) {
-		score.score = 1.0;
+		score.score = 0.5;
 		score.remarks.push({
@@ -95,3 +95,3 @@ severity: 'major',
 	} else if (bppRange.low < bpp) {
-		score.score = 1.0;
+		score.score = 0.8;
 		score.remarks.push({
@@ -102,3 +102,3 @@ severity: 'minor',
 	} else {
-		score.score = Math.min(3.0, 2.0 + ((bpp - bppRange.low) / (bppRange.high - bppRange.low)));
+		score.score = Math.min(1.0, ((bpp - bppRange.low) / (bppRange.high - bppRange.low)));
 		score.remarks.push({
@@ -135,3 +135,3 @@ severity: 'none',
 	if (track.bitrate < 8000) {
-		score.score = 1.0;
+		score.score = 0.2;
 		score.remarks.push({
@@ -142,3 +142,3 @@ severity: 'none',
 	} else if (track.bitrate < 16000) {
-		score.score = 2.8;
+		score.score = 0.5;
 		score.remarks.push({
@@ -149,3 +149,3 @@ severity: 'none',
 	} else {
-		score.score = 3.0;
+		score.score = 1.0;
 		score.remarks.push({
@@ -152,0 +152,0 @@ severity: 'none',

src/ObservedClient.ts

@@ -1049,2 +1049,3 @@ import { Browser, ClientSample, Engine, IceLocalCandidate, IceRemoteCandidate, MediaCodecStats, MediaDevice, OperationSystem, Platform } from '@observertc/sample-schemas-js';
 		let maxPcScore: number | undefined;
+		let numberOfScoredPeerConnections = 0;
 
@@ -1074,2 +1075,4 @@ for (const peerConnection of this._peerConnections.values()) {
 				if (maxPcScore === undefined || peerConnection.score.score > maxPcScore) maxPcScore = peerConnection.score.score;
+
+				++numberOfScoredPeerConnections;
 			}
@@ -1082,3 +1085,3 @@ }
 				severity: 'none',
-				text: `Min and max score of all peer connections: ${minPcScore}, ${maxPcScore}`,
+				text: `Min and max score of all peer connections: ${minPcScore}, ${maxPcScore}, number of PeerConnections with scores: ${numberOfScoredPeerConnections}`,
 			} ],
@@ -1085,0 +1088,0 @@ timestamp: sample.timestamp,

No alert changes

Improved metrics

Total package byte prevSize

579707

increased by0.05%

Lines of code

12264

increased by0.03%

No dependency changes