@openui5/sap.ui.codeeditor - npm Package Compare versions

Comparing version 1.54.6 to 1.56.0

LICENSE.txt

@@ -401,3 +401,3 @@
 Licensor: jQuery Foundation and other contributors
-Website: https://github.com/jquery/qunit-reporter-junit
+Website: https://github.com/JamesMGreene/qunit-reporter-junit
 License: MIT License
@@ -487,3 +487,3 @@
 
-Component: Sinon.JS 4.1.3
+Component: Sinon.JS 4.4.6
 Licensor: Christian Johansen
@@ -562,3 +562,3 @@ Website: http://github.com/cjohansen/Sinon.JS/
 
-Component: URI.js 1.11.2
+Component: URI.js 1.19.1
 Licensor: Rodney Rehm
@@ -591,3 +591,10 @@ Website: http://github.com/medialize/URI.js/
 
+Component: bignumber.js 6.0.0
+Licensor: Michael Mclaughlin
+Website: https://github.com/MikeMcl/bignumber.js/
+License: MIT License
+<year> = 2018
+<copyright holders> = Michael Mclaughlin
 
+
 --------------------------------------------------------------------------------------------------------------------------
@@ -594,0 +601,0 @@

package.json

 {
   "name": "@openui5/sap.ui.codeeditor",
-  "version": "1.54.6",
+  "version": "1.56.0",
   "description": "OpenUI5 UI Library sap.ui.codeeditor",
@@ -17,4 +17,4 @@ "author": "SAP SE (https://www.sap.com)",
   "dependencies": {
-    "@openui5/sap.ui.core": "1.54.6"
+    "@openui5/sap.ui.core": "1.56.0"
   }
 }

src/sap/ui/codeeditor/CodeEditor.js

@@ -11,3 +11,3 @@ /*!
 	'jquery.sap.global',
-	"sap/ui/core/Control",
+	'sap/ui/core/Control',
 	'sap/ui/codeeditor/js/ace/ace',
@@ -37,3 +37,3 @@ 'sap/ui/codeeditor/js/ace/ext-language_tools',
 	 * @author SAP SE
-	 * @version 1.54.6
+	 * @version 1.56.0
 	 *
@@ -191,5 +191,12 @@ * @constructor
 
-		this._oEditor.getSession().setValue("");
-		this._oEditor.getSession().setUseWrapMode(true);
-		this._oEditor.getSession().setMode("ace/mode/javascript");
+		var oSession = this._oEditor.getSession();
+
+		// Ensure worker is used only when the CodeEditor has focus.
+		// This helps preventing race conditions between the framework's
+		// lifecycle and the Ace editor's lifecycle.
+		oSession.setUseWorker(false);
+
+		oSession.setValue("");
+		oSession.setUseWrapMode(true);
+		oSession.setMode("ace/mode/javascript");
 		this._oEditor.setTheme("ace/theme/tomorrow");
@@ -257,3 +264,5 @@
 		}
-		this._oEditor.setReadOnly(!this.getEditable());
+
+		// This is required for BCP:1880235178
+		this._oEditor.textInput.setReadOnly(!bValue);
 		return this;
@@ -269,2 +278,3 @@ };
 		this._oEditor.focus();
+
 		return this;
@@ -449,3 +459,14 @@ };
 
+	CodeEditor.prototype.onfocusout = function () {
+		this._oEditor.getSession().setUseWorker(false);
+	};
+
+	CodeEditor.prototype.onfocusin = function () {
+		if (!this.getEditable()) {
+			document.activeElement.blur(); // prevent virtual keyboard from opening when control is not editable
+		}
+		this._oEditor.getSession().setUseWorker(true);
+	};
+
 	return CodeEditor;
 }, /* bExport= */true);

src/sap/ui/codeeditor/library.js

@@ -36,3 +36,3 @@ /*!
 		noLibraryCSS: false,
-		version: "1.54.6"
+		version: "1.56.0"
 	});
@@ -39,0 +39,0 @@

No alert changes

Improved metrics

Total package byte prevSize

12211036

increased by0.01%

Number of package files

373

increased by0.27%

Lines of code

259712

increased by0.01%

Dependency changes

• + Added@openui5/sap.ui.core@1.56.0(transitive)

• - Removed@openui5/sap.ui.core@1.54.6(transitive)

• Updated@openui5/sap.ui.core@1.56.0