@pwabuilder/pwainstall - npm Package Compare versions

Comparing version 1.2.5 to 1.2.6

package.json

 {
   "name": "@pwabuilder/pwainstall",
-  "version": "1.2.5",
+  "version": "1.2.6",
   "description": "",
@@ -5,0 +5,0 @@ "main": "dist/pwa-install.js",

src/pwa-install.ts

@@ -52,2 +52,3 @@ import {
       right: 0;
+      z-index: var(--modal-z-index);
      }
@@ -288,3 +289,3 @@
       width: 24em;
-      height: 14em;
+      height: 13.7em;
 
@@ -291,0 +292,0 @@ -webkit-overflow-scrolling: touch

test/basic/basic.test.js

@@ -37,10 +37,8 @@ import { expect, elementUpdated, html, fixture } from '@open-wc/testing';
 
-it('shouldShowInstall should return undefined if no manifest data', async () => {
+it('shouldShowInstall should return false if no manifest data', async () => {
   const el = await fixture('<pwa-install></pwa-install>');
   await el.getManifestData();
 
-  expect(el.manifestdata).to.be.undefined;
-
   const testResult = el.shouldShowInstall();
-  expect(testResult).to.be.undefined;
+  expect(testResult).to.be.false;
 });
@@ -66,3 +64,3 @@
 
-it('shouldShowInstall should return undefined', async () => {
+it('shouldShowInstall should return false', async () => {
   const el = await fixture('<pwa-install></pwa-install>');
@@ -73,8 +71,6 @@
 
-  expect(testResult).to.be.undefined;
+  expect(testResult).to.be.false;
 });
 
-// will be undefined in the test environment as there is no manifest / sw
-// we never want to show the install button if the app cant be installed
-it('shouldShowInstall should still return undefined even if showopen is true', async () => {
+it('shouldShowInstall should still return false even if showopen is true', async () => {
   const el = await fixture('<pwa-install showopen></pwa-install>');
@@ -85,9 +81,6 @@
 
-  expect(testResult).to.be.undefined;
+  expect(testResult).to.be.false;
 });
 
-// will be undefined in the test environment as there is no manifest / sw
-// we never want to show the install button if the app cant be installed
-it('shouldShowInstall should return undefined even if showeligible is on', async () => {
-  // this should be undefined because install is eligible in this case
+it('shouldShowInstall should return false even if showeligible is on', async () => {
   const el = await fixture('<pwa-install showeligible></pwa-install>');
@@ -98,7 +91,5 @@
 
-  expect(testResult).to.be.undefined;
+  expect(testResult).to.be.false;
 });
 
-
-
 it('deferredPrompt should be undefined if not in install eligible env', async () => {
@@ -105,0 +96,0 @@ const el = await fixture('<pwa-install></pwa-install>');

No alert changes

Improved metrics

Total package byte prevSize

777842

increased by0.69%

Worsened metrics

Lines of code

2333

decreased by-0.21%

No dependency changes