@salesforcedevs/docs-components - npm Package Compare versions

Comparing version 0.15.0 to 0.16.2

package.json

 {
     "name": "@salesforcedevs/docs-components",
-    "version": "0.15.0",
+    "version": "0.16.2",
     "description": "Docs Lightning web components for DSC",
@@ -17,3 +17,3 @@ "license": "MIT",
     },
-    "gitHead": "e5ccea7a857ee11117727b9bfabb544e8b0e6922"
+    "gitHead": "4695c8e7dc16a958beb7717cfe01e432c57f5872"
 }

src/modules/doc/header/__tests__/header.test.ts

@@ -107,3 +107,3 @@ import Button from "dx/button";
 
-            expect(headerEl.querySelector("dx-feedback-banner")).not.toBeNull();
+            expect(headerEl.querySelector("dx-banner")).not.toBeNull();
 
@@ -311,2 +311,25 @@ const logo = element.shadowRoot.querySelector("dx-logo");
         });
+
+        it("hides signup button when signupLink property is empty", () => {
+            const updatedMockPropsDevelopers = {
+                ...mockPropsDevelopers,
+                signupLink:""
+            };
+            const element = render(updatedMockPropsDevelopers);
+            const signupButtonContainer: HTMLElement =
+                element.shadowRoot.querySelector(".header-login-signup");
+            expect(signupButtonContainer).toBeNull();
+        });
+
+        it("hides banner when banner markup is empty", () => {
+            const bannerMarkup = "";
+            const updatedMockPropsDevelopers = {
+                ...mockPropsDevelopers,
+                bannerMarkup
+            };
+            const element = render(updatedMockPropsDevelopers);
+            const bannerElement: HTMLElement =
+                element.shadowRoot.querySelector("dx-banner");
+            expect(bannerElement).toBeNull();
+        });
     });
@@ -313,0 +336,0 @@

src/modules/doc/header/__tests__/mockProps.ts

@@ -35,2 +35,5 @@ import {
     languages,
+    signupLink: "/sign-up",
+    bannerMarkup:
+        '<span><a href="https://forms.gle/TdSyKFPHXoBx7seM9" target="blank">Share your feedback</a>about our new site.</span>',
     ...coveoConfig
@@ -37,0 +40,0 @@ };

src/modules/doc/header/header.stories.ts

@@ -104,2 +104,4 @@ import { html } from "lit-html";
         onclick="headerClick(event)"
+        signup-link="${mockProps.signupLink}"
+        banner-markup="${mockProps.bannerMarkup}"
     ></doc-header>`;
@@ -162,1 +164,29 @@
     headerStoryGenerator(mockPropsAnalytics, "analytics", args);
+
+export const AnalyticsWithoutSignup = (args: any) =>
+    headerStoryGenerator(
+        { ...mockPropsAnalytics, signupLink:"" },
+        "analytics",
+        args
+    );
+
+export const AnalyticsWithCustomBannerText = (args: any) =>
+    headerStoryGenerator(
+        {
+            ...mockPropsMarketing,
+            bannerMarkup:
+                'Salesforce Subscription Management API ("the API") is available as a developer preview. The API is not generally available unless or until Salesforce announces its general availability in documentation or in press releases or public statements. All components of the API including request names, parameters, objects, and fields are subject to change or deprecation at any time, with or without notice. Do not use the API with real data or in a production environment.'
+        },
+        "analytics",
+        args
+    );
+
+export const AnalyticsWithoutBanner = (args: any) =>
+    headerStoryGenerator(
+        {
+            ...mockPropsMarketing,
+            bannerMarkup: ""
+        },
+        "analytics",
+        args
+    );

src/modules/doc/header/header.ts

@@ -66,3 +66,5 @@ import { api } from "lwc";
     private get showSignup(): boolean {
-        return (this.tablet && !this.isSearchOpen) || !this.tablet;
+        return this.signupLink
+            ? (this.tablet && !this.isSearchOpen) || !this.tablet
+            : false;
     }
@@ -69,0 +71,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

173492

increased by1.4%

Lines of code

4420

increased by1.24%

No dependency changes