@secretlint/node - npm Package Compare versions

Comparing version 0.7.0 to 0.7.3

CHANGELOG.md

@@ -6,2 +6,13 @@ # Change Log
 
+## [0.7.3](https://github.com/secretlint/secretlint/compare/v0.7.2...v0.7.3) (2020-03-01)
+
+
+### Bug Fixes
+
+* **node:** add concurrency limit to lint ([b966a3a](https://github.com/secretlint/secretlint/commit/b966a3ad39fc5188c46c23e625c0c022adcb2f55)), closes [#72](https://github.com/secretlint/secretlint/issues/72)
+
+
+
+
+
 # [0.7.0](https://github.com/secretlint/secretlint/compare/v0.6.0...v0.7.0) (2020-03-01)
@@ -8,0 +19,0 @@

lib/index.js

@@ -19,4 +19,6 @@ "use strict";
 const formatter_1 = require("@secretlint/formatter");
+const os_1 = __importDefault(require("os"));
 const path_1 = __importDefault(require("path"));
 const profiler_1 = require("@secretlint/profiler");
+const p_map_1 = __importDefault(require("p-map"));
 const debug = require("debug")("@secretlint/node");
@@ -58,7 +60,14 @@ const lintFile = (filePath, options) => __awaiter(void 0, void 0, void 0, function* () {
     var _c, _d;
-    const resultPromises = filePathList.map(filePath => {
-        return lintFile(filePath, config);
+    const mapper = (filePath) => __awaiter(void 0, void 0, void 0, function* () {
+        debug("executeOnFiles > execute file: %s", filePath);
+        const result = yield lintFile(filePath, config);
+        debug("executeOnFiles > execute result: %o", result);
+        return result;
     });
-    const results = yield Promise.all(resultPromises);
-    debug("executeOnFiles results: %O", results);
+    const results = yield p_map_1.default(filePathList, mapper, {
+        // Avoid: EMFILE: too many open files, uv_cwd
+        // https://github.com/secretlint/secretlint/issues/72
+        concurrency: os_1.default.cpus().length
+    });
+    debug("executeOnFiles result counts: %s", results.length);
     profiler_1.secretLintProfiler.mark({
@@ -133,3 +142,3 @@ type: "@node>format::start"
         executeOnFiles: ({ filePathList }) => {
-            debug("executeOnFiles filePathLList: %O", filePathList);
+            debug("executeOnFiles file counts: %s", filePathList.length);
             profiler_1.secretLintProfiler.mark({
@@ -136,0 +145,0 @@ type: "@node>execute::start"

package.json

 {
   "name": "@secretlint/node",
-  "version": "0.7.0",
+  "version": "0.7.3",
   "description": "Secretlint client library for Node.js",
@@ -49,3 +49,4 @@ "keywords": [
     "@secretlint/source-creator": "^0.7.0",
-    "debug": "^4.1.1"
+    "debug": "^4.1.1",
+    "p-map": "^3.0.0"
   },
@@ -67,3 +68,3 @@ "devDependencies": {
   },
-  "gitHead": "b29781cbb16259b05547b66b5a728f56c9ad9698"
+  "gitHead": "a6fd6ad0fa330862e37019bfd6586bd29f53be62"
 }

src/index.ts

@@ -6,4 +6,6 @@ import { lintSource } from "@secretlint/core";
 import { SecretLintCoreDescriptor, SecretLintCoreResult } from "@secretlint/types";
+import os from "os";
 import path from "path";
 import { secretLintProfiler } from "@secretlint/profiler";
+import pMap from "p-map";
 
@@ -93,7 +95,14 @@ const debug = require("debug")("@secretlint/node");
 }) => {
-    const resultPromises = filePathList.map(filePath => {
-        return lintFile(filePath, config);
+    const mapper = async (filePath: string) => {
+        debug("executeOnFiles > execute file: %s", filePath);
+        const result = await lintFile(filePath, config);
+        debug("executeOnFiles > execute result: %o", result);
+        return result;
+    };
+    const results = await pMap(filePathList, mapper, {
+        // Avoid: EMFILE: too many open files, uv_cwd
+        // https://github.com/secretlint/secretlint/issues/72
+        concurrency: os.cpus().length
     });
-    const results = await Promise.all(resultPromises);
-    debug("executeOnFiles results: %O", results);
+    debug("executeOnFiles result counts: %s", results.length);
     secretLintProfiler.mark({
@@ -169,3 +178,3 @@ type: "@node>format::start"
         executeOnFiles: ({ filePathList }: { filePathList: string[] }) => {
-            debug("executeOnFiles filePathLList: %O", filePathList);
+            debug("executeOnFiles file counts: %s", filePathList.length);
             secretLintProfiler.mark({
@@ -172,0 +181,0 @@ type: "@node>execute::start"

No alert changes

Improved metrics

Total package byte prevSize

25286

increased by6.04%

Lines of code

395

increased by4.77%

Worsened metrics

Dependency count

7

increased by16.67%

Dependency changes

• + Addedp-map@^3.0.0

• + Addedaggregate-error@3.1.0(transitive)

• + Addedclean-stack@2.2.0(transitive)

• + Addedindent-string@4.0.0(transitive)

• + Addedp-map@3.0.0(transitive)