@sewing-kit/core - npm Package Compare versions

Comparing version 0.2.1 to 0.3.0

build/cjs/workspace.js

@@ -13,6 +13,2 @@ "use strict";
 class Workspace extends _index.Base {
-  get private() {
-    return this.webApps.length > 0 || this.services.length > 0;
-  }
-
   get projects() {
@@ -19,0 +15,0 @@ return [...this.packages, ...this.webApps, ...this.services];

build/ts/workspace.d.ts

@@ -14,3 +14,2 @@ import { Base, Options as BaseOptions } from './base';
     readonly services: readonly Service[];
-    get private(): boolean;
     get projects(): (import("./package").Package | import("./web-app").WebApp | import("./service").Service)[];
@@ -17,0 +16,0 @@ constructor({ webApps, packages, services, ...rest }: WorkspaceOptions);

build/ts/workspace.js

@@ -24,5 +24,2 @@ "use strict";
     }
-    get private() {
-        return this.webApps.length > 0 || this.services.length > 0;
-    }
     get projects() {
@@ -29,0 +26,0 @@ return [...this.packages, ...this.webApps, ...this.services];

CHANGELOG.md

@@ -10,2 +10,6 @@ # Changelog
 
+## [0.3.0] - 2021-04-14
+
+- Remove `private` getter on the `Workspace` class [[#139](https://github.com/Shopify/sewing-kit-next/pull/139)]
+
 ## [0.2.1] - 2021-04-06
@@ -12,0 +16,0 @@

package.json

 {
   "name": "@sewing-kit/core",
   "license": "MIT",
-  "version": "0.2.1",
+  "version": "0.3.0",
   "sideEffects": false,
@@ -19,3 +19,3 @@ "publishConfig": {
   },
-  "gitHead": "88b2abd0de97863b14edd4cc29c5c97aa977e778"
+  "gitHead": "96bbda25e7461b4a484cfafdd79abde2e39dc12e"
 }

src/tests/workspace.test.ts

@@ -18,3 +18,2 @@ import {ProjectKind} from '..';
     expect(webAppWorkspace.projects[0].kind).toBe(ProjectKind.WebApp);
-    expect(webAppWorkspace.private).toBe(true);
   });
@@ -25,3 +24,2 @@
     expect(packageWorkspace.projects[0].kind).toBe(ProjectKind.Package);
-    expect(packageWorkspace.private).toBe(false);
   });
@@ -32,3 +30,2 @@
     expect(serviceWorkspace.projects[0].kind).toBe(ProjectKind.Service);
-    expect(serviceWorkspace.private).toBe(true);
   });
@@ -35,0 +32,0 @@

src/workspace.ts

@@ -18,6 +18,2 @@ import {Base, Options as BaseOptions} from './base';
 
-  get private() {
-    return this.webApps.length > 0 || this.services.length > 0;
-  }
-
   get projects() {
@@ -24,0 +20,0 @@ return [...this.packages, ...this.webApps, ...this.services];

No alert changes

Worsened metrics

Total package byte prevSize

445907

decreased by-0.07%

Lines of code

2489

decreased by-0.52%

No dependency changes