@types/doubleclick-gpt - npm Package Compare versions

Comparing version 238.0.1 to 238.0.2

doubleclick-gpt/index.d.ts

@@ -5,2 +5,3 @@ // Type definitions for non-npm package Google Publisher Tag 238.0
 //                 Steven Joyce <https://github.com/steven-joyce>
+//                 Joe Flateau <https://github.com/joeflateau>
 // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
@@ -30,5 +31,13 @@ // TypeScript Version: 2.2
         addEventListener(
+          eventType: "slotRenderEnded",
+            listener: (event: events.SlotRenderEndedEvent) => void
+        ): Service;
+        addEventListener(
+          eventType: "slotVisibilityChanged",
+            listener: (event: events.SlotVisibilityChangedEvent) => void
+        ): Service;
+        addEventListener(
           eventType: string,
-            listener: (event: events.ImpressionViewableEvent | events.SlotOnloadEvent | events.SlotRenderEndedEvent | events.slotVisibilityChangedEvent) => void
-        ): void;
+            listener: (event: events.Event) => void
+        ): Service;
         getSlots(): Slot[];
@@ -160,3 +169,3 @@ }
     namespace events {
-        interface ImpressionViewableEvent {
+        interface Event {
             serviceName: string;
@@ -166,8 +175,9 @@ slot: Slot;
 
-        interface SlotOnloadEvent {
-            serviceName: string;
-            slot: Slot;
-        }
+        // tslint:disable-next-line:no-empty-interface
+        interface ImpressionViewableEvent extends Event {}
 
-        interface SlotRenderEndedEvent {
+        // tslint:disable-next-line:no-empty-interface
+        interface SlotOnloadEvent extends Event {}
+
+        interface SlotRenderEndedEvent extends Event {
             advertiserId?: number;
@@ -177,5 +187,3 @@ creativeId?: number;
             lineItemId?: number;
-            serviceName: string;
             size: number[] | string;
-            slot: Slot;
             sourceAgnosticCreativeId?: number;
@@ -185,6 +193,4 @@ sourceAgnosticLineItemId?: number;
 
-        interface slotVisibilityChangedEvent {
+        interface SlotVisibilityChangedEvent extends Event {
             inViewPercentage: number;
-            serviceName: string;
-            slot: Slot;
         }
@@ -191,0 +197,0 @@ }

doubleclick-gpt/package.json

 {
     "name": "@types/doubleclick-gpt",
-    "version": "238.0.1",
-    "description": "TypeScript definitions for non-npm package Google Publisher Tag",
+    "version": "238.0.2",
+    "description": "TypeScript definitions for Google Publisher Tag",
     "license": "MIT",
@@ -16,2 +16,7 @@ "contributors": [
             "githubUsername": "steven-joyce"
+        },
+        {
+            "name": "Joe Flateau",
+            "url": "https://github.com/joeflateau",
+            "githubUsername": "joeflateau"
         }
@@ -23,8 +28,9 @@ ],
         "type": "git",
-        "url": "https://github.com/DefinitelyTyped/DefinitelyTyped.git"
+        "url": "https://github.com/DefinitelyTyped/DefinitelyTyped.git",
+        "directory": "types/doubleclick-gpt"
     },
     "scripts": {},
     "dependencies": {},
-    "typesPublisherContentHash": "6c586a2317c521d331ecbb00f3a21e1f026319be8843b21b7494b8b518977e4d",
+    "typesPublisherContentHash": "c83380220f847fa46dc83c6bd982e32b40f9e090a3508514cb1959e666313c1c",
     "typeScriptVersion": "2.2"
 }

doubleclick-gpt/README.md

@@ -5,3 +5,3 @@ # Installation
 # Summary
-This package contains type definitions for non-npm package Google Publisher Tag ( https://developers.google.com/doubleclick-gpt/reference ).
+This package contains type definitions for Google Publisher Tag ( https://developers.google.com/doubleclick-gpt/reference ).
 
@@ -12,3 +12,3 @@ # Details
 Additional Details
- * Last updated: Thu, 14 Feb 2019 16:51:50 GMT
+ * Last updated: Wed, 10 Apr 2019 17:55:57 GMT
  * Dependencies: none
@@ -18,2 +18,2 @@ * Global values: googletag
 # Credits
-These definitions were written by John Wright <https://github.com/johngeorgewright>, Steven Joyce <https://github.com/steven-joyce>.
+These definitions were written by John Wright <https://github.com/johngeorgewright>, Steven Joyce <https://github.com/steven-joyce>, Joe Flateau <https://github.com/joeflateau>.

No alert changes

Improved metrics

Total package byte prevSize

10207

increased by5.14%

Lines of code

169

increased by3.05%

No dependency changes