@vaadin/combo-box - npm Package Compare versions

Comparing version 23.0.0-beta1 to 23.0.0-beta2

package.json

 {
   "name": "@vaadin/combo-box",
-  "version": "23.0.0-beta1",
+  "version": "23.0.0-beta2",
   "publishConfig": {
@@ -37,21 +37,21 @@ "access": "public"
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/component-base": "23.0.0-beta1",
-    "@vaadin/field-base": "23.0.0-beta1",
-    "@vaadin/input-container": "23.0.0-beta1",
-    "@vaadin/item": "23.0.0-beta1",
-    "@vaadin/vaadin-lumo-styles": "23.0.0-beta1",
-    "@vaadin/vaadin-material-styles": "23.0.0-beta1",
-    "@vaadin/vaadin-overlay": "23.0.0-beta1",
-    "@vaadin/vaadin-themable-mixin": "23.0.0-beta1"
+    "@vaadin/component-base": "23.0.0-beta2",
+    "@vaadin/field-base": "23.0.0-beta2",
+    "@vaadin/input-container": "23.0.0-beta2",
+    "@vaadin/item": "23.0.0-beta2",
+    "@vaadin/vaadin-lumo-styles": "23.0.0-beta2",
+    "@vaadin/vaadin-material-styles": "23.0.0-beta2",
+    "@vaadin/vaadin-overlay": "23.0.0-beta2",
+    "@vaadin/vaadin-themable-mixin": "23.0.0-beta2"
   },
   "devDependencies": {
     "@esm-bundle/chai": "^4.3.4",
-    "@vaadin/dialog": "23.0.0-beta1",
-    "@vaadin/polymer-legacy-adapter": "23.0.0-beta1",
+    "@vaadin/dialog": "23.0.0-beta2",
+    "@vaadin/polymer-legacy-adapter": "23.0.0-beta2",
     "@vaadin/testing-helpers": "^0.3.2",
-    "@vaadin/text-field": "23.0.0-beta1",
+    "@vaadin/text-field": "23.0.0-beta2",
     "lit": "^2.0.0",
     "sinon": "^9.2.0"
   },
-  "gitHead": "467244b76021176c109df675799b07029b293e58"
+  "gitHead": "a276f7a0fd00e5459b87267468e0dd0d4fb6f7f3"
 }

src/vaadin-combo-box-mixin.js

@@ -426,2 +426,12 @@ /**
 
+    /**
+     * @param {Event} event
+     * @protected
+     */
+    _onHostClick(_event) {
+      if (!this.autoOpenDisabled) {
+        this.open();
+      }
+    }
+
     /** @private */
@@ -441,4 +451,4 @@ _onClick(e) {
         }
-      } else if (!this.autoOpenDisabled) {
-        this.open();
+      } else {
+        this._onHostClick(e);
       }
@@ -445,0 +455,0 @@

src/vaadin-combo-box.js

@@ -186,4 +186,4 @@ /**
           <slot name="input"></slot>
-          <div id="clearButton" part="clear-button" slot="suffix"></div>
-          <div id="toggleButton" part="toggle-button" slot="suffix"></div>
+          <div id="clearButton" part="clear-button" slot="suffix" aria-hidden="true"></div>
+          <div id="toggleButton" part="toggle-button" slot="suffix" aria-hidden="true"></div>
         </vaadin-input-container>
@@ -297,2 +297,15 @@
   }
+
+  /**
+   * @param {Event} event
+   * @protected
+   */
+  _onHostClick(event) {
+    const path = event.composedPath();
+
+    // Open dropdown only when clicking on the label or input field
+    if (path.includes(this._labelNode) || path.includes(this._positionTarget)) {
+      super._onHostClick(event);
+    }
+  }
 }
@@ -299,0 +312,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

132559

increased by0.37%

Lines of code

3367

increased by0.6%

Dependency changes

• + Added@vaadin/component-base@23.0.0-beta2(transitive)

• + Added@vaadin/field-base@23.0.0-beta2(transitive)

• + Added@vaadin/icon@23.0.0-beta2(transitive)

• + Added@vaadin/input-container@23.0.0-beta2(transitive)

• + Added@vaadin/item@23.0.0-beta2(transitive)

• + Added@vaadin/vaadin-lumo-styles@23.0.0-beta2(transitive)

• + Added@vaadin/vaadin-material-styles@23.0.0-beta2(transitive)

• + Added@vaadin/vaadin-overlay@23.0.0-beta2(transitive)

• + Added@vaadin/vaadin-themable-mixin@23.0.0-beta2(transitive)

• - Removed@vaadin/component-base@23.0.0-beta1(transitive)

• - Removed@vaadin/field-base@23.0.0-beta1(transitive)

• - Removed@vaadin/icon@23.0.0-beta1(transitive)

• - Removed@vaadin/input-container@23.0.0-beta1(transitive)

• - Removed@vaadin/item@23.0.0-beta1(transitive)

• - Removed@vaadin/vaadin-lumo-styles@23.0.0-beta1(transitive)

• - Removed@vaadin/vaadin-material-styles@23.0.0-beta1(transitive)

• - Removed@vaadin/vaadin-overlay@23.0.0-beta1(transitive)

• - Removed@vaadin/vaadin-themable-mixin@23.0.0-beta1(transitive)

• Updated@vaadin/component-base@23.0.0-beta2

• Updated@vaadin/field-base@23.0.0-beta2

• Updated@vaadin/input-container@23.0.0-beta2

• Updated@vaadin/item@23.0.0-beta2

• Updated@vaadin/vaadin-lumo-styles@23.0.0-beta2

• Updated@vaadin/vaadin-material-styles@23.0.0-beta2

• Updated@vaadin/vaadin-overlay@23.0.0-beta2

• Updated@vaadin/vaadin-themable-mixin@23.0.0-beta2