@vaadin/menu-bar - npm Package Compare versions

Comparing version 23.0.4 to 23.1.0-alpha1

package.json

 {
   "name": "@vaadin/menu-bar",
-  "version": "23.0.4",
+  "version": "23.1.0-alpha1",
   "publishConfig": {
@@ -38,16 +38,16 @@ "access": "public"
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/button": "^23.0.4",
-    "@vaadin/component-base": "^23.0.4",
-    "@vaadin/vaadin-context-menu": "^23.0.4",
-    "@vaadin/vaadin-lumo-styles": "^23.0.4",
-    "@vaadin/vaadin-material-styles": "^23.0.4",
-    "@vaadin/vaadin-themable-mixin": "^23.0.4"
+    "@vaadin/button": "23.1.0-alpha1",
+    "@vaadin/component-base": "23.1.0-alpha1",
+    "@vaadin/vaadin-context-menu": "23.1.0-alpha1",
+    "@vaadin/vaadin-lumo-styles": "23.1.0-alpha1",
+    "@vaadin/vaadin-material-styles": "23.1.0-alpha1",
+    "@vaadin/vaadin-themable-mixin": "23.1.0-alpha1"
   },
   "devDependencies": {
     "@esm-bundle/chai": "^4.3.4",
-    "@vaadin/icon": "^23.0.4",
+    "@vaadin/icon": "23.1.0-alpha1",
     "@vaadin/testing-helpers": "^0.3.2",
     "sinon": "^9.2.1"
   },
-  "gitHead": "d8db2046661c42fb5aac09ed683b500bf4613b26"
+  "gitHead": "5d0cdee069f866037c507265fafb4d0476795333"
 }

src/vaadin-menu-bar-buttons-mixin.js

@@ -200,25 +200,2 @@ /**
 
-    /**
-     * @param {string | null} theme
-     * @protected
-     * @override
-     */
-    _setTheme(theme) {
-      super._setTheme(theme);
-
-      // Initializing, do nothing
-      if (!this.shadowRoot) {
-        return;
-      }
-
-      this.__applyTheme(theme);
-    }
-
-    /** @private */
-    __applyTheme(theme) {
-      this._buttons.forEach((btn) => this._setButtonTheme(btn, theme));
-
-      this.__detectOverflow();
-    }
-
     /** @protected */
@@ -281,5 +258,6 @@ _setButtonTheme(btn, hostTheme) {
         this._initButtonAttrs(button);
+        this._setButtonTheme(button, this._theme);
       });
 
-      this.__applyTheme(this.theme);
+      this.__detectOverflow();
     }
@@ -286,0 +264,0 @@

src/vaadin-menu-bar-interactions-mixin.js

@@ -30,3 +30,3 @@ /**
     static get observers() {
-      return ['_itemsChanged(items, items.splices)', '_themeChanged(theme)'];
+      return ['_itemsChanged(items, items.splices)'];
     }
@@ -58,11 +58,2 @@
 
-    /** @private */
-    _themeChanged(theme) {
-      if (theme) {
-        this._subMenu.setAttribute('theme', theme);
-      } else {
-        this._subMenu.removeAttribute('theme');
-      }
-    }
-
     /** @protected */
@@ -69,0 +60,0 @@ _setExpanded(button, expanded) {

src/vaadin-menu-bar.d.ts

@@ -138,2 +138,8 @@ /**
 
+  /**
+   * A callback for the `_theme` property observer.
+   * It propagates the host theme to the buttons and the sub menu.
+   */
+  protected _themeChanged(theme: string | null): void;
+
   addEventListener<K extends keyof MenuBarEventMap>(
@@ -140,0 +146,0 @@ type: K,

src/vaadin-menu-bar.js

@@ -204,2 +204,6 @@ /**
 
+  static get observers() {
+    return ['_themeChanged(_theme)'];
+  }
+
   /**
@@ -222,2 +226,22 @@ * Override method inherited from `DisabledMixin`
 
+  /**
+   * A callback for the `_theme` property observer.
+   * It propagates the host theme to the buttons and the sub menu.
+   *
+   * @param {string | null} theme
+   * @protected
+   */
+  _themeChanged(theme) {
+    if (this.shadowRoot) {
+      this._buttons.forEach((btn) => this._setButtonTheme(btn, theme));
+      this.__detectOverflow();
+    }
+
+    if (theme) {
+      this._subMenu.setAttribute('theme', theme);
+    } else {
+      this._subMenu.removeAttribute('theme');
+    }
+  }
+
   /** @private */
@@ -224,0 +248,0 @@ __updateButtonsDisabled(disabled) {

New alerts

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

59100

increased by0.32%

Lines of code

1352

increased by0.07%

Worsened metrics

Number of low quality alerts

1

increased byInfinity%

Dependency changes

• + Added@vaadin/button@23.1.0-alpha1(transitive)

• + Added@vaadin/component-base@23.1.0-alpha1(transitive)

• + Added@vaadin/context-menu@23.1.0-alpha1(transitive)

• + Added@vaadin/icon@23.1.0-alpha1(transitive)

• + Added@vaadin/item@23.1.0-alpha1(transitive)

• + Added@vaadin/list-box@23.1.0-alpha1(transitive)

• + Added@vaadin/vaadin-context-menu@23.1.0-alpha1(transitive)

• + Added@vaadin/vaadin-list-mixin@23.1.0-alpha1(transitive)

• + Added@vaadin/vaadin-lumo-styles@23.1.0-alpha1(transitive)

• + Added@vaadin/vaadin-material-styles@23.1.0-alpha1(transitive)

• + Added@vaadin/vaadin-overlay@23.1.0-alpha1(transitive)

• + Added@vaadin/vaadin-themable-mixin@23.1.0-alpha1(transitive)

• - Removed@vaadin/button@23.5.12(transitive)

• - Removed@vaadin/component-base@23.5.12(transitive)

• - Removed@vaadin/context-menu@23.5.12(transitive)

• - Removed@vaadin/icon@23.5.12(transitive)

• - Removed@vaadin/item@23.5.12(transitive)

• - Removed@vaadin/list-box@23.5.12(transitive)

• - Removed@vaadin/lit-renderer@23.5.12(transitive)

• - Removed@vaadin/overlay@23.5.12(transitive)

• - Removed@vaadin/vaadin-context-menu@23.5.12(transitive)

• - Removed@vaadin/vaadin-list-mixin@23.5.12(transitive)

• - Removed@vaadin/vaadin-lumo-styles@23.5.12(transitive)

• - Removed@vaadin/vaadin-material-styles@23.5.12(transitive)

• - Removed@vaadin/vaadin-themable-mixin@23.5.12(transitive)

• Updated@vaadin/button@23.1.0-alpha1

• Updated@vaadin/component-base@23.1.0-alpha1

• Updated@vaadin/vaadin-context-menu@23.1.0-alpha1

• Updated@vaadin/vaadin-lumo-styles@23.1.0-alpha1

• Updated@vaadin/vaadin-material-styles@23.1.0-alpha1

• Updated@vaadin/vaadin-themable-mixin@23.1.0-alpha1