@vaadin/vaadin-menu-bar - npm Package Compare versions

Comparing version 1.1.0 to 1.2.0-alpha1

package.json

@@ -13,3 +13,3 @@ {
   "name": "@vaadin/vaadin-menu-bar",
-  "version": "1.1.0",
+  "version": "1.2.0-alpha1",
   "main": "vaadin-menu-bar.js",
@@ -22,3 +22,5 @@ "author": "Vaadin Ltd",
   "files": [
+    "vaadin-*.d.ts",
     "vaadin-*.js",
+    "@types",
     "src",
@@ -28,4 +30,3 @@ "theme"
   "resolutions": {
-"@webcomponents/webcomponentsjs": "2.2.0",
-"@webcomponents/webcomponentsjs": "2.2.0",
+    "@webcomponents/webcomponentsjs": "2.2.0",
     "inherits": "2.0.3",
@@ -39,6 +40,6 @@ "samsam": "1.1.3",
     "@polymer/iron-resizable-behavior": "^3.0.0",
-    "@vaadin/vaadin-themable-mixin": "^1.5.0",
-    "@vaadin/vaadin-element-mixin": "^2.3.0",
-    "@vaadin/vaadin-button": "^2.3.0",
-    "@vaadin/vaadin-context-menu": "^4.4.0",
+    "@vaadin/vaadin-themable-mixin": "^1.6.1",
+    "@vaadin/vaadin-element-mixin": "^2.4.1",
+    "@vaadin/vaadin-button": "^2.4.0-alpha1",
+    "@vaadin/vaadin-context-menu": "^4.5.0-alpha1",
     "@vaadin/vaadin-lumo-styles": "^1.6.0",
@@ -48,8 +49,5 @@ "@vaadin/vaadin-material-styles": "^1.3.2"
   "scripts": {
-  "generate-typings": "gen-typescript-declarations --outDir . --verify"
-},
-"scripts": {
-  "generate-typings": "gen-typescript-declarations --outDir . --verify"
-},
-"devDependencies": {
+    "generate-typings": "gen-typescript-declarations --outDir . --verify"
+  },
+  "devDependencies": {
     "@polymer/iron-component-page": "^4.0.0",
@@ -59,3 +57,3 @@ "@polymer/iron-test-helpers": "^3.0.0",
     "wct-browser-legacy": "^1.0.1",
-    "@vaadin/vaadin-checkbox": "^2.3.0",
+    "@vaadin/vaadin-checkbox": "^2.4.0-alpha1",
     "@vaadin/vaadin-icons": "^4.3.1",
@@ -62,0 +60,0 @@ "@vaadin/vaadin-demo-helpers": "^3.1.0-alpha1"

src/vaadin-menu-bar-buttons-mixin.js

@@ -19,2 +19,6 @@ /**
     return {
+      /**
+       * @type {boolean}
+       * @protected
+       */
       _hasOverflow: {
@@ -33,2 +37,3 @@ type: Boolean,
 
+  /** @protected */
   ready() {
@@ -46,2 +51,6 @@ super.ready();
 
+  /**
+   * @return {!Array<!HTMLElement>}
+   * @protected
+   */
   get _buttons() {
@@ -51,2 +60,6 @@ return Array.from(this.shadowRoot.querySelectorAll('[part$="button"]'));
 
+  /**
+   * @return {!HTMLElement}
+   * @protected
+   */
   get _container() {
@@ -56,2 +69,6 @@ return this.shadowRoot.querySelector('[part="container"]');
 
+  /**
+   * @return {!HTMLElement}
+   * @protected
+   */
   get _overflow() {
@@ -61,2 +78,3 @@ return this.shadowRoot.querySelector('[part="overflow-button"]');
 
+  /** @private */
   _menuItemsChanged(items, splices) {
@@ -69,2 +87,3 @@ if (items !== this._oldItems) {
 
+  /** @private */
   __detectOverflow() {
@@ -160,2 +179,3 @@ const container = this._container;
 
+  /** @private */
   __renderButtons(items = []) {
@@ -218,2 +238,3 @@ const container = this._container;
 
+  /** @private */
   __onResize() {
@@ -220,0 +241,0 @@ this.__debounceOverflow = Debouncer.debounce(

src/vaadin-menu-bar-interactions-mixin.js

@@ -34,2 +34,3 @@ /**
 
+  /** @protected */
   ready() {
@@ -53,5 +54,3 @@ super.ready();
 
-  /**
-   * @protected
-   */
+  /** @protected */
   connectedCallback() {
@@ -62,5 +61,3 @@ super.connectedCallback();
 
-  /**
-   * @protected
-   */
+  /** @protected */
   disconnectedCallback() {
@@ -71,2 +68,13 @@ super.disconnectedCallback();
 
+  /**
+   * Can be called to manually notify a resizable and its descendant
+   * resizables of a resize change.
+   */
+  notifyResize() {
+    // NOTE: we have this method here to include it to TypeScript definitions.
+    // gen-typescript-declarations does not generate types for `mixinBehaviors`
+    super.notifyResize();
+  }
+
+  /** @private */
   get __isRTL() {
@@ -76,2 +84,3 @@ return this.getAttribute('dir') === 'rtl';
 
+  /** @private */
   _themeChanged(theme) {
@@ -87,2 +96,3 @@ if (theme) {
 
+  /** @private */
   _focusButton(button) {
@@ -96,2 +106,3 @@ button.focus();
 
+  /** @private */
   _getButtonFromEvent(e) {
@@ -101,2 +112,6 @@ return Array.from(e.composedPath()).filter(el => el.localName === 'vaadin-menu-bar-button')[0];
 
+  /**
+   * @param {!FocusEvent} event
+   * @protected
+   */
   _onFocusin(event) {
@@ -111,2 +126,6 @@ const target = this.shadowRoot.querySelector('[part$="button"][tabindex="0"]');
 
+  /**
+   * @param {!KeyboardEvent} event
+   * @protected
+   */
   _onKeydown(event) {
@@ -141,2 +160,3 @@ const button = this._getButtonFromEvent(event);
 
+  /** @private */
   _navigateByKey(event) {
@@ -188,2 +208,3 @@ // IE names for arrows do not include the Arrow prefix
 
+  /** @private */
   _getAvailableIndex(index, increment, buttons) {
@@ -207,2 +228,3 @@ const totalItems = buttons.length;
 
+  /** @private */
   get _subMenu() {
@@ -212,2 +234,3 @@ return this.shadowRoot.querySelector('vaadin-menu-bar-submenu');
 
+  /** @private */
   __alignOverlayPosition(e) {
@@ -236,2 +259,3 @@ /* istanbul ignore if */
 
+  /** @private */
   _itemsChanged(items, splices) {
@@ -244,2 +268,6 @@ const subMenu = this._subMenu;
 
+  /**
+   * @param {!MouseEvent} e
+   * @protected
+   */
   _onMouseOver(e) {
@@ -257,2 +285,3 @@ const button = this._getButtonFromEvent(e);
 
+  /** @private */
   __onContextMenuKeydown(e) {
@@ -278,2 +307,3 @@ const item = Array.from(e.composedPath()).filter(el => el._item)[0];
 
+  /** @private */
   __fireItemSelected(value) {
@@ -283,2 +313,3 @@ this.dispatchEvent(new CustomEvent('item-selected', {detail: {value}}));
 
+  /** @private */
   __onButtonClick(e) {
@@ -292,2 +323,3 @@ e.stopPropagation();
 
+  /** @private */
   __openSubMenu(button, event, options = {}) {
@@ -345,2 +377,3 @@ const subMenu = this._subMenu;
 
+  /** @private */
   _focusFirstItem() {
@@ -351,2 +384,3 @@ const list = this._subMenu.$.overlay.firstElementChild;
 
+  /** @private */
   _focusLastItem() {
@@ -358,2 +392,3 @@ const list = this._subMenu.$.overlay.firstElementChild;
 
+  /** @private */
   __onceOpened(cb) {
@@ -369,2 +404,3 @@ this.style.pointerEvents = 'auto';
 
+  /** @private */
   __onItemSelected(e) {
@@ -376,2 +412,3 @@ e.stopPropagation();
 
+  /** @private */
   __onEscapeClose(e) {
@@ -381,2 +418,3 @@ this.__deactivateButton(true);
 
+  /** @private */
   __deactivateButton(restoreFocus) {
@@ -394,2 +432,6 @@ const button = this._expandedButton;
 
+  /**
+   * @param {boolean} restoreFocus
+   * @protected
+   */
   _close(restoreFocus) {
@@ -396,0 +438,0 @@ this.style.pointerEvents = '';

src/vaadin-menu-bar.js

@@ -46,4 +46,4 @@ /**
  * @extends PolymerElement
- * @mixes MenuBar.ButtonsMixin
- * @mixes MenuBar.InteractionsMixin
+ * @mixes ButtonsMixin
+ * @mixes InteractionsMixin
  * @mixes ElementMixin
@@ -107,3 +107,3 @@ * @mixes ThemableMixin
   static get version() {
-    return '1.1.0';
+    return '1.2.0-alpha1';
   }
@@ -162,3 +162,3 @@
        *
-       * @type {MenuItem[]}
+       * @type {!Array<!MenuBarItem>}
        */
@@ -165,0 +165,0 @@ items: {

vaadin-menu-bar.js

 import './theme/lumo/vaadin-menu-bar.js';
+export * from './src/vaadin-menu-bar.js';

New alerts

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Fixed alerts

No repository

Supply chain risk

Package does not have a linked source code repository. Without this field, a package will have no reference to the location of the source code use to generate the package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

59450

increased by13.95%

Number of package files

25

increased by25%

Lines of code

1272

increased by23.62%

Worsened metrics

Number of low quality alerts

1

increased byInfinity%

Dependency changes

• Updated@vaadin/vaadin-button@^2.4.0-alpha1

• Updated@vaadin/vaadin-context-menu@^4.5.0-alpha1

• Updated@vaadin/vaadin-element-mixin@^2.4.1

• Updated@vaadin/vaadin-themable-mixin@^1.6.1