analytics-client - npm Package Compare versions

Comparing version 1.3.0 to 1.4.0-getQueryString-changes-d883b3d288bc529829aaf58798d9c18e037f5487

CHANGELOG.md

@@ -7,5 +7,10 @@ # Change Log
 
-# v1.3.0
+# v1.4.0
 ## (2021-02-25)
 
+* Changed getQueryString to validate domains [Ezequiel Boehler]
+
+# v1.3.0
+## (2021-02-24)
+
 * Don't store session ID in a cookie [Pranas Ziaukas]
@@ -12,0 +17,0 @@ * Implement session ID parsing and logic [Pranas Ziaukas]

dist/package.json

 {
     "name": "analytics-client",
-    "version": "1.3.0",
+    "version": "1.4.0-getQueryString-changes-d883b3d288bc529829aaf58798d9c18e037f5487",
     "description": "Convenient builders to compose analytics tools",
@@ -5,0 +5,0 @@ "repository": {

dist/src/url-params.d.ts

@@ -19,4 +19,4 @@ import { Client } from './client';
     getSessionIdQueryString(): string;
-    getQueryString(): string;
+    getQueryString(destinationHostname?: string): string;
     isOptOutRequested(): boolean;
 }

dist/src/url-params.js

@@ -102,6 +102,16 @@ "use strict";
     };
-    AnalyticsUrlParams.prototype.getQueryString = function () {
-        return [this.getDeviceIdsQueryString(), this.getSessionIdQueryString()]
-            .filter(function (x) { return x; })
-            .join('&');
+    AnalyticsUrlParams.prototype.getQueryString = function (destinationHostname) {
+        var regex = /([a-zA-Z0-9-]+)(\.[a-zA-Z]{2,5})?(\.[a-zA-Z]+$)/g;
+        var actualDomain = window.location.hostname.match(regex);
+        var destinationDomain = destinationHostname
+            ? destinationHostname.match(regex)
+            : undefined;
+        if (actualDomain !== destinationDomain) {
+            return [this.getDeviceIdsQueryString(), this.getSessionIdQueryString()]
+                .filter(function (x) { return x; })
+                .join('&');
+        }
+        else {
+            return '';
+        }
     };
@@ -108,0 +118,0 @@ AnalyticsUrlParams.prototype.isOptOutRequested = function () {

package.json

 {
   "name": "analytics-client",
-  "version": "1.3.0",
+  "version": "1.4.0-getQueryString-changes-d883b3d288bc529829aaf58798d9c18e037f5487",
   "description": "Convenient builders to compose analytics tools",
@@ -5,0 +5,0 @@ "repository": {

src/url-params.ts

@@ -166,6 +166,16 @@ import * as Cookies from 'js-cookie';
 	 */
-	getQueryString(): string {
-		return [this.getDeviceIdsQueryString(), this.getSessionIdQueryString()]
-			.filter(x => x)
-			.join('&');
+	getQueryString(destinationHostname?: string): string {
+		const regex = /([a-zA-Z0-9-]+)(\.[a-zA-Z]{2,5})?(\.[a-zA-Z]+$)/g;
+		const actualDomain = window.location.hostname.match(regex);
+		const destinationDomain = destinationHostname
+			? destinationHostname.match(regex)
+			: undefined;
+
+		if (actualDomain !== destinationDomain) {
+			return [this.getDeviceIdsQueryString(), this.getSessionIdQueryString()]
+				.filter(x => x)
+				.join('&');
+		} else {
+			return '';
+		}
 	}
@@ -172,0 +182,0 @@

New alerts

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

302544

increased by0.49%

Lines of code

2411

increased by0.79%

Worsened metrics

Number of low quality alerts

2

increased by100%

No dependency changes