apollo-server-plugin-http-headers - npm Package Compare versions

Comparing version 0.1.2 to 0.1.3

package.json

 {
   "name": "apollo-server-plugin-http-headers",
-  "version": "0.1.2",
+  "version": "0.1.3",
   "description": "Allows you to set HTTP Headers and Cookies easily in your apollo server resolvers.",
@@ -14,3 +14,11 @@ "main": "src/index.js",
   "homepage": "https://github.com/b2a3e8/apollo-server-plugin-http-headers",
-  "keywords": ["apollo", "apollo-server", "plugin", "header", "cookie", "graphql", "lambda"],
+  "keywords": [
+    "apollo",
+    "apollo-server",
+    "plugin",
+    "header",
+    "cookie",
+    "graphql",
+    "lambda"
+  ],
   "license": "MIT",
@@ -17,0 +25,0 @@ "dependencies": {

README.md

@@ -137,1 +137,8 @@ # apollo-server-plugin-http-headers
 secure | Specifies the boolean value for the [`Secure` `Set-Cookie` attribute](https://tools.ietf.org/html/rfc6265#section-5.2.5).By default, the `Secure` attribute is not set.
+
+## Limitations
+
+### Only one cookie can be set per request
+
+There is at the moment no possility to set multiple cookies because apollo server does not support that. Find details and workaround inspiration [here](https://github.com/apollographql/apollo-server/issues/3040).
+If you add multiple items to setCookie I'll throw an exception at your face (-;

src/index.js

@@ -7,2 +7,5 @@ const cookie = require("cookie");
       willSendResponse(requestContext) {
+        const { setHeaders = [], setCookies = [] } = requestContext.context;
+
+        // inform user about wrong usage
         if (!Array.isArray(requestContext.context.setHeaders)) {
@@ -14,5 +17,8 @@ console.warn("setHeaders is not in context or is not an array");
         }
+        if (setCookies.length > 1) {
+          // dont allow to set multiple cookies because that wouldnt work (limitation in apollo-server)
+          throw new Error("multiple cookies in setCookies provided but because of limitations in apollo-server only one cookie can be set");
+        }
 
-        const { setHeaders = [], setCookies = [] } = requestContext.context;
-
+        // set headers
         setHeaders.forEach(({ key, value }) => {
@@ -23,5 +29,6 @@ requestContext.response.http.headers.append(key, value);
 
+        // set cookies
         setCookies.forEach(({ name, value, options }) => {
           var cookieString = cookie.serialize(name, value, options);
-          requestContext.response.http.headers.append("Set-Cookie", cookieString);
+          requestContext.response.http.headers.set("Set-Cookie", cookieString);
           console.debug("set header Set-Cookie: " + cookieString);
@@ -28,0 +35,0 @@ });

No alert changes

Improved metrics

Total package byte prevSize

9536

increased by8.68%

Lines of code

58

increased by13.73%

Number of lines in readme file

144

increased by5.11%

No dependency changes