cache-chain-redis - npm Package Compare versions

Comparing version 0.0.2 to 0.0.3

index.js

@@ -0,1 +1,3 @@
+var cacheChain = require('cache-chain');
+
 module.exports = function(client) {
@@ -18,5 +20,5 @@
 				if(err) {
-					cb(err);
+					cb(new cacheChain.error.failedToRefresh);
 				} else if (reply === null) {
-					cb(new Error('Key not found'));
+					cb(new cacheChain.error.notFound);
 				} else {
@@ -23,0 +25,0 @@ cb(null, JSON.parse(reply));

package.json

 {
   "name": "cache-chain-redis",
-  "version": "0.0.2",
+  "version": "0.0.3",
   "description": "A redis backend for cache-chain",
   "main": "index.js",
   "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "test": "mocha -R spec"
   },
@@ -16,6 +16,8 @@ "repository": {
   "devDependencies": {
-    "cache-chain": "0.0.2",
     "mocha": "^2.3.4",
     "redis": "^2.4.2"
+  },
+  "dependencies": {
+    "cache-chain": "0.0.3"
   }
 }

README.md

@@ -0,1 +1,2 @@
+[![Build Status](https://travis-ci.org/akayami/cache-chain-redis.svg?branch=master)](https://travis-ci.org/akayami/cache-chain-redis)
 # cache-chain-redis
@@ -2,0 +3,0 @@ Redis backend to [cache-chain](https://github.com/akayami/cache-chain)

test/main.js

 var redis = require('redis');
-var cc = require('cache-chain');
 
 describe('Main Tests for cache-chain-redis', function() {
 
-	var chain;
+	var di = {
+		chain: null,
+		cc: require('cache-chain')
+	}
 
-	beforeEach(function() {
-		chain = cc.chain({
+	beforeEach(function(done) {
+		di.chain = di.cc.chain({
 			ttl: 10000,
@@ -14,94 +16,9 @@ stale: 10000 * 2
 		var client = redis.createClient();
-		var layer = cc.layer(require('../index.js')(client));
-		chain.append(layer);
+		var layer = di.cc.layer(require('../index.js')(client));
+		di.chain.append(layer);
+		done();
 	});
 
-	it('It needs to set a value', function(done) {
-		var key = 'key';
-		var value = 'value';
-		chain.set(key, value, function(err, reply) {
-			if (err) {
-				done(err);
-			} else {
-				done();
-			}
-		})
-	});
+	require('cache-chain/test/integration')(di);
 
-	it('It needs to retrive a set value', function(done) {
-		var key = 'key';
-		var value = 'value';
-		chain.set(key, value, function(err, reply) {
-			if (err) {
-				done(err);
-			} else {
-				chain.get(key, function(err, reply) {
-					if (err) {
-						done(err);
-					} else {
-						if (reply == value) {
-							done();
-						} else {
-							done(reply)
-						}
-					}
-				})
-			}
-		})
-	});
-
-	it('It needs to delete a set value', function(done) {
-		var key = 'key';
-		var value = 'value';
-		chain.set(key, value, function(err, reply) {
-			if (err) {
-				done(err);
-			} else {
-				chain.delete(key, function(err) {
-					if (err) {
-						cb(err);
-					} else {
-						chain.get(key, function(err, reply) {
-							if (err) {
-								if (err.message == "Key not found") {
-									done();
-								} else {
-									done('Wrong error message returned');
-								}
-							} else {
-								done('Expected error message. Got correct reply instead')
-							}
-						})
-					}
-				})
-			}
-		})
-	});
-
-	it('A value needs to timeout', function(done) {
-		var key = 'key';
-		var value = 'value';
-		chain.set(key, value, {
-			ttl: 10,
-			stale: 5
-		}, function(err, reply) {
-			if (err) {
-				done(err);
-			} else {
-				setTimeout(function() {
-					chain.get(key, function(err, reply) {
-						if (err) {
-							if (err.message == "Key not found") {
-								done();
-							} else {
-								done('Wrong error message returned');
-							}
-						} else {
-							done('Expected error message. Got correct reply instead')
-						}
-					})
-				}, 15);
-			}
-		})
-	});
 });

Fixed alerts

No tests

Quality

Package does not have any tests. This is a strong signal of a poorly maintained or low quality package.

Found 1 instance in 1 package

Improved metrics

Dev dependency count

2

decreased by-33.33%

Number of low quality alerts

2

decreased by-33.33%

Number of lines in readme file

10

increased by11.11%

Worsened metrics

Total package byte prevSize

2103

decreased by-38.8%

Dependency count

1

increased byInfinity%

Lines of code

52

decreased by-60.61%

Dependency changes

• + Addedcache-chain@0.0.3

• + Addedcache-chain@0.0.3(transitive)

• + Addedmerge@1.2.1(transitive)