cache-control - npm Package Compare versions

Comparing version 1.0.2 to 1.0.3

index.js

 var url = require('fast-url-parser');
 var regular = require('regular');
 var onHeaders = require('on-headers');
-var _isNumber = require('lodash.isnumber');
 var globject = require('globject');
 var slasher = require('glob-slasher');
+var setCacheHeader = require('cache-header');
 
 module.exports = function (cachePaths) {
   
-  cachePaths = cachePaths || {};
-  
   return function (req, res, next) {
     
     var pathname = url.parse(req.url).pathname;
-    var cacheValues = globject(slasher(cachePaths, {value: false}));
+    var cacheValues = globject(slasher(cachePaths || {}, {value: false}));
     var cacheValue = cacheValues(slasher(pathname));
@@ -20,13 +18,5 @@
       
+      // Default value
       res.setHeader('Cache-Control', 'public, max-age=300');
-      
-      if (cacheValue === false) {
-        res.setHeader('Cache-Control', 'no-cache');
-      }
-      else if (isNumber(cacheValue)) {
-        res.setHeader('Cache-Control', 'public, max-age=' + cacheValue.toString());
-      }
-      else if (typeof cacheValue === 'string') {
-        res.setHeader('Cache-Control', cacheValue);
-      }
+      setCacheHeader(res, cacheValue);
     });
@@ -36,7 +26,2 @@
   };
-};
-
-function isNumber (val) {
-  
-  return _isNumber(val) || regular.number.test(val);
-}
+};

package.json

 {
   "name": "cache-control",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "Express/Connect middleware to set url cache options with globs",
@@ -35,2 +35,3 @@ "main": "index.js",
   "dependencies": {
+    "cache-header": "^1.0.0",
     "fast-url-parser": "^1.0.6-0",
@@ -37,0 +38,0 @@ "glob-slasher": "^1.0.1",

No alert changes

Worsened metrics

Total package byte prevSize

5932

decreased by-5.75%

Dependency count

7

increased by16.67%

Lines of code

84

decreased by-11.58%

Dependency changes

• + Addedcache-header@^1.0.0

• + Addedcache-header@1.0.3(transitive)

• + Addedlodash.isstring@2.4.1(transitive)