cimpress-fulfiller-identity - npm Package Compare versions

Comparing version 0.0.1 to 0.0.2

package.json

 {
   "name": "cimpress-fulfiller-identity",
-  "version": "0.0.1",
+  "version": "0.0.2",
   "description": "Thin client library for Cimpress' Fulfiller Identity service",
@@ -5,0 +5,0 @@ "main": "index.js",

src/fulfiller_identity_client.js

 const FulfillerIdentityProxy = require("./fulfiller_identity_proxy");
 const Fulfiller = require("./fulfiller");
+const FulfillerNotFoundError = require("./errors/fulfiller_not_found_error");
+
 let AWSXray = null;
@@ -28,2 +30,6 @@
 
+  getUrl() {
+    return fulfillerIdentityProxy.url;
+  }
+
   /**
@@ -38,35 +44,42 @@ * Returns an array of fulfiller objects that meet the criteria expesses in options
 
-    return this.fulfillerIdentityProxy.callFulfillerIdentity("GET").then((parsedBody) =>
-      parsedBody.map(f => new Fulfiller(f.fulfillerId, f.internalFulfillerId, f.name, f.email, f.phone, f.language))
-    );
+    return this.fulfillerIdentityProxy.callFulfillerIdentity("GET").then(
+      (parsedBody) => parsedBody.map(f => new Fulfiller(f.fulfillerId, f.internalFulfillerId, f.name, f.email, f.phone, f.language)),
+      (err) => Promise.reject(new Error("Unable to get fulfillers: " + err.message))
+    )
   }
 
-  /**
-   * Fetches the fulfiller based on the fulfiller id.
-   * @param fulfillerId One of the fulfiller identifiers
-   * @param options
-   */
-  getFulfiller(fulfillerId, options) {
-    let noCache = (options && options.noCache) || false;
+/**
+ * Fetches the fulfiller based on the fulfiller id.
+ * @param fulfillerId One of the fulfiller identifiers
+ * @param options
+ */
+getFulfiller(fulfillerId, options)
+{
+  let noCache = (options && options.noCache) || false;
 
-    return this.fulfillerIdentityProxy.callFulfillerIdentity("GET", { fulfillerId: fulfillerId }).then((f) =>
-      new Fulfiller(f.fulfillerId, f.internalFulfillerId, f.name, f.email, f.phone, f.language)
-    ).catch((err) => err);
-  }
+  return this.fulfillerIdentityProxy.callFulfillerIdentity("GET", { fulfillerId: fulfillerId }).then(
+    (f) => new Fulfiller(f.fulfillerId, f.internalFulfillerId, f.name, f.email, f.phone, f.language),
+    (err) => (err.constructor.name === "StatusCodeError") ?
+      Promise.reject(new FulfillerNotFoundError(`Fulfiller ${fulfillerId} does not exits`)) :
+      Promise.reject(new Error("Unable to get fulfiller: " + err.message))
+  );
+}
 
-  /**
-   * Saves changes made to a fulfiller object.
-   * @param fulfiller Fufiller object, either retrieved via getFulfiller or getFulfillers or using new Fulfiller statement
-   */
-  saveFulfiller(fulfiller) {
-    if (fulfiller.fulfillerId || fulfiller.internalFulfillerId) {
-      return this.fulfillerIdentityProxy.callFulfillerIdentity("PUT", {
-        fulfillerId: fulfiller.fulfillerId || fulfiller.internalFulfillerId,
-        data: fulfiller
-      }).then((f) => Promise.resolve(), (err) => Promise.reject(new Error("Unable to update fulfiller: " + err.message)));
-    } else {
-      return this.fulfillerIdentityProxy.callFulfillerIdentity("POST", { data: fulfiller }).then((f) => Promise.resolve(),
-        (err) => Promise.reject(new Error("Unable to update fulfiller: " + err.message)))
-    }
+/**
+ * Saves changes made to a fulfiller object.
+ * @param fulfiller Fufiller object, either retrieved via getFulfiller or getFulfillers or using new Fulfiller statement
+ */
+saveFulfiller(fulfiller)
+{
+  if (fulfiller.fulfillerId || fulfiller.internalFulfillerId) {
+    return this.fulfillerIdentityProxy.callFulfillerIdentity("PUT", {
+      fulfillerId: fulfiller.fulfillerId || fulfiller.internalFulfillerId,
+      data: fulfiller
+    }).then((f) => Promise.resolve(),
+      (err) => Promise.reject(new Error("Unable to update fulfiller: " + err.message)));
+  } else {
+    return this.fulfillerIdentityProxy.callFulfillerIdentity("POST", { data: fulfiller }).then((f) => Promise.resolve(),
+      (err) => Promise.reject(new Error("Unable to update fulfiller: " + err.message)))
   }
+}
 
@@ -73,0 +86,0 @@ }

No alert changes

Improved metrics

Total package byte prevSize

20591

increased by2.37%

Number of package files

9

increased by12.5%

Lines of code

250

increased by5.49%

No dependency changes