currency-in-words - npm Package Compare versions

Comparing version 1.1.2 to 1.1.3

package.json

 {
   "name": "currency-in-words",
-  "version": "1.1.2",
+  "version": "1.1.3",
   "description": "convert currency or any numbers to corresponding words, eg: 1 -> \"one\", 10 -> \"ten\", 101 -> \"one hundred and one\" etc...",
@@ -5,0 +5,0 @@ "main": "src/index.js",

README.md

@@ -7,4 +7,4 @@ # currency-in-words
 ___
-> | 1. Current version supports only indian system. But, subsequent versions will support international version.|
-> | 2. Commas in the test cases are just for readability, but doesn't support in the input.                     |
+> 1. Current version supports only indian system. But, subsequent versions will support international version.|
+> 2. Commas in the test cases are just for readability, but doesn't support in the input.                     |
 ___
@@ -26,16 +26,98 @@
 
-> Refer the images(test-cases) for more insight.
+```javascript
+console.log('777')  //   seven hundred seventy seven
+console.log('1022') //  one thousand twenty two
+console.log('1,022')    // NaN
+console.log('66.123') //  sixty six.twelve
+```
+> *Note*
+> 1. Expect ```NaN``` when passed in ','
+> 2. Decimals are corrected to two places
 
 Adding test-case results just to make your life easier..
 
-<img src="./public/test1.png">
+```javascript
+Convert
+    ✓ returns "NaN" for undefined (1 ms)
+    ✓ returns "NaN" for null
+    ✓ returns "NaN" for an invalid number(a1.01)
+    ✓ returns "NaN" for an invalid number(1.1a)
+    ✓ returns "NaN" for an invalid number(random string) (1 ms)
+    ✓ returns "one" when given the input 1
+    ✓ returns "nine" when given the input 9
+    ✓ returns "ten" when given the input 10
+    ✓ returns "eleven" when given the input 11
+    ✓ returns "nineteen" when given the input 19
+    ✓ returns "ninety" when given the input 90
+    ✓ returns "ninety nine" when given the input 99
+    ✓ returns "one hundred" when given the input 100
+    ✓ returns "one hundred nine" when given the input 109
+    ✓ returns "one hundred ten" when given the input 110
+    ✓ returns "one hundred eleven" when given the input 111 (1 ms)
+    ✓ returns "one hundred nineteen" when given the input 119
+    ✓ returns "one hundred ninety" when given the input 190
+    ✓ returns "one hundred ninety nine" when given the input 199
+    ✓ returns "one thousand" when given the input 1000
+    ✓ returns "one thousand one" when given the input 1001
+    ✓ returns "one thousand ten" when given the input 1010
+    ✓ returns "one thousand one hundred ten" when given the input 1110
+    ✓ returns "one thousand one hundred eleven" when given the input 1111
+    ✓ returns "one thousand one hundred ninety nine" when given the input 1199 (1 ms)
+    ✓ returns "one thousand nine hundred" when given the input 1900
+    ✓ returns "one thousand nine hundred ninety nine" when given the input 1999
+    ✓ returns "ten thousand" when given the input 10000
+    ✓ returns "eleven thousand one hundred nine" when given the input 11109
+    ✓ returns "eleven thousand one hundred ten" when given the input 11110
+    ✓ returns "eleven thousand one hundred eleven" when given the input 11111
+    ✓ returns "eleven thousand one hundred nineteen" when given the input 11119
+    ✓ returns "eleven thousand one hundred ninety" when given the input 11190
+    ✓ returns "eleven thousand one hundred ninety nine" when given the input 11199
+    ✓ returns "one lakh" when given the input 1,00,000
+    ✓ returns "one lakh eleven thousand one hundred nine" when given the input 1,11,109
+    ✓ returns "one lakh eleven thousand one hundred ten" when given the input 1,11,110
+    ✓ returns "one lakh eleven thousand one hundred eleven" when given the input 1,11,111
+    ✓ returns "one lakh eleven thousand one hundred nineteen" when given the input 1,11,119
+    ✓ returns "one lakh leven thousand one hundred ninety" when given the input 1,11,190
+    ✓ returns "one lakh eleven thousand one hundred ninety nine" when given the input 1,11,199
+    ✓ returns "ten lakh" when given the input 10,00,000
+    ✓ returns "ten lakh eleven thousand one hundred nine" when given the input 10,11,109
+    ✓ returns "ten lakh eleven thousand one hundred ten" when given the input 10,11,110
+    ✓ returns "ten lakh eleven thousand one hundred eleven" when given the input 10,11,111
+    ✓ returns "ten lakh eleven thousand one hundred nineteen" when given the input 10,11,119
+    ✓ returns "ten lakh leven thousand one hundred ninety" when given the input 10,11,190
+    ✓ returns "ten lakh eleven thousand one hundred ninety nine" when given the input 10,11,199
+    ✓ returns "one crore" when given the input 1,00,00,000 (1 ms)
+    ✓ returns "one crore one lakh eleven thousand one hundred nine" when given the input 1,01,11,109
+    ✓ returns "one crore one lakh eleven thousand one hundred ten" when given the input 1,01,11,110
+    ✓ returns "one crore one lakh eleven thousand one hundred eleven" when given the input 1,01,11,111
+    ✓ returns "oone crore ne lakh eleven thousand one hundred nineteen" when given the input 1,11,119
+    ✓ returns "one crore one lakh leven thousand one hundred ninety" when given the input 1,11,190
+    ✓ returns "one crore one lakh eleven thousand one hundred ninety nine" when given the input 1,11,199
+    ✓ returns "ten crore ten lakh" when given the input 10,00,00,000
+    ✓ returns "tten crore en lakh eleven thousand one hundred nine" when given the input 10,00,11,109
+    ✓ returns "ten crore ten lakh eleven thousand one hundred ten" when given the input 10,00,11,110
+    ✓ returns "ten crore ten lakh eleven thousand one hundred eleven" when given the input 10,00,11,111
+    ✓ returns "ten crore ten lakh eleven thousand one hundred nineteen" when given the input 10,00,11,119 (1 ms)
+    ✓ returns "ten crore ten lakh leven thousand one hundred ninety" when given the input 10,00,11,190
+    ✓ returns "ten crore ten lakh eleven thousand one hundred ninety nine" when given the input 10,00,11,199
+    ✓ returns "five hundred fifty five" when given the input 555
+    ✓ returns "seventy seven thousand two hundred eighty nine" when given the input 77,289
+    ✓ returns "seventeen crore ninety nine lakh one hundred" when given the input 17,99,00,100
+    ✓ returns "ninety nine crore ninety nine lakh ninety nine thousand nine hundred ninety nine" when given the input 99,99,99,999
+    ✓ returns "one.one" when given the input 1.1
+    ✓ returns "fifty seven.ninety nine" when given the input 57.99
+    ✓ returns "ten" when given the input 10.01; ignore x.01 to x.09 (1 ms)
+    ✓ returns "zero" when given the input 0.00
+    ✓ returns "zero" when given the input 000
+    ✓ returns "three hundred thirty" when given the input 00330; corrected leading zeros
+    ✓ returns "eighty eight.twenty" when given the input 088.200; corrected leading zeros and two decimal places
+```
 
-<img src="./public/test2.png">
+#### Hacks :rocket:
 
+For some reason, if you want the decimal places not to be corrected, you can control from your code level,
 
-As we know it's hard to define the scope of a software. The scalability it offers is also a potential danger, as we might end up in a
-forever loop, adding feature after feature. Hence couple of limitations has been set going forth.
-
-1. Ignoring all decimals after two decimal places.
-2. Never going to address/handle commas in the input.
-3. Out put for decimals is in the format 'xxx yyy zzz.xx yy' without any spaces on either sides of the period, this is probably not gonna change for the sake of backward compatability. But you can always manipulate it with a little bit of your code.
+```javascript
+const [dollars, cents] = amount
+const billAmout = `${convert(dollars)}.${convert(cents)}`
+```

No alert changes

Improved metrics

Number of lines in readme file

122

increased by205%

Worsened metrics

Total package byte prevSize

38489

decreased by-95.31%

Number of package files

11

decreased by-15.38%

No dependency changes