domassist - npm Package Compare versions

Comparing version 2.0.2 to 2.0.3

dist/domassist.esm.js

@@ -85,13 +85,11 @@ function isWindow(obj) {
 function closest(el, selector) {
-  if (matches(el, selector)) {
-    return el;
-  }
+  do {
+    if (matches(el, selector)) {
+      return el;
+    }
 
-  var parent = el.parentElement ? el.parentElement : el.parentNode;
+    el = el.parentElement || el.parentNode;
+  } while (el !== null && el.nodeType === 1);
 
-  while (parent.parentElement && !matches(parent, selector)) {
-    parent = parent.parentElement;
-  }
-
-  return matches(parent, selector) ? parent : null;
+  return null;
 }
@@ -561,3 +559,3 @@
 export default domassist_default;
-export { addClass, delegate, find, findOne, fire, hasClass, hide, hover, isWindow, off, on, once, prefixedTransform, removeClass, getScrollableContainer as scrollableContainer, show, matches, toggleClass, closest, ready, styles, addAttrs, html, isTouch, modify, append, toArray, remove };
+export { addAttrs, addClass, append, closest, delegate, find, findOne, fire, hasClass, hide, hover, html, isTouch, isWindow, matches, modify, off, on, once, prefixedTransform, ready, remove, removeClass, getScrollableContainer as scrollableContainer, show, styles, toArray, toggleClass };
 //# sourceMappingURL=domassist.esm.js.map

dist/domassist.js

@@ -88,13 +88,11 @@ var app = (function (exports) {
   function closest(el, selector) {
-    if (matches(el, selector)) {
-      return el;
-    }
+    do {
+      if (matches(el, selector)) {
+        return el;
+      }
 
-    var parent = el.parentElement ? el.parentElement : el.parentNode;
+      el = el.parentElement || el.parentNode;
+    } while (el !== null && el.nodeType === 1);
 
-    while (parent.parentElement && !matches(parent, selector)) {
-      parent = parent.parentElement;
-    }
-
-    return matches(parent, selector) ? parent : null;
+    return null;
   }
@@ -563,3 +561,7 @@
 
+  exports.addAttrs = addAttrs;
   exports.addClass = addClass;
+  exports.append = append;
+  exports.closest = closest;
+  exports.default = domassist_default;
   exports.delegate = delegate;
@@ -572,3 +574,7 @@ exports.find = find;
   exports.hover = hover;
+  exports.html = html;
+  exports.isTouch = isTouch;
   exports.isWindow = isWindow;
+  exports.matches = matches;
+  exports.modify = modify;
   exports.off = off;
@@ -578,18 +584,10 @@ exports.on = on;
   exports.prefixedTransform = prefixedTransform;
+  exports.ready = ready;
+  exports.remove = remove;
   exports.removeClass = removeClass;
   exports.scrollableContainer = getScrollableContainer;
   exports.show = show;
-  exports.matches = matches;
-  exports.toggleClass = toggleClass;
-  exports.closest = closest;
-  exports.ready = ready;
   exports.styles = styles;
-  exports.addAttrs = addAttrs;
-  exports.html = html;
-  exports.isTouch = isTouch;
-  exports.modify = modify;
-  exports.append = append;
   exports.toArray = toArray;
-  exports.remove = remove;
-  exports.default = domassist_default;
+  exports.toggleClass = toggleClass;
 
@@ -596,0 +594,0 @@ return exports;

lib/closest.js

 import matches from './matches';
 
 function closest(el, selector) {
-  if (matches(el, selector)) {
-    return el;
-  }
-  let parent = el.parentElement ? el.parentElement : el.parentNode;
-  while (parent.parentElement && !matches(parent, selector)) {
-    parent = parent.parentElement;
-  }
-  return (matches(parent, selector)) ? parent : null;
+  do {
+    if (matches(el, selector)) {
+      return el;
+    }
+
+    el = el.parentElement || el.parentNode;
+  } while (el !== null && el.nodeType === 1);
+
+  return null;
 }
 
 export default closest;

package.json

 {
   "name": "domassist",
-  "version": "2.0.2",
+  "version": "2.0.3",
   "description": "Various dom helpers",
@@ -9,5 +9,7 @@ "main": "domassist.js",
     "start": "scriptkit",
+    "build": "scriptkit build",
     "dev": "scriptkit dev",
-    "test": "cat test/domassist.test.dist.js | tape-run --static . --browser phantomjs --render tap-spec",
-    "prepublishOnly": "scriptkit"
+    "pretest": "scriptkit build",
+    "prepublishOnly": "scriptkit",
+    "test": "cat test/domassist.test.dist.js | tape-run --static . --browser phantomjs --render tap-spec"
   },
@@ -14,0 +16,0 @@ "repository": {

README.md

 # domassist
 
 [![Build Status](https://travis-ci.org/firstandthird/domassist.svg?branch=master)](https://travis-ci.org/firstandthird/domassist)
+![npm](https://img.shields.io/npm/v/domassist.svg)
 
@@ -9,3 +10,3 @@ This is a collection of functions designed to make working the DOM easier.
 
-`npm install --save domassist`
+`npm install domassist`
 
@@ -16,3 +17,5 @@ ## Usage
 
-`import domassist from 'domassist'`
+```js
+import domassist from 'domassist'
+```
 
@@ -19,0 +22,0 @@ The first argument for each method you are interested is either a selector, DOM node, or a collection of

No alert changes

Improved metrics

Number of lines in readme file

462

increased by0.65%

Worsened metrics

Total package byte prevSize

53674

decreased by-0.37%

Lines of code

1487

decreased by-0.2%

No dependency changes