driver-worker - npm Package Compare versions

Comparing version 0.6.6-3 to 0.6.6-4

lib/create-document.js

@@ -451,3 +451,3 @@ "use strict";
       _this2.eventListeners = {};
-      _this2.style = {};
+      _this2._style = {};
       Object.defineProperty(_assertThisInitialized(_assertThisInitialized(_this2)), 'className', {
@@ -454,0 +454,0 @@ set: function set(val) {

lib/dom-renderer.js

@@ -73,2 +73,3 @@ "use strict";
   function deleteNode(vnode) {
+    if (!vnode) return null;
     return NODES.delete(vnode.$$id);
@@ -292,4 +293,7 @@ }
           var node = getNode(removedNodes[i]);
-          parent.removeChild(node);
           deleteNode(node);
+
+          if (parent && node) {
+            parent.removeChild(node);
+          }
         }
@@ -306,3 +310,5 @@ }
 
-          parent.insertBefore(newNode, nextSibling && getNode(nextSibling) || null);
+          if (parent) {
+            parent.insertBefore(newNode, nextSibling && getNode(nextSibling) || null);
+          }
         }
@@ -316,4 +322,6 @@ }
           style = _ref3.style;
-      var node = getNode(target); // TODO: some with `createNode`, should processed by one method
+      var node = getNode(target); // Node maybe null when node is removed and there is a setInterval change the node that will cause error
 
+      if (!node) return; // TODO: some with `createNode`, should processed by one method
+
       if (style) {
@@ -339,2 +347,3 @@ (0, _setStyle.default)(node, style);
       var node = getNode(target);
+      if (!node) return;
 
@@ -347,2 +356,3 @@ _addEvent(node, eventName);
       var node = getNode(target);
+      if (!node) return;
 
@@ -357,2 +367,3 @@ _removeEvent(node, eventName);
       var canvas = getNode(target);
+      if (!canvas) return;
       var context = canvas.getContext('2d');
@@ -359,0 +370,0 @@

lib/index.js

@@ -271,11 +271,11 @@ "use strict";
     setStyles: function setStyles(node, styles) {
-      var tranformedStyles = {};
+      var newStyles = node.style;
 
       for (var prop in styles) {
         var val = styles[prop];
-        tranformedStyles[prop] = (0, _styleUnit.convertUnit)(val, prop);
-      } // For trigger attribute mutation
+        newStyles[prop] = (0, _styleUnit.convertUnit)(val, prop);
+      } // Assign to style for trigger style update
 
 
-      node.style = tranformedStyles;
+      node.style = newStyles;
     },
@@ -282,0 +282,0 @@ beforeRender: function beforeRender() {

lib/set-style.js

@@ -6,3 +6,3 @@ "use strict";
 });
-exports.default = addVendorPrefixes;
+exports.default = setStyleWithVendorPrefixes;
 var PREFIX_PROPS = {
@@ -88,3 +88,3 @@ flex: true,
 
-function addVendorPrefixes(node, styleObject) {
+function setStyleWithVendorPrefixes(node, styleObject) {
   var tranformedStyles = {};
@@ -91,0 +91,0 @@

package.json

 {
   "name": "driver-worker",
-  "version": "0.6.6-3",
+  "version": "0.6.6-4",
   "description": "Worker driver for Rax",
@@ -5,0 +5,0 @@ "license": "BSD-3-Clause",

src/create-document.js

@@ -347,3 +347,3 @@ const global = typeof global !== 'undefined' ? global : typeof self !== 'undefined' ? self : new Function('return this')();
       this.eventListeners = {};
-      this.style = {};
+      this._style = {};
       Object.defineProperty(this, 'className', {
@@ -390,2 +390,3 @@ set: val => {
     }
+
     set style(styleObject) {
@@ -392,0 +393,0 @@ this._style = styleObject;

src/dom-renderer.js

@@ -59,2 +59,3 @@ import setStyle from './set-style';
   function deleteNode(vnode) {
+    if (!vnode) return null;
     return NODES.delete(vnode.$$id);
@@ -257,4 +258,6 @@ }
           let node = getNode(removedNodes[i]);
-          parent.removeChild(node);
           deleteNode(node);
+          if (parent && node) {
+            parent.removeChild(node);
+          }
         }
@@ -269,6 +272,6 @@ }
           }
-          parent.insertBefore(
-            newNode,
-            nextSibling && getNode(nextSibling) || null
-          );
+
+          if (parent) {
+            parent.insertBefore(newNode, nextSibling && getNode(nextSibling) || null);
+          }
         }
@@ -279,2 +282,4 @@ }
       let node = getNode(target);
+      // Node maybe null when node is removed and there is a setInterval change the node that will cause error
+      if (!node) return;
 
@@ -298,2 +303,4 @@ // TODO: some with `createNode`, should processed by one method
       let node = getNode(target);
+      if (!node) return;
+
       addEvent(node, eventName);
@@ -303,2 +310,4 @@ },
       let node = getNode(target);
+      if (!node) return;
+
       removeEvent(node, eventName);
@@ -308,2 +317,4 @@ },
       let canvas = getNode(target);
+      if (!canvas) return;
+
       let context = canvas.getContext('2d');
@@ -310,0 +321,0 @@

src/index.js

@@ -287,11 +287,10 @@ import { convertUnit, setRem } from 'style-unit';
     setStyles(node, styles) {
-      let tranformedStyles = {};
+      let newStyles = node.style;
 
       for (let prop in styles) {
         let val = styles[prop];
-        tranformedStyles[prop] = convertUnit(val, prop);
+        newStyles[prop] = convertUnit(val, prop);
       }
-
-      // For trigger attribute mutation
-      node.style = tranformedStyles;
+      // Assign to style for trigger style update
+      node.style = newStyles;
     },
@@ -298,0 +297,0 @@

src/set-style.js

@@ -83,3 +83,3 @@ const PREFIX_PROPS = {
 
-export default function addVendorPrefixes(node, styleObject) {
+export default function setStyleWithVendorPrefixes(node, styleObject) {
   let tranformedStyles = {};
@@ -86,0 +86,0 @@

No alert changes

Improved metrics

Total package byte prevSize

85724

increased by0.75%

Lines of code

2684

increased by0.6%

No dependency changes