edge-core-js - npm Package Compare versions

Comparing version 2.0.0 to 2.0.1

CHANGELOG.md

 # edge-core-js
 
+## Unreleased
+
+## 2.0.1 (2024-01-08)
+
+- added: Missing asset action types (claim, claimOrder, swapNetworkFee, and transferNetworkFee).
+- fixed: Avoid superfluous property updates.
+- fixed: Correctly populate `tokenId` on `makeSpend` when using legacy currency plugins.
+- fixed: Correctly write `assetAction` to disk.
+
 ## 2.0.0 (2024-01-04)
@@ -4,0 +13,0 @@

lib/core/currency/wallet/currency-wallet-api.js

@@ -532,2 +532,4 @@ function _nullishCoalesce(lhs, rhsFn) { if (lhs != null) { return lhs; } else { return rhsFn(); } } function _optionalChain(ops) { let lastAccessLHS = undefined; let value = ops[0]; let i = 1; while (i < ops.length) { const op = ops[i]; const fn = ops[i + 1]; i += 2; if ((op === 'optionalAccess' || op === 'optionalCall') && value == null) { return undefined; } if (op === 'access' || op === 'optionalAccess') { lastAccessLHS = value; value = fn(value); } else if (op === 'call' || op === 'optionalCall') { value = fn((...args) => value.call(lastAccessLHS, ...args)); lastAccessLHS = undefined; } } return value; }import { add, div, lte, mul, sub } from 'biggystring'
       tx.spendTargets = savedTargets
+      tx.currencyCode = upgradedCurrency.currencyCode
+      tx.tokenId = upgradedCurrency.tokenId
       if (metadata != null) tx.metadata = metadata
@@ -534,0 +536,0 @@ if (swapData != null) tx.swapData = asEdgeTxSwap(swapData)

lib/core/currency/wallet/currency-wallet-cleaners.js

@@ -235,11 +235,12 @@ import {
 export const asEdgeAssetActionType = asValue(
+  'claim',
+  'claimOrder',
   'stake',
+  'stakeNetworkFee',
   'stakeOrder',
   'unstake',
+  'unstakeNetworkFee',
   'unstakeOrder',
-  'stake',
-  'stakeOrder',
-  'unstake',
-  'unstakeOrder',
   'swap',
+  'swapNetworkFee',
   'swapOrderPost',
@@ -252,3 +253,4 @@ 'swapOrderFill',
   'tokenApproval',
-  'transfer'
+  'transfer',
+  'transferNetworkFee'
 )
@@ -279,2 +281,3 @@
 const asTransactionAsset = asObject({
+  assetAction: asOptional(asEdgeAssetAction),
   metadata: asEdgeMetadata,
@@ -281,0 +284,0 @@ nativeAmount: asOptional(asString),

lib/flow/types.js

@@ -324,2 +324,4 @@ // @flow
 export type EdgeAssetActionType =
+  | "claim"
+  | "claimOrder"
   | "stake"
@@ -331,7 +333,4 @@ | "stakeNetworkFee"
   | "unstakeOrder"
-  | "stake"
-  | "stakeOrder"
-  | "unstake"
-  | "unstakeOrder"
   | "swap"
+  | "swapNetworkFee"
   | "swapOrderPost"
@@ -344,3 +343,4 @@ | "swapOrderFill"
   | "tokenApproval"
-  | "transfer";
+  | "transfer"
+  | "transferNetworkFee";
 
@@ -347,0 +347,0 @@ export type EdgeAssetAction = {

lib/util/compare.js

@@ -53,2 +53,6 @@ const TYPED_ARRAYS = {
 
+  if (type === '[object Map]') {
+    return compareMap(a, b)
+  }
+
   // Typed arrays:
@@ -68,2 +72,18 @@ if (TYPED_ARRAYS[type]) {
 /**
+ * Compare Maps
+ */
+function compareMap(map1, map2) {
+  if (map1.size !== map2.size) {
+    return false
+  }
+
+  for (const [key, value] of map1) {
+    if (!map2.has(key) || map2.get(key) !== value) {
+      return false
+    }
+  }
+
+  return true
+}
+/**
  * Returns true if two Javascript values are equal in value.
@@ -70,0 +90,0 @@ */

package.json

 {
   "name": "edge-core-js",
-  "version": "2.0.0",
+  "version": "2.0.1",
   "description": "Edge account & wallet management library",
@@ -5,0 +5,0 @@ "keywords": [

src/types/types.ts

@@ -322,2 +322,4 @@ import type { Disklet } from 'disklet'
 export type EdgeAssetActionType =
+  | 'claim'
+  | 'claimOrder'
   | 'stake'
@@ -329,7 +331,4 @@ | 'stakeNetworkFee'
   | 'unstakeOrder'
-  | 'stake'
-  | 'stakeOrder'
-  | 'unstake'
-  | 'unstakeOrder'
   | 'swap'
+  | 'swapNetworkFee'
   | 'swapOrderPost'
@@ -343,2 +342,3 @@ | 'swapOrderFill'
   | 'transfer'
+  | 'transferNetworkFee'
 
@@ -345,0 +345,0 @@ export interface EdgeAssetAction {

No alert changes

Improved metrics

Lines of code

31456

increased by0.14%

Worsened metrics

Total package byte prevSize

3374000

decreased by-1.3%

No dependency changes