ember-cli-deploy-webhooks - npm Package Compare versions

Comparing version 0.4.1 to 0.4.2

CHANGELOG.md

@@ -0,1 +1,6 @@
+# 0.4.2
+
+* ember-cli-deply-webhooks now uses rsvp for promises instead of the Ember CLI
+  Promise implementation, see #23.
+
 # 0.4.1
@@ -2,0 +7,0 @@

index.js

 /* jshint node: true */
 'use strict';
 
-var Promise          = require('ember-cli/lib/ext/promise');
+var RSVP             = require('rsvp');
 var DeployPluginBase = require('ember-cli-deploy-plugin');
@@ -43,3 +43,3 @@ var Notify = require('./lib/notify');
 
-    return Promise.all(promises);
+    return RSVP.all(promises);
   }
@@ -46,0 +46,0 @@ }

lib/notify.js

@@ -1,2 +0,2 @@
-var Promise    = require('ember-cli/lib/ext/promise');
+var RSVP       = require('rsvp');
 var CoreObject = require('core-object');
@@ -6,3 +6,3 @@ var request    = require('request');
 
-var post = Promise.denodeify(request.post);
+var post = RSVP.denodeify(request.post);
 
@@ -31,3 +31,3 @@ function optsValid(opts) {
     var plugin      = this._plugin;
-    var makeRequest = Promise.denodeify(this._client);
+    var makeRequest = RSVP.denodeify(this._client);
     var critical = (('critical' in opts) ? delete opts.critical : false);
@@ -51,3 +51,3 @@
           if (critical && !(300 > response.statusCode && response.statusCode >= 200)) {
-            return Promise.reject(response.statusCode);
+            return RSVP.reject(response.statusCode);
           }
@@ -61,3 +61,3 @@
           if (critical) {
-            return Promise.reject(error);
+            return RSVP.reject(error);
           }
@@ -70,8 +70,8 @@ plugin.log(errorMessage, { color: 'red' });
       if (critical) {
-        return Promise.reject(warningMessage);
+        return RSVP.reject(warningMessage);
       }
       plugin.log(serviceKey+' => '+warningMessage, { color: 'yellow', verbose: true });
-      return Promise.resolve();
+      return RSVP.resolve();
     }
   }
 });

package.json

 {
   "name": "ember-cli-deploy-webhooks",
-  "version": "0.4.1",
+  "version": "0.4.2",
   "description": "Ember CLI Deploy plugin for calling webhooks during deployments",
@@ -54,3 +54,4 @@ "directories": {
     "lodash": "^3.10.1",
-    "request": "^2.65.0"
+    "request": "^2.65.0",
+    "rsvp": "^3.5.0"
   },
@@ -57,0 +58,0 @@ "ember-addon": {

No alert changes

Improved metrics

Total package byte prevSize

21137

increased by0.42%

Worsened metrics

Dependency count

6

increased by20%

Dependency changes

• + Addedrsvp@^3.5.0