ember-mobile-inputs - npm Package Compare versions

Comparing version 3.3.4 to 3.3.5

addon/components/mi-number.js

@@ -168,3 +168,3 @@ import layout from "../templates/components/mi-number";
 
-    if (isNaN(value) && isPresent(min)){
+    if (isNaN(value) && isPresent(min)) {
       return min;
@@ -192,8 +192,10 @@ }
 
+  mobileInputVisibleChangedFn(value) {
+    this.set('mobileInputVisible', value);
+  },
+
   didInsertElement: function() {
     this._super(...arguments);
 
-    this.get('mobileInputEventBus').subscribe('mobileInputVisibleChanged', (value) => {
-      this.set('mobileInputVisible', value);
-    });
+    this.get('mobileInputEventBus').subscribe('mobileInputVisibleChanged', this.mobileInputVisibleChangedFn);
 
@@ -213,5 +215,5 @@ if (!isTouchDevice()) {
 
-  willDestroyElement(){
+  willDestroyElement() {
     this._super(...arguments);
-    this.get('mobileInputEventBus').unsubscribe('mobileInputVisibleChanged');
+    this.get('mobileInputEventBus').unsubscribe('mobileInputVisibleChanged', this.mobileInputVisibleChangedFn);
   },
@@ -218,0 +220,0 @@

addon/services/mobile-input-event-bus.js

@@ -11,5 +11,8 @@ import Service from '@ember/service';
 	},
-	unsubscribe: function () {
+	unsubscribe: function (eventName) {
+    if (!this.has(eventName)){
+      return;
+    }
 		return this.off.apply(this, arguments);
 	}
 });

package.json

 {
   "name": "ember-mobile-inputs",
-  "version": "3.3.4",
+  "version": "3.3.5",
   "description": "Mobile- and Desktop- friendly inputs",
@@ -5,0 +5,0 @@ "scripts": {

No alert changes

Improved metrics

Total package byte prevSize

341916

increased by0.04%

Lines of code

926

increased by0.43%

No dependency changes