eslint-plugin-decorator-position - npm Package Compare versions

Comparing version 2.2.8 to 2.2.9

CHANGELOG.md

@@ -0,1 +1,8 @@
+## [2.2.9](https://github.com/NullVoxPopuli/eslint-plugin-decorator-position/compare/v2.2.8...v2.2.9) (2020-11-09)
+
+
+### Bug Fixes
+
+* **#196:** fix prettier unspecified printWidth ([2c327c8](https://github.com/NullVoxPopuli/eslint-plugin-decorator-position/commit/2c327c87464152a86998baab26034305ff007a1a)), closes [#195](https://github.com/NullVoxPopuli/eslint-plugin-decorator-position/issues/195)
+
 ## [2.2.8](https://github.com/NullVoxPopuli/eslint-plugin-decorator-position/compare/v2.2.7...v2.2.8) (2020-11-09)
@@ -2,0 +9,0 @@

lib/rules/decorator-position.js

@@ -317,2 +317,8 @@ 'use strict';
   const eslintPrettierRules = cli.getConfigForFile(filePath).rules['prettier/prettier'] || [];
+  const isEnabled = eslintPrettierRules[0] === 'error';
+
+  if (!isEnabled) {
+    return { printWidth: Infinity };
+  }
+
   const eslintPrettierOptions = eslintPrettierRules[1] || {};
@@ -330,2 +336,12 @@ const usePrettierrc = !eslintPrettierOptions || eslintPrettierOptions.usePrettierrc !== false;
 
+  if (!('printWidth' in prettierOptions)) {
+    // 80 is prettier default
+    // eslint-disable-next-line no-console
+    console.warn(
+      'WARNING(eslint-plugin-decorator-position): printWidth not set in the prettier config, defaulting to 80'
+    );
+
+    return { ...prettierOptions, ...userOptions, printWidth: 80 };
+  }
+
   return Object.assign({}, prettierOptions, userOptions);
@@ -332,0 +348,0 @@ }

package.json

 {
   "name": "eslint-plugin-decorator-position",
-  "version": "2.2.8",
+  "version": "2.2.9",
   "description": "ESLint plugin for enforcing decorator position",
@@ -16,3 +16,3 @@ "main": "lib/index.js",
     "lint": "npm-run-all lint:* --continue-on-error",
-    "lint:docs": "markdownlint '**/*.md' -i CHANGELOG.md -i LICENSE.md -i node_modules",
+    "lint:docs": "markdownlint '**/*.md'",
     "lint:docs-js": "eslint . --cache --ext md",
@@ -19,0 +19,0 @@ "lint:js": "eslint . --cache",

README.md

@@ -90,4 +90,32 @@ # eslint-plugin-decorator-position
 
+### Running smoke tests and creating reproductions
+
+To run smoke tests:
+
+```shell
+./scripts/smoke-test.sh
+```
+
+it will prompt you with which test to run.
+
+To create a reproduction,
+
+1. first make sure there is an open issue describing the problem your encountering.
+2. then create a folder in `smoke-tests/issue-reproductions/` named ofter the issue number.
+   example: `smoke-tests/issue-reproductions/196/`
+3. The minimum required files are:
+   - package.json - for declaring which dependencies are being tested (or `*` if it doesn't matter for your particular test)
+   - a js or ts file to demonstrate the "correct" state. After a smoke-test runs, a git diff is checked to ensure 0 changes.
+   - .eslintrc.js - to define what configuration / rules / plugins / etc may be relevant.
+
+## SemVer Policy
+
+How does this project interpret patch / minor / breaking changes?
+
+- **patch**: a change that fixes currently broken behavior. Does not cause formatting to change when people update unless a previous patch/feature accidentally broke formatting in a **breaking** way.
+- **minor**: a change that does not impact formatting
+- **breaking**: a major change that is not backwards compatible and would intentionally cause formatting changes to occur
+
 ## 🔓 License
 
 See the [LICENSE](LICENSE.md) file for license rights and limitations (MIT).

No alert changes

Improved metrics

Total package byte prevSize

32257

increased by6.78%

Lines of code

423

increased by2.92%

Number of lines in readme file

121

increased by30.11%

No dependency changes