eslint-plugin-ember - npm Package Compare versions

Comparing version 6.3.0 to 6.4.0

CHANGELOG.md

 # Changelog
 
+## v6.4.0 (2019-04-21)
+
+#### :rocket: Enhancement
+* [#403](https://github.com/ember-cli/eslint-plugin-ember/pull/403) Add new `no-get-properties` rule ([@bmish](https://github.com/bmish))
+* [#404](https://github.com/ember-cli/eslint-plugin-ember/pull/404) Add new `no-get` rule ([@bmish](https://github.com/bmish))
+
+#### :bug: Bug Fix
+* [#398](https://github.com/ember-cli/eslint-plugin-ember/pull/398) `no-unnecessary-route-path-option`: fix error when `path` is undefined ([@bmish](https://github.com/bmish))
+
+#### :memo: Documentation
+* [#411](https://github.com/ember-cli/eslint-plugin-ember/pull/411) Update contributors ([@bmish](https://github.com/bmish))
+* [#409](https://github.com/ember-cli/eslint-plugin-ember/pull/409) Update documentation for `require-return-from-computed` rule ([@esbanarango](https://github.com/esbanarango))
+
+#### Committers: 2
+- Bryan Mishkin ([@bmish](https://github.com/bmish))
+- Esteban Arango Medina ([@esbanarango](https://github.com/esbanarango))
+
 ## v6.3.0 (2019-03-19)
@@ -4,0 +21,0 @@

lib/index.js

@@ -24,2 +24,4 @@ 'use strict';
     'no-function-prototype-extensions': require('./rules/no-function-prototype-extensions'),
+    'no-get-properties': require('./rules/no-get-properties'),
+    'no-get': require('./rules/no-get'),
     'no-global-jquery': require('./rules/no-global-jquery'),
@@ -26,0 +28,0 @@ 'no-invalid-debug-function-arguments': require('./rules/no-invalid-debug-function-arguments'),

lib/recommended-rules.js

@@ -26,2 +26,4 @@ /*
   "ember/no-function-prototype-extensions": "error",
+  "ember/no-get-properties": "off",
+  "ember/no-get": "off",
   "ember/no-global-jquery": "error",
@@ -51,2 +53,2 @@ "ember/no-invalid-debug-function-arguments": "off",
   "ember/use-ember-get-and-set": "off"
-}
+}

lib/rules/no-invalid-debug-function-arguments.js

@@ -47,4 +47,4 @@ 'use strict';
     node.arguments.length >= 2 &&
-    !isString(node.arguments[0]) &&
-    isString(node.arguments[1])
+    !utils.isString(node.arguments[0]) &&
+    utils.isString(node.arguments[1])
   );
@@ -63,5 +63,1 @@ }
 }
-
-function isString(node) {
-  return utils.isTemplateLiteral(node) || (utils.isLiteral(node) && typeof node.value === 'string');
-}

lib/rules/no-unnecessary-route-path-option.js

@@ -68,2 +68,6 @@ 'use strict';
 function pathMatchesRouteName(path, routeName) {
+  if (!path || !routeName) {
+    return false;
+  }
+
   const pathWithoutOptionalLeadingSlash = path.substring(0, 1) === '/' ? path.substring(1) : path;
@@ -70,0 +74,0 @@ return pathWithoutOptionalLeadingSlash === routeName;

lib/utils/utils.js

@@ -23,2 +23,3 @@ 'use strict';
   isGlobalCallExpression,
+  isString,
   getSize,
@@ -271,2 +272,6 @@ parseCallee,
 
+function isString(node) {
+  return isTemplateLiteral(node) || (isLiteral(node) && typeof node.value === 'string');
+}
+
 /**
@@ -273,0 +278,0 @@ * Get size of expression in lines

package.json

 {
   "name": "eslint-plugin-ember",
-  "version": "6.3.0",
+  "version": "6.4.0",
   "description": "Eslint plugin for Ember.js apps",
@@ -56,8 +56,8 @@ "main": "lib/index.js",
     "eslint-config-airbnb-base": "^11.1.0",
-    "eslint-plugin-import": "^2.16.0",
-    "jest": "^24.5.0",
+    "eslint-plugin-import": "^2.17.2",
+    "jest": "^24.7.1",
     "lerna-changelog": "^0.8.2"
   },
   "dependencies": {
-    "ember-rfc176-data": "^0.3.8",
+    "ember-rfc176-data": "^0.3.9",
     "snake-case": "^2.1.0"
@@ -64,0 +64,0 @@ },

README.md

@@ -92,2 +92,4 @@ # eslint-plugin-ember
 | :white_check_mark: | [no-function-prototype-extensions](./docs/rules/no-function-prototype-extensions.md) | Prevents usage of Ember's `function` prototype extensions |
+|  | [no-get-properties](./docs/rules/no-get-properties.md) | Disallow unnecessary usage of Ember's `getProperties` function |
+|  | [no-get](./docs/rules/no-get.md) | Disallow unnecessary usage of Ember's `get` function |
 | :white_check_mark: | [no-global-jquery](./docs/rules/no-global-jquery.md) | Prevents usage of global jQuery object |
@@ -181,12 +183,13 @@ |  | [no-jquery](./docs/rules/no-jquery.md) | Disallow any usage of jQuery |
 ## ⭐️ Contributors
+- [Adrian Zalewski](https://github.com/bardzusny)
+- [Alex LaFroscia](https://github.com/alexlafroscia)
+- [Bryan Mishkin](https://github.com/bmish)
+- [Casey Watts](https://github.com/caseywatts)
+- [Jacek Bandura](https://github.com/jbandura)
+- [Kamil Ejsymont](https://github.com/netes)
 - [Michał Sajnóg](https://github.com/michalsnik)
 - [Rafał Leszczyński](https://github.com/rafleszczynski)
-- [Adrian Zalewski](https://github.com/bardzusny)
-- [Kamil Ejsymont](https://github.com/netes)
-- [Casey Watts](https://github.com/caseywatts)
+- [Robert Wagner](https://github.com/rwwagner90)
 - [Steve Gargan](https://github.com/sgargan)
-- [Alex LaFroscia](https://github.com/alexlafroscia)
 - [Tobias Bieniek](https://github.com/Turbo87)
-- [Robert Wagner](https://github.com/rwwagner90)
-- [Jacek Bandura](https://github.com/jbandura)
 
@@ -193,0 +196,0 @@ ##  🙌 Credits

Fixed alerts

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

185640

increased by2.78%

Number of package files

55

increased by3.77%

Lines of code

3722

increased by2.96%

Number of lines in readme file

201

increased by1.52%

Number of medium supply chain risk alerts

0

decreased by-100%

Dependency changes

• Updatedember-rfc176-data@^0.3.9