eslint-plugin-ember - npm Package Compare versions

Comparing version 6.5.1 to 6.6.0

CHANGELOG.md

 # Changelog
 
+## v6.6.0 (2019-06-16)
+
+#### :rocket: Enhancement
+* [#429](https://github.com/ember-cli/eslint-plugin-ember/pull/429) Add new `require-computed-macros` rule ([@bmish](https://github.com/bmish))
+
+#### :bug: Bug Fix
+* [#428](https://github.com/ember-cli/eslint-plugin-ember/pull/428) Fix spread operator bug in `no-on-calls-in-components` rule ([@rajasegar](https://github.com/rajasegar))
+
+#### :memo: Documentation
+* [#431](https://github.com/ember-cli/eslint-plugin-ember/pull/431) Add link to `sendAction` deprecation RFC for `closure-actions` rule ([@bmish](https://github.com/bmish))
+
+#### Committers: 2
+- Bryan Mishkin ([@bmish](https://github.com/bmish))
+- Rajasegar Chandran ([@rajasegar](https://github.com/rajasegar))
+
 ## v6.5.1 (2019-05-27)
@@ -4,0 +19,0 @@

lib/index.js

@@ -45,2 +45,3 @@ 'use strict';
     'route-path-style': require('./rules/route-path-style'),
+    'require-computed-macros': require('./rules/require-computed-macros'),
     'require-return-from-computed': require('./rules/require-return-from-computed'),
@@ -47,0 +48,0 @@ 'require-super-in-init': require('./rules/require-super-in-init'),

lib/recommended-rules.js

@@ -47,2 +47,3 @@ /*
   "ember/order-in-routes": "off",
+  "ember/require-computed-macros": "off",
   "ember/require-return-from-computed": "off",
@@ -49,0 +50,0 @@ "ember/require-super-in-init": "error",

lib/rules/closure-actions.js

@@ -9,2 +9,4 @@ 'use strict';
 
+const ERROR_MESSAGE = 'Use closure actions';
+
 module.exports = {
@@ -21,7 +23,7 @@ meta: {
 
+  ERROR_MESSAGE,
+
   create(context) {
-    const message = 'Use closure actions, unless you need bubbling';
-
     const report = function (node) {
-      context.report(node, message);
+      context.report(node, ERROR_MESSAGE);
     };
@@ -28,0 +30,0 @@

lib/rules/no-on-calls-in-components.js

@@ -39,2 +39,3 @@ 'use strict';
     const isOnCall = function (node) {
+      if (!node.value) return false;
       const value = node.value;
@@ -41,0 +42,0 @@ const callee = value.callee;

lib/utils/utils.js

@@ -33,2 +33,3 @@ 'use strict';
   isBinaryExpression,
+  isLogicalExpression,
   isReturnStatement,
@@ -116,2 +117,12 @@ getParent
 /**
+ * Check whether or not a node is an LogicalExpression.
+ *
+ * @param {Object} node The node to check.
+ * @returns {boolean} Whether or not the node is an LogicalExpression.
+ */
+function isLogicalExpression(node) {
+  return node !== undefined && node.type === 'LogicalExpression';
+}
+
+/**
  * Check whether or not a node is an ObjectExpression.
@@ -118,0 +129,0 @@ *

package.json

 {
   "name": "eslint-plugin-ember",
-  "version": "6.5.1",
+  "version": "6.6.0",
   "description": "Eslint plugin for Ember.js apps",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

README.md

@@ -103,2 +103,3 @@ # eslint-plugin-ember
 | :wrench: | [no-unnecessary-service-injection-argument](./docs/rules/no-unnecessary-service-injection-argument.md) | Disallow unnecessary argument when injecting service |
+| :wrench: | [require-computed-macros](./docs/rules/require-computed-macros.md) | Requires using computed property macros when possible |
 |  | [route-path-style](./docs/rules/route-path-style.md) | Enforces usage of kebab-case (instead of snake_case or camelCase) in route paths |
@@ -105,0 +106,0 @@ | :wrench: | [use-ember-get-and-set](./docs/rules/use-ember-get-and-set.md) | Enforces usage of Ember.get and Ember.set |

No alert changes

Improved metrics

Total package byte prevSize

201153

increased by4.66%

Number of package files

57

increased by1.79%

Lines of code

4083

increased by5.91%

Number of lines in readme file

203

increased by0.5%

No dependency changes